OpenBSC

openbsc@lists.osmocom.org

20 participants
4286 discussions

[PATCH] ns: Handle procedure changes for UDP in TS 48.016
by Jacob Erlbeck 05 Jan '16

05 Jan '16

In TS 48.016 the network service procedure change depending on the network link type being used. This mainly affects the reset and test procedures. Not obeying these changes makes it impossible to set up NSVC with equipment relying on them. This commits adds the possibility to be compliant to either specification by adding a configuration option to select the compliance mode explicitly for each NSE. The TS 48.016 mode mainly gains conformance, but hinders dynamic NSCV establishment since there aren't any RESET messages. Therefore that mode is not enabled by default. Note that dynamic NSVC establishment as defined by TS 48.016 is not being implemented, since it does not work with routers using network address translation (NAT). New VTY commands (config-ns node): - nse <0-65535> compliance ts08.16 Just use UDP instead of FR - nse <0-65535> compliance ts48.016 Use the modified procedures Sponsored-by: On-Waves ehf --- include/osmocom/gprs/gprs_ns.h | 8 ++++++ src/gb/gprs_ns.c | 62 ++++++++++++++++++++++++++++++++++++------ src/gb/gprs_ns_vty.c | 31 +++++++++++++++++++++ 3 files changed, 93 insertions(+), 8 deletions(-) diff --git a/include/osmocom/gprs/gprs_ns.h b/include/osmocom/gprs/gprs_ns.h index 7c3b23c..1219307 100644 --- a/include/osmocom/gprs/gprs_ns.h +++ b/include/osmocom/gprs/gprs_ns.h @@ -61,6 +61,11 @@ enum gprs_ns_cs { GPRS_NS_CS_ERROR, /*!< Failed to process message */ }; +enum gprs_ns_spec { + GPRS_NS_TS_08_16 = 0, + GPRS_NS_TS_48_016, +}; + struct gprs_nsvc; /*! \brief Osmocom GPRS callback function type */ typedef int gprs_ns_cb_t(enum gprs_ns_evt event, struct gprs_nsvc *nsvc, @@ -120,10 +125,13 @@ struct gprs_nsvc { enum nsvc_timer_mode timer_mode; struct timeval timer_started; int alive_retries; + enum gprs_ns_spec compliance; unsigned int remote_end_is_sgsn:1; unsigned int persistent:1; unsigned int nsvci_is_valid:1; + unsigned int static_config:1; + unsigned int config_completed:1; struct rate_ctr_group *ctrg; struct osmo_stat_item_group *statg; diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c index a29c946..0e874cf 100644 --- a/src/gb/gprs_ns.c +++ b/src/gb/gprs_ns.c @@ -149,11 +149,28 @@ static const struct osmo_stat_item_group_desc nsvc_statg_desc = { .class_id = OSMO_STATS_CLASS_PEER, }; +static void nsvc_start_timer(struct gprs_nsvc *nsvc, enum nsvc_timer_mode mode); + #define CHECK_TX_RC(rc, nsvc) \ if (rc < 0) \ LOGP(DNS, LOGL_ERROR, "TX failed (%d) to peer %s\n", \ rc, gprs_ns_ll_str(nsvc)); +static int enable_reset_block_proc(const struct gprs_nsvc *nsvc) +{ + return nsvc->compliance != GPRS_NS_TS_48_016 || + !nsvc->static_config || + nsvc->ll != GPRS_NS_LL_UDP; +} + +static int continue_test_proc(const struct gprs_nsvc *nsvc) +{ + return nsvc->compliance == GPRS_NS_TS_48_016 && + nsvc->static_config && + nsvc->ll == GPRS_NS_LL_UDP && + nsvc->remote_end_is_sgsn; +} + struct msgb *gprs_ns_msgb_alloc(void) { struct msgb *msg = msgb_alloc_headroom(NS_ALLOC_SIZE, NS_ALLOC_HEADROOM, @@ -588,16 +605,24 @@ static void gprs_ns_timer_cb(void *data) nsvc->alive_retries++; if (nsvc->alive_retries > nsvc->nsi->timeout[NS_TOUT_TNS_ALIVE_RETRIES]) { - /* mark as dead and blocked */ - nsvc->state = NSE_S_BLOCKED; - rate_ctr_inc(&nsvc->ctrg->ctr[NS_CTR_BLOCKED]); - rate_ctr_inc(&nsvc->ctrg->ctr[NS_CTR_DEAD]); LOGP(DNS, LOGL_NOTICE, "NSEI=%u Tns-alive expired more then " "%u times, blocking NS-VC\n", nsvc->nsei, nsvc->nsi->timeout[NS_TOUT_TNS_ALIVE_RETRIES]); + /* mark as dead */ + nsvc->state = nsvc->state & ~NSE_S_ALIVE; + rate_ctr_inc(&nsvc->ctrg->ctr[NS_CTR_DEAD]); ns_osmo_signal_dispatch(nsvc, S_NS_ALIVE_EXP, 0); - ns_osmo_signal_dispatch(nsvc, S_NS_BLOCK, NS_CAUSE_NSVC_BLOCKED); + + if (continue_test_proc(nsvc)) { + nsvc_start_timer(nsvc, NSVC_TIMER_TNS_TEST); + } else if (enable_reset_block_proc(nsvc)) { + /* mark as blocked */ + nsvc->state = NSE_S_BLOCKED; + rate_ctr_inc(&nsvc->ctrg->ctr[NS_CTR_BLOCKED]); + ns_osmo_signal_dispatch(nsvc, S_NS_BLOCK, + NS_CAUSE_NSVC_BLOCKED); + } return; } /* Tns-test case: send NS-ALIVE PDU */ @@ -1109,6 +1134,14 @@ int gprs_ns_rcvmsg(struct gprs_ns_inst *nsi, struct msgb *msg, return rc; rc = 0; + } else if (nsvc->static_config && !nsvc->config_completed) { + + if (!enable_reset_block_proc(nsvc)) { + nsvc->state = NSE_S_ALIVE; + nsvc_start_timer(nsvc, NSVC_TIMER_TNS_TEST); + } + + nsvc->config_completed = 1; } if (nsvc) @@ -1311,10 +1344,18 @@ int gprs_ns_process_msg(struct gprs_ns_inst *nsi, struct msgb *msg, * NS-ALIVE out of the blue, we might have been re-started * and should send a NS-RESET to make sure everything recovers * fine. */ - if ((*nsvc)->state == NSE_S_BLOCKED) + if ((*nsvc)->state == NSE_S_BLOCKED) { rc = gprs_nsvc_reset((*nsvc), NS_CAUSE_PDU_INCOMP_PSTATE); - else if (!((*nsvc)->state & NSE_S_RESET)) + } else if (!((*nsvc)->state & NSE_S_RESET)) { rc = gprs_ns_tx_alive_ack(*nsvc); + if (!enable_reset_block_proc(*nsvc) && + !((*nsvc)->state & NSE_S_ALIVE)) + { + /* start the test procedure */ + gprs_ns_tx_simple((*nsvc), NS_PDUT_ALIVE); + nsvc_start_timer((*nsvc), NSVC_TIMER_TNS_TEST); + } + } break; case NS_PDUT_ALIVE_ACK: if ((*nsvc)->timer_mode == NSVC_TIMER_TNS_ALIVE) @@ -1605,7 +1646,12 @@ struct gprs_nsvc *gprs_ns_nsip_connect(struct gprs_ns_inst *nsi, nsvc->nsei = nsei; nsvc->remote_end_is_sgsn = 1; - gprs_nsvc_reset(nsvc, NS_CAUSE_OM_INTERVENTION); + if (enable_reset_block_proc(nsvc)) { + gprs_nsvc_reset(nsvc, NS_CAUSE_OM_INTERVENTION); + } else if (continue_test_proc(nsvc)) { + nsvc->state = NSE_S_ALIVE; + nsvc_start_timer(nsvc, NSVC_TIMER_TNS_TEST); + } return nsvc; } diff --git a/src/gb/gprs_ns_vty.c b/src/gb/gprs_ns_vty.c index 5a951dc..1353bf3 100644 --- a/src/gb/gprs_ns_vty.c +++ b/src/gb/gprs_ns_vty.c @@ -91,6 +91,11 @@ static int config_write_ns(struct vty *vty) vty_out(vty, " nse %u remote-role %s%s", nsvc->nsei, nsvc->remote_end_is_sgsn ? "sgsn" : "bss", VTY_NEWLINE); + vty_out(vty, " nse %u compliance %s%s", + nsvc->nsei, + nsvc->compliance == GPRS_NS_TS_08_16 ? + "ts08.16" : "ts48.016", + VTY_NEWLINE); switch (nsvc->ll) { case GPRS_NS_LL_UDP: vty_out(vty, " nse %u encapsulation udp%s", nsvc->nsei, @@ -257,6 +262,7 @@ DEFUN(cfg_nse_nsvc, cfg_nse_nsvci_cmd, if (!nsvc) { nsvc = gprs_nsvc_create(vty_nsi, nsvci); nsvc->nsei = nsei; + nsvc->static_config = 1; } nsvc->nsvci = nsvci; /* All NSVCs that are explicitly configured by VTY are @@ -389,6 +395,30 @@ DEFUN(cfg_nse_remoterole, cfg_nse_remoterole_cmd, return CMD_SUCCESS; } +DEFUN(cfg_nse_compliance, cfg_nse_compliance_cmd, + "nse <0-65535> compliance (ts08.16|ts48.016)", + NSE_CMD_STR + "Set protocol compliance\n" + "Use 3GPP TS 08.16\n" + "Use 3GPP TS 48.016\n") +{ + uint16_t nsei = atoi(argv[0]); + struct gprs_nsvc *nsvc; + + nsvc = gprs_nsvc_by_nsei(vty_nsi, nsei); + if (!nsvc) { + vty_out(vty, "No such NSE (%u)%s", nsei, VTY_NEWLINE); + return CMD_WARNING; + } + + if (!strcmp(argv[1], "ts08.16")) + nsvc->compliance = GPRS_NS_TS_08_16; + else + nsvc->compliance = GPRS_NS_TS_48_016; + + return CMD_SUCCESS; +} + DEFUN(cfg_no_nse, cfg_no_nse_cmd, "no nse <0-65535>", "Delete Persistent NS Entity\n" @@ -593,6 +623,7 @@ int gprs_ns_vty_init(struct gprs_ns_inst *nsi) install_element(L_NS_NODE, &cfg_nse_fr_dlci_cmd); install_element(L_NS_NODE, &cfg_nse_encaps_cmd); install_element(L_NS_NODE, &cfg_nse_remoterole_cmd); + install_element(L_NS_NODE, &cfg_nse_compliance_cmd); install_element(L_NS_NODE, &cfg_no_nse_cmd); install_element(L_NS_NODE, &cfg_ns_timer_cmd); install_element(L_NS_NODE, &cfg_nsip_local_ip_cmd); -- 1.9.1

1 1

libosmocore: broken pybombs installation because of talloc
by Piotr Krysik 31 Dec '15

31 Dec '15

Hi all, libosmocore can't be installed with GNU Radio's pybombs currently. The reason is that libosmocore requires libtalloc which isn't installed automatically by pybombs. Manually the problem can be solved by installing libtalloc-dev package. It would be good to fix the pybombs recipe however. I would do this simply by adding libtalloc-dev to dependencies but I don't know if this is proper solution from your point of view. Can you (libosmocore developers) fix the recipe or tell me how to fix it appropriately? Best Regards, Piotr Krysik

2 1

Problem with RF and states of sysmoBTS
by Diego Fernandez Alonso 29 Dec '15

29 Dec '15

Hi, I have a problem with my sysmoBTS.I restored the system using a sysmocom-recovery.ubi and executing a sysmocom-restore from a backup file .tar. Everything was apparently ok but the RF Active led is switched off, without transmision, and the state of the BTS is not normal. First of all with a serial conexion I received this message: fpgadl: Error: INIT_B LOW during programming and checking the state I get the parameters: OpenBSC> show bts 0 BTS 0 is of nanobts type in band DCS1800, has CI 0 LAC 1, BSIC 63, TSC 7 and 1 TRX Description: (null) MS Max power: 15 dBm Minimum Rx Level for Access: -110 dBm Cell Reselection Hysteresis: 4 dBm RACH TX-Integer: 9 RACH Max transmissions: 7 Channel Description Attachment: yes Channel Description BS-PA-MFRMS: 5 Channel Description BS-AG_BLKS-RES: 1 System Information present: 0x00000000, static: 0x00000000 Unit ID: 1801/0/0, OML Stream ID 0xff NM State: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' Site Mgr NM State: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' GPRS NSE: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' GPRS CELL: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' GPRS NSVC0: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' GPRS NSVC1: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' Paging: 0 pending requests, 20 free slots OML Link state: disconnected. Current Channel Load: OpenBSC> OpenBSC> show trx 0 0 TRX 0 of BTS 0 is on ARFCN 514 Description: (null) RF Nominal Power: 23 dBm, reduced by 20 dB, resulting BS power: 3 dBm NM State: Oper 'NULL', Admin 'Unlocked', Avail 'Power off' Baseband Transceiver NM State: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' ip.access stream ID: 0x00 OpenBSC> I would be very grateful for some idea for recovering the states to 'Enable' Thanks so much. Diego.

2 1

PCU-Testing at CCC
by Jacob Erlbeck 27 Dec '15

27 Dec '15

Hi, it would be great to do some PCU testing at the congress. Branch: jerlbeck/master PCU Configuration: example config NITB/BSC Configuration: At least 2 adjacent PDCH Interesting VTY commands - show tbf all - show ms all - show ms imsi SOME_IMSI Other things to look at: - PCU load (CPU) Please keep me informed on how it works. I'll be able to investigate or fix things on Mon and Tue (and maybe on Sun). Thanks and have fun Jacob -- - Jacob Erlbeck <jerlbeck(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

1 0

Wiki update for B2x0 series
by Sipos Csaba 27 Dec '15

27 Dec '15

Dear list, As of today, I revised and updated the Wiki page for Ettus SDRs. https://openbsc.osmocom.org/trac/wiki/Ettus_USRP_B2xx_family What is tested: - Voice calls (MO and MT with full rate) - Interconnect with Asterisk (voice call routing and interconnecting GSM calls to SIP or other telephony technologies) - SMS (MO and MT) - GPRS What needs to be tested: - Voice calls with half rate and AMR If someone can go through it and revise it, that would be nice. Regards, Csaba

1 0

Osmo-PCU: make error
by Sipos Csaba 26 Dec '15

26 Dec '15

Dear Jacob, Today I started to update my setup to latest master for all the Osmocom projects and hit a compile error with Osmo-PCU: root@D6420:~/newer_osmocom/osmo-pcu# make Making all in src make[1]: Entering directory `/root/newer_osmocom/osmo-pcu/src' CXX gprs_debug.lo CXX csn1.lo CXX gsm_rlcmac.lo CXX gprs_bssgp_pcu.lo In file included from /usr/local/include/osmocom/gsm/prim.h:3:0, from /usr/local/include/osmocom/gprs/gprs_bssgp.h:8, from ./gprs_bssgp_pcu.h:32, from gprs_bssgp_pcu.cpp:22: /usr/local/include/osmocom/core/prim.h:23:27: error: uninitialized const 'osmo_prim_op_names' [-fpermissive] const struct value_string osmo_prim_op_names[5]; ^ In file included from /usr/local/include/osmocom/core/msgb.h:24:0, from /usr/local/include/osmocom/gprs/gprs_ns.h:8, from ./gprs_bssgp_pcu.h:31, from gprs_bssgp_pcu.cpp:22: /usr/local/include/osmocom/core/utils.h:22:8: note: 'const struct value_string' has no user-provided default constructor struct value_string { ^ /usr/local/include/osmocom/core/utils.h:23:15: note: and the implicitly-defined constructor does not initialize 'unsigned int value_string::value' unsigned int value; /*!< \brief numeric value */ ^ make[1]: *** [gprs_bssgp_pcu.lo] Error 1 make[1]: Leaving directory `/root/newer_osmocom/osmo-pcu/src' make: *** [all-recursive] Error 1 I can see that you moving some parts from openbsc to the core library, probably that process is not yet finsihed (or merged to master) and that is causing this problem. Just wanted to give some feedback and notify the list about this. Regards, Csaba

2 3

[PATCH] fix format warnings added by 86ec3118
by Neels Hofmeyr 25 Dec '15

25 Dec '15

Commit 86ec3118 ("msgb: Let msgb_hexdump be more tolerant") added new format warnings to my 64bit build of libosmocore. It's not a pressing matter, really, but the libosmocore build is otherwise clean of such warnings so it'd be nice to keep it that way. This patch fixes the warnings by using PRIdPTR. That seems to be the Correct Way to fix it, but I'm a bit unsure. Thanks for any thoughts! Neels Hofmeyr (1): Fix some recently added formats on 64bit src/msgb.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.1.4

2 2

(no subject)
by Alexander Huemer 25 Dec '15

25 Dec '15

Hi. This patch is for osmo-iuh. Without it the build only works on machines that have the needed headers in the default search path for includes. Otherwise the build fails like this: > gcc -DPACKAGE_NAME=\"osmo-iuh\" -DPACKAGE_TARNAME=\"osmo-iuh\" -DPACKAGE_VERSION=\"0.0\" -DPACKAGE_STRING=\"osmo-iuh\ 0.0\" -DPACKAGE_BUGREPORT=\"\ openbsc(a)lists.osmocom.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"osmo-iuh\" -DVERSION=\"0.0\" -DSTDC_HEADERS=1 -I. -I/home/blackbit/usr/stow/libasn1c/include/ -I/home/blackbit/usr/stow/libasn1c/include/asn1c -I. -g -O2 -MT Criticality.o -MD -MP -MF $depbase.Tpo -c -o Criticality.o Criticality.c &&\ > mv -f $depbase.Tpo $depbase.Po > In file included from Criticality.h:50:0, > from Criticality.c:8: > /home/blackbit/usr/stow/libasn1c/include/asn1c/asn_internal.h:18:33: fatal error: osmocom/core/talloc.h: No such file or directory > compilation terminated. Kind regards, -Alex

2 2

[PATCH] fix build if depenedencies are in distinct directories
by Alexander Huemer 25 Dec '15

25 Dec '15

Hi. This patch is for libosmo-sccp. Without it the build only works on machines that have the needed headers in the default search path for includes. Otherwise the build fails like this: > /bin/bash ../libtool --tag=CC --mode=compile gcc -DPACKAGE_NAME=\"libosmo-sccp\" -DPACKAGE_TARNAME=\"libosmo-sccp\" -DPACKAGE_VERSION=\"0.0.6.3.33-8209\" -DPACKAGE_STRING=\"libosmo-sccp\ 0.0.6.3.33-8209\" -DPACKAGE_BUGREPORT=\"openbsc(a)lists.osmocom.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libosmo-sccp\" -DVERSION=\"0.0.6.3.33-8209\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -I../include -I.. -Wall -I/home/blackbit/usr/stow/libosmocore/include/ -g -O2 -MT sua.lo -MD -MP -MF .deps/sua.Tpo -c -o sua.lo sua.c > libtool: compile: gcc -DPACKAGE_NAME=\"libosmo-sccp\" -DPACKAGE_TARNAME=\"libosmo-sccp\" -DPACKAGE_VERSION=\"0.0.6.3.33-8209\" "-DPACKAGE_STRING=\"libosmo-sccp 0.0.6.3.33-8209\"" -DPACKAGE_BUGREPORT=\"openbsc(a)lists.osmocom.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libosmo-sccp\" -DVERSION=\"0.0.6.3.33-8209\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -I../include -I.. -Wall -I/home/blackbit/usr/stow/libosmocore/include/ -g -O2 -MT sua.lo -MD -MP -MF .deps/sua.Tpo -c sua.c -fPIC -DPIC -o .libs/sua.o > sua.c:32:34: fatal error: osmocom/netif/stream.h: No such file or directory > compilation terminated. Kind regards, -Alex

2 2

osmobts multiple bts
by stanley lary 24 Dec '15

24 Dec '15

Hi, I have followed the steps as in Multi-BTS with Osmocom and a single UmTRX <http://umtrx.org/multi-bts-with-osmocom-and-a-single-umtrx/> but I wasn't able to get the right results. I was able to get both TX transmitting the broadcast channel but when I try to connect my phone, only BTS0 works fine. When I try to change the BTS unit_id, I noticed that only the BTS having the lower unit_id would work while the other one only transmits broadcast signals (ex: unit_id 1801 works if I have 1801 and 1802). Any ideas what could be the problem ? Thank you, <http://umtrx.org/multi-bts-with-osmocom-and-a-single-umtrx/>

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC