OpenBSC

openbsc@lists.osmocom.org

4315 discussions

Move PCU/SGSN/GGSN discussions to osmocom-net-gprs
by Harald Welte 25 Feb '16

25 Feb '16

Hi all, several years ago at an OsmoDevCon, we decided to rename the PCU mailinglist into osmocom-net-grps to expand it to cover all parts of the GPRS/packet-switched systm, and then continue to discuss circuit-switched stuff in openbsc. Over the years it seems the list was more and more forgotten, and all patches were posted here. I would like to propose to move all GPRS / PS related discussion to the osmo-net-gprs mailing list again. Now you can argue that osmo-sgsn, osmo-gbproxy and gtphub are all built inside the openbsc repository. The presence of osmo-sgsn, osmo-gbproxy etc. inside one single OpenBSC git reposiory is a historic legacy, and one that I'm not very proud of. Rather than having more of that overlap/confusion we should probably aim for less and more separation. However, let's wait for the Iu-CS / Iu-PS integration and osmo-cscn (nitb without integrated bsc) first, and then look at how to lay out the source code repositories. Meanwhile, let's please aim at discussing GPRS related topics + patches (particularly PCU bits) on the osmocom-net-gprs list. Thanks for your attention! I think there are a lot of people on the openbsc lists who are primarily interested in OsmoNITB and who are not neccessarily interested in the low-level-bits of the GPRS/EGPRS RLC/MAC layers .... Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

3 3

fyi, my recent patch sets
by Neels Hofmeyr 25 Feb '16

25 Feb '16

This is just to say that all my currently waiting patch sets have been merged to the respective master branches, after due nitpicking by Holger in person (thanks!) with various style/simplicity modifications applied. (The one still open is the int/void* thing, not intended as a patch anyway but more as a question.) So the road is clear now for configuring osmo-nitb with its entire set of own IP addresses, and as a side effect various other osmo-programs also have configurable telnet-VTY, Ctrl-interface and Abis addresses now. To summarize the final result: (1) Abis/IP e1_input ipa bind 10.9.8.7 (2) telnet VTY line vty bind 10.9.8.7 (3) ctrl interface ctrl bind 10.9.8.7 (4) MNCC unix domain socket -M /path/to/socket/file (5) SMPP SMSC smpp local-tcp-ip 10.9.8.7 2775 Is this worth a Wiki entry? ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte

1 0

Smalltalk scalable SMSC project
by Holger Freyther 24 Feb '16

24 Feb '16

Hi all, new year, new approaches. In December I was tasked to think about a real SMSC with SMPP input and SS7 output (or SMPP in the future) and I wrote down my ideas[1] about data storage, approach, how to achieve scaling. What is missing fail-over but there are some ideas for this as well. The implementation will be done using Pharo and at least the first data storage will use mongodb >= 3.2. In the past my Pharo work has not been hosted in git but for this project it will change and maybe it creates some more visibility, historically documentation and debian packages were not too visible but that will be different this time as well. If you are interested in specification, Smalltalk, testing, load testing, SS7 or such please join me in the development. happy hacking holger [1] https://github.com/zecke/osmo-smsc/blob/master/README.asciidoc it will move to git.osmocom.org but I just wanted to have online asciidoc rendering.

1 3

[PATCH 3/3] Add VTY section for Control interface bind address
by Neels Hofmeyr 24 Feb '16

24 Feb '16

This may seem like overkill for a mere const char * config item, but it makes the Control interface VTY commands reusable in any main() scope (inspired by libosmo-abis' VTY config). Add API functions ctrl_vty_init() and ctrl_vty_get_bind_addr(), in new files src/ctrl/control_vty.c and include/osmocom/ctrl/control_vty.h, compiled and/or installed dependent on ENABLE_VTY. Using these functions allows configuring a static const char* with the VTY commands ctrl bind A.B.C.D which callers shall subsequently use to bind the Control interface to a specific local interface address, by passing the return value of ctrl_vty_get_bind_addr() to control_interface_setup(). Add CTRL_NODE to enum node_type, "eating" RESERVED4_NODE to heed that comment on avoiding ABI changes. --- include/Makefile.am | 3 +- include/osmocom/ctrl/control_vty.h | 9 ++++ include/osmocom/vty/command.h | 3 +- src/ctrl/Makefile.am | 4 ++ src/ctrl/control_vty.c | 90 ++++++++++++++++++++++++++++++++++++++ 5 files changed, 107 insertions(+), 2 deletions(-) create mode 100644 include/osmocom/ctrl/control_vty.h create mode 100644 src/ctrl/control_vty.c diff --git a/include/Makefile.am b/include/Makefile.am index a965fb9..ac22ee6 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -117,7 +117,8 @@ nobase_include_HEADERS += \ osmocom/vty/telnet_interface.h \ osmocom/vty/vector.h \ osmocom/vty/vty.h \ - osmocom/vty/ports.h + osmocom/vty/ports.h \ + osmocom/ctrl/control_vty.h endif noinst_HEADERS = \ diff --git a/include/osmocom/ctrl/control_vty.h b/include/osmocom/ctrl/control_vty.h new file mode 100644 index 0000000..d0ef69f --- /dev/null +++ b/include/osmocom/ctrl/control_vty.h @@ -0,0 +1,9 @@ +#pragma once + +/* Add the 'ctrl' section to VTY, containing the 'bind' command. */ +int ctrl_vty_init(void *ctx); + +/* Obtain the IP address configured by the 'ctrl'/'bind A.B.C.D' VTY command. + * This should be fed to ctrl_interface_setup() once the configuration has been + * read. */ +const char *ctrl_vty_get_bind_addr(void); diff --git a/include/osmocom/vty/command.h b/include/osmocom/vty/command.h index 2078e1b..937d2f8 100644 --- a/include/osmocom/vty/command.h +++ b/include/osmocom/vty/command.h @@ -84,6 +84,8 @@ enum node_type { L_NS_NODE, /*!< \brief NS node in libosmo-gb. */ L_BSSGP_NODE, /*!< \brief BSSGP node in libosmo-gb. */ + CTRL_NODE, /*!< \brief Control interface node. */ + /* * When adding new nodes to the libosmocore project, these nodes can be * used to avoid ABI changes for unrelated projects. @@ -91,7 +93,6 @@ enum node_type { RESERVED1_NODE, /*!< \brief Reserved for later extensions */ RESERVED2_NODE, /*!< \brief Reserved for later extensions */ RESERVED3_NODE, /*!< \brief Reserved for later extensions */ - RESERVED4_NODE, /*!< \brief Reserved for later extensions */ _LAST_OSMOVTY_NODE }; diff --git a/src/ctrl/Makefile.am b/src/ctrl/Makefile.am index e6ccafb..b4a3da4 100644 --- a/src/ctrl/Makefile.am +++ b/src/ctrl/Makefile.am @@ -13,3 +13,7 @@ libosmoctrl_la_LIBADD = \ $(top_builddir)/src/libosmocore.la \ $(top_builddir)/src/gsm/libosmogsm.la \ $(top_builddir)/src/vty/libosmovty.la + +if ENABLE_VTY +libosmoctrl_la_SOURCES += control_vty.c +endif diff --git a/src/ctrl/control_vty.c b/src/ctrl/control_vty.c new file mode 100644 index 0000000..7df53b8 --- /dev/null +++ b/src/ctrl/control_vty.c @@ -0,0 +1,90 @@ +/* VTY configuration for Control interface + * + * (C) 2016 by sysmocom s.m.f.c GmbH <info(a)sysmocom.de> + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + * + */ + +#include <stdlib.h> +#include <talloc.h> +#include <osmocom/ctrl/control_vty.h> +#include <osmocom/vty/command.h> + +static void *ctrl_vty_ctx = NULL; +static const char *ctrl_vty_bind_addr = NULL; + +DEFUN(cfg_ctrl_bind_addr, + cfg_ctrl_bind_addr_cmd, + "bind A.B.C.D", + "Set bind address to listen for Control connections\n" + "Local IP address (default 127.0.0.1)\n") +{ + if (ctrl_vty_bind_addr) { + talloc_free((void*)ctrl_vty_bind_addr); + ctrl_vty_bind_addr = NULL; + } + ctrl_vty_bind_addr = talloc_strdup(ctrl_vty_ctx, argv[0]); + return CMD_SUCCESS; +} + +const char *ctrl_vty_get_bind_addr(void) +{ + if (!ctrl_vty_bind_addr) + return "127.0.0.1"; + return ctrl_vty_bind_addr; +} + +struct cmd_node ctrl_node = { + CTRL_NODE, + "%s(config-ctrl)# ", + 1, +}; + +DEFUN(cfg_ctrl, + cfg_ctrl_cmd, + "ctrl", "Configure the Control Interface") +{ + vty->index = NULL; + vty->node = CTRL_NODE; + + return CMD_SUCCESS; +} + +static int config_write_ctrl(struct vty *vty) +{ + /* So far there's only one element. Omit the entire section if the bind + * element is omitted. */ + if (!ctrl_vty_bind_addr) + return CMD_SUCCESS; + + vty_out(vty, "ctrl%s", VTY_NEWLINE); + vty_out(vty, " bind %s%s", ctrl_vty_bind_addr, VTY_NEWLINE); + + return CMD_SUCCESS; +} + +int ctrl_vty_init(void *ctx) +{ + ctrl_vty_ctx = ctx; + install_element(CONFIG_NODE, &cfg_ctrl_cmd); + install_node(&ctrl_node, config_write_ctrl); + + install_element(CTRL_NODE, &cfg_ctrl_bind_addr_cmd); + return 0; +} + -- 2.1.4

2 4

[PATCH 0/3] eliminate some compiler warnings
by Neels Hofmeyr 24 Feb '16

24 Feb '16

These patches eradicate some of the easier-to-fix compiler warnings I keep seeing in almost every dev cycle. I'd be glad to have them on master. One of them is an actual error, ignoring return values. Neels Hofmeyr (3): bsc_nat: fail if VTY telnet port cannot be bound, clarify comment ipaccess_rcvmsg: fix returncode, add partial write warning gsm340_rx_tpdu: comment-out two unused vars openbsc/src/ipaccess/ipaccess-proxy.c | 8 +++++++- openbsc/src/libmsc/gsm_04_11.c | 7 +++++-- openbsc/src/osmo-bsc_nat/bsc_nat.c | 7 +++++-- 3 files changed, 17 insertions(+), 5 deletions(-) -- 2.1.4

1 4

[PATCH 0/6] v2: Allow osmo-nitb bind config (and others)
by Neels Hofmeyr 24 Feb '16

24 Feb '16

This time SMPP is included. Here is the abridged complete overview: Following the previous patch sets for libosmo-abis and libosmocore, this patch set allows configuring ALL of osmo-nitb's local IP addresses and makes it possible to run several osmo-nitb processes alongside each other. (1) Abis/IP (from the libosmo-abis patch) In the config file, have: e1_input ipa bind 10.9.8.7 (2) telnet VTY (prepared by libosmocore patch set) In the config file, have: line vty bind 10.9.8.7 (3) ctrl interface (prepared by libosmocore patch set) In the config file, have: ctrl bind 10.9.8.7 (4) MNCC socket In addition to the old -m option with a fixed socket path, you may now supply a cmdline argument with explicit path: -M /path/to/socket/file (5) SMPP SMSC In the config file, have: smpp local-tcp 10.9.8.7 2775 Neels Hofmeyr (6): enable telnet VTY bind address config for various programs osmo-nitb: add -M to pass specific MNCC socket path osmo-nitb: cosmetic: rename to rf_ctrl_path, following mncc_sock_path osmo-nitb: be strict about cmdline args enable ctrl bind config for various programs smpp: refactor initialization, add bind address openbsc/include/openbsc/bsc_nat.h | 3 +- openbsc/include/openbsc/ctrl.h | 3 +- openbsc/include/openbsc/gprs_sgsn.h | 3 +- openbsc/include/openbsc/mncc.h | 2 +- openbsc/include/openbsc/smpp.h | 4 +- openbsc/src/gprs/gb_proxy_main.c | 12 +++-- openbsc/src/gprs/gtphub_main.c | 11 ++-- openbsc/src/gprs/sgsn_ctrl.c | 5 +- openbsc/src/gprs/sgsn_main.c | 42 ++++++++++----- openbsc/src/libbsc/bsc_ctrl_lookup.c | 6 ++- openbsc/src/libbsc/bsc_init.c | 6 ++- openbsc/src/libmsc/mncc_sock.c | 9 ++-- openbsc/src/libmsc/smpp_openbsc.c | 43 +++++++++------ openbsc/src/libmsc/smpp_smsc.c | 93 ++++++++++++++++++++++++--------- openbsc/src/libmsc/smpp_smsc.h | 7 ++- openbsc/src/libmsc/smpp_vty.c | 75 +++++++++++++++++++++----- openbsc/src/osmo-bsc/osmo_bsc_main.c | 10 +++- openbsc/src/osmo-bsc_mgcp/mgcp_main.c | 6 ++- openbsc/src/osmo-bsc_nat/bsc_nat.c | 22 ++++++-- openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c | 5 +- openbsc/src/osmo-nitb/bsc_hack.c | 43 ++++++++++----- 21 files changed, 298 insertions(+), 112 deletions(-) -- 2.1.4

1 6

[PATCH] v3 of: configure Abis/IP bind address
by Neels Hofmeyr 24 Feb '16

24 Feb '16

Like in the vty/ctrl patch set, just talloc_free(NULL) and save two lines of code. Neels Hofmeyr (1): ipa driver: make bind address vty configurable include/internal.h | 3 +++ include/osmocom/abis/e1_input.h | 1 + src/e1_input_vty.c | 20 ++++++++++++++++++++ src/input/ipaccess.c | 26 ++++++++++++++++++++++++-- 4 files changed, 48 insertions(+), 2 deletions(-) -- 2.1.4

1 1

[PATCH 0/3] v2 of: prepare configuration of vty-telnet and ctrl binds
by Neels Hofmeyr 24 Feb '16

24 Feb '16

incorporated all comments. * improved comment * just talloc_free(NULL) * don't break ctrl_interface_setup() API * L_CTRL_NODE Neels Hofmeyr (3): vty: add bind command for telnet vty line add ctrl_interface_setup_dynip() for bind address vty: add ctrl section for Control interface bind address include/Makefile.am | 3 +- include/osmocom/ctrl/control_if.h | 4 ++ include/osmocom/ctrl/control_vty.h | 9 ++++ include/osmocom/vty/command.h | 2 +- include/osmocom/vty/vty.h | 3 ++ src/ctrl/Makefile.am | 4 ++ src/ctrl/control_if.c | 10 ++++- src/ctrl/control_vty.c | 90 ++++++++++++++++++++++++++++++++++++++ src/vty/vty.c | 28 ++++++++++++ 9 files changed, 150 insertions(+), 3 deletions(-) create mode 100644 include/osmocom/ctrl/control_vty.h create mode 100644 src/ctrl/control_vty.c -- 2.1.4

1 3

[PATCH 0/6] Allow osmo-nitb bind config (and others)
by Neels Hofmeyr 24 Feb '16

24 Feb '16

Following the previous patch sets for libosmo-abis and libosmocore, this patch set allows configuring almost all of the osmo-nitb IP addresses. The goal is to allow several osmo-nitb processes to run alongside each other. (1) Abis/IP (from the libosmo-abis patch) in the config file, have: e1_input ipa bind 10.9.8.7 (2) telnet VTY (prepared by libosmocore patch set) in the config file, have: line vty bind 127.0.0.99 (3) ctrl interface (prepared by libosmocore patch set) in the config file, have: ctrl bind 127.0.0.99 (4) MNCC socket In addition to the old -m option with a fixed socket path, you may now supply a cmdline argument with explicit path: -M /path/to/socket/file (5) still TODO: SMPP SMSC libsmpp34 is still listening on 0.0.0.0:2775, requires a change in libsmpp34. Will follow in a subsequent patch. Neels Hofmeyr (6): enable telnet VTY bind address config for various programs osmo-nitb: add -M to pass specific MNCC socket path osmo-nitb: cosmetic: rename to rf_ctrl_path, following mncc_sock_path osmo-nitb: be strict about cmdline args enable ctrl bind config for various programs bsc_nat: fail if VTY telnet port cannot be bound openbsc/include/openbsc/bsc_nat.h | 3 ++- openbsc/include/openbsc/ctrl.h | 3 ++- openbsc/include/openbsc/gprs_sgsn.h | 3 ++- openbsc/include/openbsc/mncc.h | 2 +- openbsc/src/gprs/gb_proxy_main.c | 12 ++++++---- openbsc/src/gprs/gtphub_main.c | 11 ++++++--- openbsc/src/gprs/sgsn_ctrl.c | 5 ++-- openbsc/src/gprs/sgsn_main.c | 42 ++++++++++++++++++++++----------- openbsc/src/libbsc/bsc_ctrl_lookup.c | 6 +++-- openbsc/src/libbsc/bsc_init.c | 6 ++++- openbsc/src/libmsc/mncc_sock.c | 9 +++---- openbsc/src/osmo-bsc/osmo_bsc_main.c | 10 +++++++- openbsc/src/osmo-bsc_mgcp/mgcp_main.c | 6 ++++- openbsc/src/osmo-bsc_nat/bsc_nat.c | 21 ++++++++++++++--- openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c | 5 ++-- openbsc/src/osmo-nitb/bsc_hack.c | 39 ++++++++++++++++++++---------- 16 files changed, 130 insertions(+), 53 deletions(-) -- 2.1.4

1 1

[PATCH] Explicitly initialize m_v_n and m_v_b
by msuraev＠sysmocom.de 24 Feb '16

24 Feb '16

From: Max <msuraev(a)sysmocom.de> Call reset() to initialize m_v_b in gprs_rlc_dl_window() and m_v_n in gprs_rlc_ul_window() constructors. Fixes: Coverity: CID 1351738, 1351737 --- src/rlc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/rlc.h b/src/rlc.h index 54f28df..c3c03e0 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -448,6 +448,7 @@ inline gprs_rlc_dl_window::gprs_rlc_dl_window() : m_v_s(0) , m_v_a(0) { + m_v_b.reset(); } inline const uint16_t gprs_rlc_dl_window::v_s() const @@ -494,6 +495,7 @@ inline gprs_rlc_ul_window::gprs_rlc_ul_window() : m_v_r(0) , m_v_q(0) { + m_v_n.reset(); } inline bool gprs_rlc_ul_window::is_in_window(uint16_t bsn) const -- 2.7.1

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC