OpenBSC

openbsc@lists.osmocom.org

4315 discussions

Change in osmo-pcap[master]: todo: Add another of my wishlist items
by gerrit-no-reply＠lists.osmocom.org 10 May '16

10 May '16

>From Harald Welte <laforge(a)gnumonks.org>: Harald Welte has posted comments on this change. Change subject: todo: Add another of my wishlist items ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/27 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a6c473a97d04aecae8101a024edb734bbe24401 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger(a)freyther.de> Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No

1 0

Change in libosmocore[master]: debian: Fix packaging and make sure python2 exists
by gerrit-no-reply＠lists.osmocom.org 10 May '16

10 May '16

>From Holger Freyther <holger(a)freyther.de>: Holger Freyther has uploaded a new change for review. https://gerrit.osmocom.org/37 Change subject: debian: Fix packaging and make sure python2 exists ...................................................................... debian: Fix packaging and make sure python2 exists Change-Id: Iaa26f4331966d015b193d2ab1e34621b1e319ef1 --- M debian/control 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/37/37/1 diff --git a/debian/control b/debian/control index 42ebdba..468bd07 100644 --- a/debian/control +++ b/debian/control @@ -2,7 +2,7 @@ Section: libs Priority: optional Maintainer: Harald Welte <laforge(a)gnumonks.org> -Build-Depends: debhelper (>= 9), autotools-dev, autoconf, automake, libtool, dh-autoreconf, libdpkg-perl, git, doxygen, libpcsclite-dev, pkg-config, libtalloc-dev +Build-Depends: debhelper (>= 9), autotools-dev, autoconf, automake, libtool, dh-autoreconf, libdpkg-perl, git, doxygen, libpcsclite-dev, pkg-config, libtalloc-dev, python-minimal Standards-Version: 3.9.6 Homepage: http://bb.osmocom.org/trac/wiki/libosmocore Vcs-Git: git://git.osmocom.org/libosmocore.git -- To view, visit https://gerrit.osmocom.org/37 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaa26f4331966d015b193d2ab1e34621b1e319ef1 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger(a)freyther.de>

1 4

Change in libosmocore[master]: api doc: auth_core.c: add \returns, cosmetic
by gerrit-no-reply＠lists.osmocom.org 10 May '16

10 May '16

>From Neels Hofmeyr <nhofmeyr(a)sysmocom.de>: Neels Hofmeyr has submitted this change and it was merged. Change subject: api doc: auth_core.c: add \returns, cosmetic ...................................................................... api doc: auth_core.c: add \returns, cosmetic Add various missing \returns doxygen entries. In osmo_auth_3g_from_2g(), also adjust two comment-closing instances to match common style and add a period to end a sentence. (The recent addition of osmo_auth_3g_from_2g() raised my attention, and I added more return value docs while at it.) Change-Id: Iea71eb666bc061acb6b14215f398bd38d17b3ad3 Reviewed-on: https://gerrit.osmocom.org/33 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger(a)freyther.de> --- M src/gsm/auth_core.c 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Holger Freyther: Looks good to me, approved diff --git a/src/gsm/auth_core.c b/src/gsm/auth_core.c index b78cdd5..f1ec2ed 100644 --- a/src/gsm/auth_core.c +++ b/src/gsm/auth_core.c @@ -43,6 +43,7 @@ /*! \brief Register an authentication algorithm implementation with the core * \param[in] impl Structure describing implementation and it's callbacks + * \returns 0 on success, or a negative error code on failure * * This function is called by an authentication implementation plugin to * register itself with the authentication core. @@ -64,6 +65,7 @@ /*! \brief Load all available authentication plugins from the given path * \param[in] path Path name of the directory containing the plugins + * \returns number of plugins loaded in case of success, negative in case of error * * This function will load all plugins contained in the specified path. */ @@ -75,6 +77,7 @@ /*! \brief Determine if a given authentication algorithm is supported * \param[in] algo Algorithm which should be checked + * \returns 1 if algo is supported, 0 if not, negative error on failure * * This function is used by an application to determine at runtime if a * given authentication algorithm is supported or not. @@ -111,10 +114,12 @@ /*! \brief Generate 3G CK + IK from 2G authentication vector * \param vec Authentication Vector to be modified + * \returns 1 if the vector was changed, 0 otherwise * * This function performs the C5 and C4 functions to derive the UMTS key * material from the GSM key material in the supplied vector, _if_ the input - * vector doesn't yet have UMTS authentication capability */ + * vector doesn't yet have UMTS authentication capability. + */ int osmo_auth_3g_from_2g(struct osmo_auth_vector *vec) { if ((vec->auth_types & OSMO_AUTH_TYPE_GSM) && @@ -124,7 +129,7 @@ /* We cannot actually set OSMO_AUTH_TYPE_UMTS as we have no * AUTN and no RES, and thus can only perform GSM * authentication with this tuple. - * */ + */ return 1; } @@ -135,6 +140,7 @@ * \param[out] vec Generated authentication vector * \param[in] aud Subscriber-specific key material * \param[in] _rand Random challenge to be used + * \returns 0 on success, negative error on failure * * This function performs the core cryptographic function of the AUC, * computing authentication triples/quintuples based on the permanent @@ -167,6 +173,7 @@ * \param[in] rand_auts RAND value sent by the SIM/MS * \param[in] auts AUTS value sent by the SIM/MS * \param[in] _rand Random challenge to be used to generate vector + * \returns 0 on success, negative error on failure * * This function performs a special variant of the core cryptographic * function of the AUC: computing authentication triples/quintuples -- To view, visit https://gerrit.osmocom.org/33 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea71eb666bc061acb6b14215f398bd38d17b3ad3 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>

1 0

[PATCH 1/5] Use enum for subscriber creation policy
by msuraev＠sysmocom.de 10 May '16

10 May '16

From: Max <msuraev(a)sysmocom.de> This enables easier expansion of available policies in future. --- openbsc/include/openbsc/gsm_data.h | 5 +++++ openbsc/src/libbsc/net_init.c | 2 +- openbsc/src/libmsc/vty_interface_layer3.c | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/openbsc/include/openbsc/gsm_data.h b/openbsc/include/openbsc/gsm_data.h index 6d7aba3..593a86f 100644 --- a/openbsc/include/openbsc/gsm_data.h +++ b/openbsc/include/openbsc/gsm_data.h @@ -18,6 +18,11 @@ struct gsm_subscriber_group; #define OBSC_LINKID_CB(__msgb) (__msgb)->cb[3] +enum gsm_subscr_ext_alloc_policy { + GSM_SUBSCR_DONT_CREATE = 0, + GSM_SUBSCR_RANDOM_EXT = 1, +}; + enum gsm_security_event { GSM_SECURITY_NOAVAIL, GSM_SECURITY_AUTH_FAILED, diff --git a/openbsc/src/libbsc/net_init.c b/openbsc/src/libbsc/net_init.c index 568a0b8..00a8a9b 100644 --- a/openbsc/src/libbsc/net_init.c +++ b/openbsc/src/libbsc/net_init.c @@ -48,7 +48,7 @@ struct gsm_network *gsm_network_init(uint16_t country_code, uint16_t network_cod INIT_LLIST_HEAD(&net->bsc_data->mscs); net->subscr_group->net = net; - net->create_subscriber = 1; + net->create_subscriber = GSM_SUBSCR_RANDOM_EXT; net->country_code = country_code; net->network_code = network_code; diff --git a/openbsc/src/libmsc/vty_interface_layer3.c b/openbsc/src/libmsc/vty_interface_layer3.c index 790fedf..4dd0573 100644 --- a/openbsc/src/libmsc/vty_interface_layer3.c +++ b/openbsc/src/libmsc/vty_interface_layer3.c @@ -1036,7 +1036,7 @@ DEFUN(cfg_nitb_subscr_create, cfg_nitb_subscr_create_cmd, "Make a new record when a subscriber is first seen.\n") { struct gsm_network *gsmnet = gsmnet_from_vty(vty); - gsmnet->create_subscriber = 1; + gsmnet->create_subscriber = GSM_SUBSCR_RANDOM_EXT; return CMD_SUCCESS; } @@ -1045,7 +1045,7 @@ DEFUN(cfg_nitb_no_subscr_create, cfg_nitb_no_subscr_create_cmd, NO_STR "Make a new record when a subscriber is first seen.\n") { struct gsm_network *gsmnet = gsmnet_from_vty(vty); - gsmnet->create_subscriber = 0; + gsmnet->create_subscriber = GSM_SUBSCR_DONT_CREATE; return CMD_SUCCESS; } -- 2.8.2

3 6

OpenBSC and related projects moved to Gerrit
by Holger Freyther 10 May '16

10 May '16

Hi, as discussed at OsmoDevCon and the mails from last week. The following list of projects have moved to use gerrit for codereview: * libosmocore.git * libosmo-abis.git * libosmo-netif.git * libosmo-sccp.git * libsmpp34.git * openbsc.git * osmo-bts.git * osmo-iuh.git * osmo-pcu.git * cellmgr-ng.git * osmo-sip-connector.git I have created this[1] page with the minimum to set-up gerrit as git-remote, register, configure the account and then hopefully the most frequently used comments. kind regards holger [1] http://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit

1 0

Change in libosmocore[master]: api doc: auth_core.c: add \returns, cosmetic
by gerrit-no-reply＠lists.osmocom.org 09 May '16

09 May '16

>From Neels Hofmeyr <nhofmeyr(a)sysmocom.de>: Neels Hofmeyr has posted comments on this change. Change subject: api doc: auth_core.c: add \returns, cosmetic ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/33/1/src/gsm/auth_core.c File src/gsm/auth_core.c: file comment PS1, Line 46: returns > Inline comment to see how it looks like. :) yellow. -- To view, visit https://gerrit.osmocom.org/33 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea71eb666bc061acb6b14215f398bd38d17b3ad3 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Gerrit-HasComments: Yes

1 0

Change in libosmocore[master]: api doc: auth_core.c: add \returns, cosmetic
by gerrit-no-reply＠lists.osmocom.org 09 May '16

09 May '16

>From zecke <holger(a)freyther.de>: zecke has posted comments on this change. Change subject: api doc: auth_core.c: add \returns, cosmetic ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/33/1/src/gsm/auth_core.c File src/gsm/auth_core.c: PS1, Line 46: returns Inline comment to see how it looks like. :) -- To view, visit https://gerrit.osmocom.org/33 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea71eb666bc061acb6b14215f398bd38d17b3ad3 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: zecke <holger(a)freyther.de> Gerrit-HasComments: Yes

1 0

[PATCH 1/6] Use enum for subscriber creation policy
by msuraev＠sysmocom.de 09 May '16

09 May '16

2 7

LU counters
by Neels Hofmeyr 09 May '16

09 May '16

Hi list, I'm noticing an inaccuracy/ambiguity in the stat counters concerning Location Updating. So far we have: struct gsmnet_stats { struct { struct osmo_counter *reject; <-- inc when MM LU Reject is sent struct osmo_counter *accept; <-- inc when MM LU Accept is sent } loc_upd_resp; } Looks good? Well, not entirely. (1) When we use TMSIs, we first send a LU Accept with a new TMSI, and then expect the MS to respond with a TMSI Realloc Complete message. When that fails to come through, the LU actually ends in failure, even though a LU Accept was sent. (2) In 3G, if a UE sends an Iu Release during LU (e.g. user enables flight mode), we cancel the LU without sending any reply at all, so nothing would be counted. I would like to change the naming and inc hooks to reflect actual LU success or failure. We don't need to count the actual messages sent, right? ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte

2 1

rate ctr examples
by Max 09 May '16

09 May '16

Hi. I'm working on documentation for (rate) counters infrastructure of various Osmocom programs. I've got problems with getting working example for rate_ctr. For instance: ./contrib/bsc_control.py -d localhost -g "rate_ctr.per_hour.nat.bsc.sccp.conn" -p 4250 Got message: ERROR 1 Counter name not found. Although in src/osmo-bsc_nat/bsc_nat_utils.c I see rate_ctr_group_desc with prefix "nat.bsc" and several rate_ctr_desc (including "sccp.conn") defined. What would be the proper way to get those counters? Note: I run ./src/osmo-bsc_nat/osmo-bsc_nat -c ./doc/examples/osmo-bsc_nat/osmo-bsc_nat.cfg for tests built from latest master. -- Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC