OpenBSC

openbsc@lists.osmocom.org

12 participants
4278 discussions

[PATCH net v3 0/3] various gtp fixes
by Andreas Schultz 28 Jan '17

28 Jan '17

I'm sorry for the compile error mess up in the last version. It's no excuse for not test compiling, but the hunks got lost in a rebase. This is the part of the previous "simple gtp improvements" series that Pablo indicated should go into net. The addition of the module alias fixes genl family autoloading, clearing the DF bit fixes a protocol violation in regard to the specification and the netns comparison fixes a corner case of cross netns recv. Andreas v2->v3: fix compiler error introduced in rebase -- Andreas Schultz (3): gtp: add genl family modules alias gtp: clear DF bit on GTP packet tx gtp: fix cross netns recv on gtp socket drivers/net/gtp.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) -- 2.10.2

2 4

HEADS UP: jenkins DOWN
by Neels Hofmeyr 27 Jan '17

27 Jan '17

While I was waiting for jenkins just now, I noticed that it was getting impossibly slow despite an idle CPU. An attempt to restart resulted in failure to launch jenkins due to "Disk quota exceeded". There are things happening that I don't understand (file system is shrinking as I remove files). I need help from Holger (or Harald?), to understand and probably fix with a simple command making more space for the jail... Until then our jenkins will be DOWN :/ ~N -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

2 2

Re: [MERGED] osmo-trx[master]: Do not embed sqlite3 when building
by Neels Hofmeyr 27 Jan '17

27 Jan '17

Looks related to this osmo-trx nightly package build breakage? https://osmocom.org/issues/1928 ~N On Wed, Jan 25, 2017 at 07:42:53PM +0000, Harald Welte wrote: > Harald Welte has submitted this change and it was merged. > > Change subject: Do not embed sqlite3 when building > ...................................................................... > > > Do not embed sqlite3 when building > > Change-Id: If5edadc04c3ff953b451676e55ad3d00d4e43c82 > --- > M Makefile.am > M Makefile.common > 2 files changed, 1 insertion(+), 2 deletions(-) > > Approvals: > Tom Tsou: Looks good to me, approved > Harald Welte: Looks good to me, but someone else must approve > Jenkins Builder: Verified > > > > diff --git a/Makefile.am b/Makefile.am > index 06251f0..f9f5a5c 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -28,7 +28,6 @@ > > # Order must be preserved > SUBDIRS = \ > - sqlite3 \ > CommonLibs \ > GSM \ > Transceiver52M > diff --git a/Makefile.common b/Makefile.common > index 734ab3a..d7927a5 100644 > --- a/Makefile.common > +++ b/Makefile.common > @@ -33,6 +33,6 @@ > > COMMON_LA = $(top_builddir)/CommonLibs/libcommon.la > GSM_LA = $(top_builddir)/GSM/libGSM.la > -SQLITE_LA = $(top_builddir)/sqlite3/libsqlite.la -ldl > +SQLITE_LA = -lsqlite3 > > MOSTLYCLEANFILES = *~ > > -- > To view, visit https://gerrit.osmocom.org/1484 > To unsubscribe, visit https://gerrit.osmocom.org/settings > > Gerrit-MessageType: merged > Gerrit-Change-Id: If5edadc04c3ff953b451676e55ad3d00d4e43c82 > Gerrit-PatchSet: 2 > Gerrit-Project: osmo-trx > Gerrit-Branch: master > Gerrit-Owner: Max <msuraev(a)sysmocom.de> > Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org> > Gerrit-Reviewer: Jenkins Builder > Gerrit-Reviewer: Ruben Undheim <ruben.undheim(a)gmail.com> > Gerrit-Reviewer: Tom Tsou <tom(a)tsou.cc> -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

3 4

[PATCH net v2 0/3] various gtp fixes
by Andreas Schultz 27 Jan '17

27 Jan '17

This is the part of the previous "simple gtp improvements" series that Pablo indicated should go into net. The addition of the module alias fixes genl family autoloading, clearing the DF bit fixes a protocol violation in regard to the specification and the netns comparison fixes a corner case of cross netns recv. I'm not sure if Pablos comments on the previous version qualify as ACK, so I left that out. -- Andreas Schultz (3): gtp: add genl family modules alias gtp: clear DF bit on GTP packet tx gtp: fix cross netns recv on gtp socket drivers/net/gtp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) -- 2.10.2

3 7

test error analysis on build services
by Neels Hofmeyr 27 Jan '17

27 Jan '17

On jenkins and opensuse, we have builds where we cannot easily analyse the testsuite.dir after a build failed. So we only see which tests failed and not why. On jenkins I have in most places added a script invocation that prints all testsuite.dir/*/*.log in case of build failure, so we can see it in the jenkins log right away. On opensuse.org, IIUC, the 'make check' is run by dh or something, so it's not trivial (to me) to make it output the test logs in case of failure. I'm thinking now, don't we always want to see these failures anyway? We could include in our Makefile.am a tweak to print the test logs in case of testsuite failure. Sometimes this output can become fairly large though; e.g. when a long test fails early and prints "nothing", the test log shows a huge diff with all expected output as minus-lines. My main goal right now is to see why/how the libosmo-netif OBS build failed (osmux test fails) without further local reproduction effort. This situation will certainly repeat over and over, for all of the other projects as well. What do you think? Can we get that easily? ~N -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

2 2

jenkins nr of executors
by Neels Hofmeyr 26 Jan '17

26 Jan '17

FYI, no "Broken Pipe" errors in a long time, so today I increased the OsmocomBuild1 nr of executors from 3 to 4 ... and immediately got two subsequent openbsc builds hitting the "Broken Pipe" again. https://jenkins.osmocom.org/jenkins/job/OpenBSC-gerrit/1716/IU=--enable-iu,… https://jenkins.osmocom.org/jenkins/job/OpenBSC-gerrit/1717/IU=--disable-iu… This time I tried something else: lower the "make -j 9" to "make -j 3" and leave the nr of executors at 4... Just dabbling, would be nicer to pinpoint the real cause. ~N -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

1 0

[PATCH 0/5] simple gtp improvements
by Andreas Schultz 25 Jan '17

25 Jan '17

As requested are here the simple and most obvious changes from the larger GTP changeset. I'll break down the rest and send them out separately. The module alias addition and the rcu_lock removal are just small convenience changes. The other changes are needed to correctly implement one of the 3GPP GW functions, userspace needs to see invalid T-PDU's in order to generate the proper error messages, GTP fragmentation rules need the cleared DF bit. Andreas -- Andreas Schultz (5): gtp: add genl family modules alias gtp: clear DF bit on GTP packet tx gtp: fix cross netns recv on gtp socket gtp: remove unnecessary rcu_read_lock gtp: let userspace handle packets for invalid tunnels drivers/net/gtp.c | 33 ++++++++------------------------- 1 file changed, 8 insertions(+), 25 deletions(-) -- 2.10.2

4 14

[PATCH v2 00/18] gtp: fixes and support multiple VRF's per GTP socket
by Andreas Schultz 25 Jan '17

25 Jan '17

The current linking of GTP network devices and GTP enabled sockets means that we can not have multiple VRF's per GTP socket. This series seperates the sockets from network device, makes sockets attached to GTP network device optional and adds a API function to enable GTP encapsulation on socket without having to create a new GTP device. It is still possible to use the old API. The network device attached socket is then used when no socket is specified on PDP context creation. During that work some smaller problems where found and fixes for them are included. v2 changes: * the socket that is hold by the pdp context has to be release in a rcu callback. Otherwise a stray GTP rx could end uo with an invalid socket. * accessing the skb->sk field in gtp_rx is invalid, that field has no been populated at that point * add dst_cache to speed up the routing Regards Andreas -- Andreas Schultz (18): gtp: add genl family modules alias gtp: clear DF bit on GTP packet tx gtp: make GTP sockets in gtp_newlink optional gtp: return error ptr in find pdp helpers gtp: unify genl_find_pdp and prepare for per socket lookup gtp: fix cross netns recv on gtp socket gtp: remove unnecessary rcu_read_lock gtp: consolidate pdp context destruction into helper gtp: use addr_hash when traversing pdp contexts gtp: add socket to pdp context gtp: consolidate gtp socket rx path gtp: let userspace handle packets for invalid tunnels gtp: replace netdev_dbg and KERN_DEBUG printk with pr_debug gtp: move TEID hash to per socket structure gtp: rename gtp hashtable helpers gtp: add genl cmd to enable GTP encapsulation on UDP socket gtp: add support to select a GTP socket during PDP context creation gtp: add dst_cache support drivers/net/gtp.c | 714 +++++++++++++++++++++++++++-------------------- include/uapi/linux/gtp.h | 4 + 2 files changed, 422 insertions(+), 296 deletions(-) -- 2.10.2

3 20

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/x86_64
by OBS Notification 24 Jan '17

24 Jan '17

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 408s] #define HAVE_SYS_TYPES_H 1 [ 408s] #define HAVE_SYS_STAT_H 1 [ 408s] #define HAVE_STDLIB_H 1 [ 408s] #define HAVE_STRING_H 1 [ 408s] #define HAVE_MEMORY_H 1 [ 408s] #define HAVE_STRINGS_H 1 [ 408s] #define HAVE_INTTYPES_H 1 [ 408s] #define HAVE_STDINT_H 1 [ 408s] #define HAVE_UNISTD_H 1 [ 408s] #define HAVE_DLFCN_H 1 [ 408s] #define LT_OBJDIR ".libs/" [ 408s] #define STDC_HEADERS 1 [ 408s] #define HAVE_BYTESWAP_H 1 [ 408s] #define TIME_WITH_SYS_TIME 1 [ 408s] [ 408s] configure: exit 1 [ 408s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu --libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 408s] debian/rules:6: recipe for target 'build' failed [ 408s] make: *** [build] Error 255 [ 408s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 408s] [ 408s] cloud116 failed "build osmo-trx_0.1.9.20170117.dsc" at Tue Jan 17 20:00:47 UTC 2017. [ 408s] [ 408s] ### VM INTERACTION START ### [ 411s] [ 364.791340] reboot: Power down [ 412s] ### VM INTERACTION END ### [ 412s] [ 412s] cloud116 failed "build osmo-trx_0.1.9.20170117.dsc" at Tue Jan 17 20:00:52 UTC 2017. [ 412s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)

6 12

[PATCH 00/17] gtp: fixes and support multiple VRF's per GTP socket
by Andreas Schultz 23 Jan '17

23 Jan '17

The current linking of GTP network devices and GTP enabled sockets means that we can not have multiple VRF's per GTP socket. This series seperates the sockets from network device, makes sockets attached to GTP network device optional and adds a API function to enable GTP encapsulation on socket without having to create a new GTP device. It is still possible to use the old API. The network device attached socket is then used when no socket is specified on PDP context creation. During that work some smaller problems where found and fixes for them are included. Regards Andreas -- Andreas Schultz (17): gtp: add genl family modules alias gtp: clear DF bit on GTP packet tx gtp: make GTP sockets in gtp_newlink optional gtp: return error ptr in find pdp helpers gtp: unify genl_find_pdp and prepare for per socket lookup gtp: fix cross netns recv on gtp socket gtp: remove unnecessary rcu_read_lock gtp: consolidate pdp context destruction into helper gtp: use addr_hash when traversing pdp contexts gtp: add socket to pdp context gtp: consolidate gtp socket rx path gtp: let userspace handle packets for invalid tunnels gtp: replace netdev_dbg and KERN_DEBUG printk with pr_debug gtp: move TEID hash to per socket structure gtp: rename gtp hashtable helpers gtp: add genl cmd to enable GTP encapsulation on UDP socket gtp: add support to select a GTP socket during PDP context creation drivers/net/gtp.c | 681 +++++++++++++++++++++++++++-------------------- include/uapi/linux/gtp.h | 4 + 2 files changed, 392 insertions(+), 293 deletions(-) -- 2.10.2

1 17

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC