OpenBSC

openbsc@lists.osmocom.org

4 participants
4156 discussions

[nhofmeyr@sysmocom.de: Re: Help required on : Reproducing the issue]

by Neels Hofmeyr

On Wed, Dec 14, 2016 at 02:24:23PM +0000, Pravin Kumaravel Manoharan wrote: > I tried to reproduce the issue mentioned in http://lists.osmocom.org/pipermail/openbsc/2016-December/009966.html . > While running sanitizer script I got an error gcc: error: unrecognized command line option '-fsanitize=undefined' > So, to avoid this I removed the option from CFLAGS+= and CXXFLAGS+= . That's odd, all compilers I've used so far apparently support -fsanitize=address -fsanitize=undefined anyway: > Then I got the following error : > ERROR: Address Sanitizer: heap-use-after-free on address 0x60380000a00c at pc 0x436acf bp 0x7ffc4456d4e0 sp 0x7ffc4456d4d8 > but I didn't get any SIGSEGV in sgsn_create_pdp_ctx(). Have you reversed the order of those two lines I wrote about earlier to fix the use-after-free yet? This is what I wrote: > I found a use-after-free which isn't the cause for above asan failure: > > gsm0408_gprs_access_cancelled(mm, GMM_CAUSE_GPRS_NOTALLOWED); > LOGMMCTXP(LOGL_NOTICE, mm, "No PDP context to deactivate\n"); > > gsm0408_gprs_access_cancelled() calls mm_ctx_cleanup_free(), and after that the > local mm is non-NULL but freed. Change the order to: > > LOGMMCTXP(LOGL_NOTICE, mm, "No PDP context to deactivate\n"); > gsm0408_gprs_access_cancelled(mm, GMM_CAUSE_GPRS_NOTALLOWED); > > (This second issue is shown when removing test_pdp_deactivation_with_pdp_ctx() > from test_pdp_deactivation()) If you do that, do you still get any asan errors? I hope that you'll be able to reproduce the segfault, since it was seen on both our build server as well as my own laptop... ~N -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte ----- End forwarded message ----- -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

8 years, 6 months

git tagging

by Max

Hi. With the migration to gerrit the situation around version tagging become even funnier than before. For example right now in libosmocore v0.9.3 does not exist as a git tag, only as entry in debian/changelog. Versions 0.9.5 and 0.9.6 are committed in reversed order - see output of git log --tags --show-notes --decorate | grep 'tag:' | head So the questions are: - how can I add tag '0.9.3' to commit abc46af90fde9e9435dee5f4f472aec3f68d3353 in libosmocore - how can we prevent the inverted commit situation as with 0.9.6 and 0.9.5 in future? - what's the general guidelines for tagging new versions? Do we go through gerrit or ask responsible person (who?) to do it manually? Or even auto-tag commit matching certain criteria? -- Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

8 years, 6 months

Re: libosmocore[master]: Catch-up with git version tags

by Neels Hofmeyr

On Tue, Dec 13, 2016 at 10:58:12PM +0000, Holger Freyther wrote: > Patch Set 1: Code-Review-1 > > The point of TODO-RELEASE is to remember ABI changes. An ABI change requires increasing the version number of the .so files (see the libtool link in Makefile.am for exact rules but we only bump for incompatible versions). Another point here could be that we can't just create a new minor tag without checking this? Does our non-existent policy dictate that an ABI version change should cause a bump in a "middle" version number? i.e. if a commit has been merged that has ABI changes and I want to tag a commit in order to reference it from another project's configure.ac, am I forced to make a bigger version bump than just 0.9.4 -> 0.9.5? All this would be good topics for the next OsmoDevCon... ~N

8 years, 6 months

Re: Osmo-bts/Osmocom-bb virtual layer 1

by Sebastian Stumpf

Hi Harald, > why send a private response and not a mail to the mailing list? Sorry, not intended - misclicked on respond instead of respond to all! :) > If you want, I can give you commit access so you can push your private > branches to git.osmocom.org. I just created an account on osmocom.org and logged in to gerrit via osmocom.org/openid (account: BastusIII). As I have never used git-send-email I prefer the commit access. Thank you! I would call the branches stumpf/virt-phy for both osmo-bts and osmocom-bb. With kind regards, Sebastian Am 12.12.2016 15:15 schrieb "Harald Welte" <laforge(a)gnumonks.org>: Hi Sebastian, why send a private response and not a mail to the mailing list? I think they all are interested to read this. On Mon, Dec 12, 2016 at 01:57:05PM +0100, Sebastian Stumpf wrote: > I have not published the Code yet as the vlayer still lacks some basic > functionality. Would you suggest to do so already? yes, by all means. There's a difference between having code in the public for review / improvements by others and submitting it for inclsion into master as it is considered "fixed" If you want, I can give you commit access so you can push your private branches to git.osmocom.org. For that, you would have to create an account on gerrit.osmocom.org (which requires first creating one on osmocom.org) If you prefer to simply send a patchset by git-send-email or to host you git repos on github or any other git hosting site, that's fine, too. -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

8 years, 6 months

Re: RBS 2308

by Rajitha peiris

Hi dear.... i am tired with rbs 2308.... i have purchased nano bts....but i will try to improve that also.... if you have any updates pls letme... On Harald Welte <laforge(a)gnumonks.org>, Dec 12, 2016 2:45 AM wrote: Hi Rajitha, On Sun, Dec 11, 2016 at 01:02:19PM +0000, Rajitha peiris wrote: > i was spent more time on it....these days i am reading on oml 2000 ...if there new updates i will tell you.... If you run into a specific issue, please always feel free to contact this list. But make sure to include your full config file, openbsc log output and pcap protocol trace. We need sufficient data for any kind of investigation. -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

8 years, 7 months

new sanitizer breakage: SIGSEGV in sgsn_create_pdp_ctx()

by Neels Hofmeyr

The sanitizer build used to get through to testing the PCU, now it already fails at openbsc's sgsn test. This happens in the recently added test_pdp_deactivation_with_pdp_ctx: http://jenkins.osmocom.org/jenkins/job/Osmocom_Sanitizer/388/consoleFull commit 1611df5226199da2bf2fba3d22d93cc1a6c6c777 Commit: Pravin Kumarvel <pmanohar(a)radisys.com> CommitDate: Mon Dec 12 17:20:39 2016 +0530 Support Deactivate PDP Context Request from network https://gerrit.osmocom.org/1262 I can reproduce the segmentation fault locally, but only when the sanitizer is enabled. When stepping up to the failure and checking the parameters, all seems to be in order; immediately when trying to step into sgsn_create_pdp_ctx(), the SIGSEGV is fired. So far the actual failure is not clear to me, I haven't found the 0x02 pointer yet that asan complains about: ==21897==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000002 I found a use-after-free which isn't the cause for above asan failure: gsm0408_gprs_access_cancelled(mm, GMM_CAUSE_GPRS_NOTALLOWED); LOGMMCTXP(LOGL_NOTICE, mm, "No PDP context to deactivate\n"); gsm0408_gprs_access_cancelled() calls mm_ctx_cleanup_free(), and after that the local mm is non-NULL but freed. Change the order to: LOGMMCTXP(LOGL_NOTICE, mm, "No PDP context to deactivate\n"); gsm0408_gprs_access_cancelled(mm, GMM_CAUSE_GPRS_NOTALLOWED); (This second issue is shown when removing test_pdp_deactivation_with_pdp_ctx() from test_pdp_deactivation()) The cause for the asan failure shown above and in jenkins still evades me. But I'm afraid we have to revert the patch. Please run the asan build on this patch and re-submit when the cause is clear. How to asan build has been discussed recently: http://lists.osmocom.org/pipermail/openbsc/2016-November/009901.html ~N -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

8 years, 7 months

TbfTest fails sanitizer build, please take a look @tbf-folks

by Neels Hofmeyr

Dear authors of Tbf, can you make sense of this build failure? https://jenkins.osmocom.org/jenkins/job/Osmocom_Sanitizer/373/console It shows that the expected stderr output of the TbfTest deviates, and the test exits prematurely. interesting output: +tbf_dl.cpp:766:65: runtime error: load of value 32767, which is not a valid value for type 'egprs_puncturing_values' -- got ack for BSN=1258 -- got ack for BSN=1259 -- got ack for BSN=1260 +- got NACK for BSN=1258 +- got NACK for BSN=1259 +- got NACK for BSN=1260 To help reproducing it, find below the jenkins script that runs this sanitizer build. Thanks for any patches that could fix our sanitizer build! ~Neels #!/bin/sh set -ex export BUILDDIR=$PWD/build/ export PKG_CONFIG_PATH=$BUILDDIR/lib/pkgconfig export LD_LIBRARY_PATH=$BUILDDIR/lib/ export PATH="$PATH:$HOME/osmo-ci/scripts" build() { RET=$PWD git clone git://git.osmocom.org/$1 source/$1 cd source/$1 git checkout -b build-branch origin/$2 cd $3 autoreconf --install --force ./configure --prefix=$BUILDDIR $4 make check CFLAGS+="-fsanitize=address -fsanitize=undefined" CXXFLAGS+="-fsanitize=address -fsanitize=undefined" ASAN_OPTIONS="detect_leaks=0" UBSAN_OPTIONS="print_stacktrace=1:halt_on_error=1" \ || cat-testlogs.sh make install CFLAGS+="-fsanitize=address -fsanitize=undefined" CXXFLAGS+="-fsanitize=address -fsanitize=undefined" cd $RET } rm -rf $BUILDDIR rm -rf source mkdir -p source mkdir -p $BUILDDIR/include/sysmocom/femtobts git clone git://git.sysmocom.de/sysmo-bts/layer1-api.git source/layer1-api/ cp source/layer1-api/include/* $BUILDDIR/include/sysmocom/femtobts/ build libosmocore $LIBOSMOCORE_BRANCH ./ build libosmo-abis $LIBOSMOABIS_BRANCH ./ build libosmo-netif $LIBOSMONETIF_BRANCH ./ build libosmo-sccp $LIBOSMOSCCP_BRANCH ./ # gcc ice's #build libsmpp34 $LIBSMPP_BRANCH build openggsn $OPENGGSN_BRANCH ./ build openbsc $OPENBSC_BRANCH ./openbsc "--enable-nat --enable-osmo-bsc --enable-vty-tests --enable-external-tests" build osmo-pcu $OSMOPCU_BRANCH ./ "--enable-sysmocom-dsp --enable-vty-tests" build osmo-bts $OSMOBTS_BRANCH ./ "--enable-sysmocom-bts --enable-trx" -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

8 years, 7 months

Osmo-bts/Osmocom-bb virtual layer 1

by Sebastian Stumpf

Hi, I further implemented the base of the virtual layer with the purpose of replacing the um-air interface with a multicast-socket solution. This has been started by Harald Welte some time ago in the Osmobts - laforge/virt-bts branch. As I was not really confident enough to create an official new branch before someone had a look on what I did, so I developed in copies of the osmocom-bb and osmo-bts projects on my github-page (https://github.com/BastusIII/osmocom-bb-virt/tree/stumpf/virt-um and https://github.com/BastusIII/osmo-bts-virt/tree/stumpf/virt-bts). If someone finds to time to have a look into them (structure, path, implementation) and give me feedback about it, I would be glad :). Please use the following config files that i have tested: - https://github.com/BastusIII/osmocom-config-files/blob/master/openbsc-virtu… - https://github.com/BastusIII/osmocom-config-files/blob/master/osmobts-virtu… - https://github.com/BastusIII/osmocom-config-files/blob/master/osmocom-bb-mo… What works: BTS: - downlink over gsmtap and a multicast socket - OML and RSL on abis properly established and seems to work - virtual-um connection establishment Osmocom-bb: - virtual-um -- l23 app connection establishment (bridging osmocon, no serial link needed) - BCCH downlink handling and forwarding to l23 app - handling of some l1ctl requests from l23 (e.g. power management had to be mocked, so l23 gets a response and is satisfied) What not: BTS: - missing uplink handling Osmocom-bb - missing uplink routines (RACH, TCH, dedicated channels) - handlers for l23 requests only partially implemented (missing TCH, RACH, ... I a currently a bit overwhelmed by the mass of messages exchanged between l23-app (used mobile, btw.) and the virtual-um and hanging because mobile gets a sync timeout. I am looking forward to hear from you :). Sebastian Stumpf

8 years, 7 months

Re: RBS 2308

by Rajitha peiris

hi dear... i was spent more time on it....these days i am reading on oml 2000 ...if there new updates i will tell you.... regards rajitha Sent from my Mi phone On Holger Freyther <holger(a)freyther.de>, Dec 10, 2016 8:42 PM wrote: > On 10 Dec 2016, at 03:10, Rajitha peiris <raji.oshin(a)hotmail.com> wrote: > > > Hi all.. Hi! > Anyone have success with rbs 2308 ??? > If you have any idea pls share ... your contribution will be very welcome! Do you think you can still spend time on improving OpenBSC in 2016? regards holger

8 years, 7 months

openbsc build was broken due to change in libosmocore: missing doc for 'log gsmtap [HOSTNAME]'

by Neels Hofmeyr

The libosmocore commit aa00f99be2e4cc64ede20d8c9548b83054696581 adds a VTY item that's missing a doc string, hence breaking the openbsc build (which actually checks the doc strings unlike the libosmocore build job). I pushed the fix I734b22c950242541322e902887bf779c14ba10fd and things should light up "green" (aka blue) again. BTW, in a RL discussion lynxis suggested that it would be good if libosmocore commits were also checked against breaking openbsc. A point against it is that often something in libosmocore is changed and requires a follow-up in openbsc -- if the libosmocore build rejects commits that break openbsc, it would make it impossible to get these changes in. The workaround could be to have a secondary build job that merely comments on gerrit whether the openbsc build still works, without having -V voting powers. Anyway, so far I think it is sufficient to catch these hopefully few cases once the regular master build on jenkins.osmocore.org goes up red, like now. ~N -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

8 years, 7 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC