OpenBSC September 2021

openbsc@lists.osmocom.org

7 participants
22 discussions

long long vs int64_t
by Neels Hofmeyr 15 Sep '21

15 Sep '21

On Wed, Sep 15, 2021 at 02:45:42AM +0000, scan-admin(a)coverity.com wrote: > >>> CID 240103: (CONSTANT_EXPRESSION_RESULT) > >>> "val < -9223372036854775808LL /* -9223372036854775807L - 1 */" is always false regardless of the values of its operands. This occurs as the logical operand of "if". > 1434 if (val < INT64_MIN) { > 1435 if (result) > 1436 *result = INT64_MIN; > 1437 return -ERANGE; > 1438 } Yes I know, but is it guaranteed on all archs in past and future that long long int is 64 bit? > >>> CID 240103: (CONSTANT_EXPRESSION_RESULT) > >>> "val > 9223372036854775807L" is always false regardless of the values of its operands. This occurs as the logical operand of "if". > 1439 if (val > INT64_MAX) { > 1440 if (result) > 1441 *result = INT64_MAX; > 1442 return -ERANGE; > 1443 } same. I'd just ignore these warnings if that's ok with everyone else. ~N

2 2

Re: New Defects reported by Coverity Scan for Osmocom
by Neels Hofmeyr 15 Sep '21

15 Sep '21

On Tue, Sep 14, 2021 at 02:45:51AM +0000, scan-admin(a)coverity.com wrote: > 178 } else { > >>> CID 240100: Memory - illegal accesses (BUFFER_SIZE_WARNING) > >>> Calling "strncpy" with a maximum size argument of 64 bytes on destination array "codec->audio_name" of size 64 bytes might leave the destination string unterminated. > 179 strncpy(codec->audio_name, audio_name, sizeof(codec->audio_name)); strncpy() is another word for pitfall. We should *always* use osmo_strlcpy(), or OSMO_STRLCPY_ARRAY() to save typing 'sizeof'. osmith, could we put such a check in the linter maybe? i.e. forbid use of strncpy() and strcpy(). ~N

2 1

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC September 2021