OpenBSC April 2018

openbsc@lists.osmocom.org

15 participants
22 discussions

by Neels Hofmeyr

I client of ours has the desire to merge a patch to libosmocore that adds simplistic log rotation functionality. Our first response was against it: we have the SIGHUP handling that allows logrotate to tell osmocom programs to re-open their log file(s). However, the system in question is based on BusyBox, which lacks logrotate. I haven't yet investigated why it can't just be installed, but there seems to be some or other issue about that. The next best idea is to cook up a shell script that does more or less what logrotate does ... and probably run into problems that logrotate already solves better. The script needs to clean old files and invoke SIGHUP... So I'd like to ask around, maybe it is acceptable to merge a poor-man's log rotation functionality to libosmocore after all? The patch needs some improvements (VTY configurability for starters), but so far goes something like this: static void _file_output(struct log_target *target, unsigned int level, const char *log) { - fprintf(target->tgt_file.out, "%s", log); - fflush(target->tgt_file.out); + int n; + + if (target->tgt_file.out) { + + n = fprintf(target->tgt_file.out, "%s", log); + fflush(target->tgt_file.out); +#ifdef stderr + /* don't try try to roll stderr */ + if (target->tgt_file.out != stderr) +#endif + { + if (n > 0) { + target->tgt_file.written_count += n; + + if (target->tgt_file.roll_count != 0 && + target->tgt_file.written_count > target->tgt_file.roll_count) { + + /* Create filename */ + char rotname[strlen(target->tgt_file.fname) + 3]; + + strcpy(rotname, target->tgt_file.fname); + strcat(rotname, ".1"); + + /* Rename the current log, then reopen the log to start new file */ + rename(target->tgt_file.fname, rotname); + log_target_file_reopen(target); + } + } + } + } } Note, this follows a simplistic approach to removing old log files: there is always exactly one rotated-away file, 'mylogfile.1', which gets overwritten in each rotation. Any rotation features more elaborate than this should better be solved with logrotate, but would everyone accept this kind of patch merged to libosmocore? Thanks, ~N

7 years, 6 months

Missing dependency libosmo-mgcp0 when installing osmo-mgw

by Bruckner Jan (ETAS-SEC/ECT-Mu)

Hi all, When trying to install the osmo-mgw package from the Latest repository, the package cannot be installed because the dependency libosmo-mgcp0 is not found. The message is: "osmo-mgw : Depends: libosmo-mgcp0 but it is not installable" I'm using the Debian 9 repository and my OS is Debian 9.4. Looking into the dependencies, I see that osmo-mgw depends on both libosmo-mgcp0 and libosmo-mgcp1. Are both of these actually necessary or should the libosmo-mgcp0 dependency be removed? Installing the libosmo-legacy-mgcp0 package does not help either. Thanks, Jan

7 years, 6 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC April 2018