November 2015 - OpenBSC - lists.osmocom.org

[PATCH] gtphub: add to debian build
by Neels Hofmeyr 14 Dec '15

14 Dec '15

By the example of osmo-sgsn, package osmo-gtphub for debian. Sponsored-by: On-Waves ehi --- debian/control | 14 +++ debian/osmocom-gtphub.default | 2 + debian/osmocom-gtphub.examples | 1 + debian/osmocom-gtphub.init | 150 +++++++++++++++++++++++ debian/osmocom-gtphub.install | 1 + debian/rules | 1 + openbsc/doc/examples/osmo-gtphub/osmo-gtphub.cfg | 23 ++++ 7 files changed, 192 insertions(+) create mode 100644 debian/osmocom-gtphub.default create mode 100644 debian/osmocom-gtphub.examples create mode 100755 debian/osmocom-gtphub.init create mode 100644 debian/osmocom-gtphub.install create mode 100644 openbsc/doc/examples/osmo-gtphub/osmo-gtphub.cfg diff --git a/debian/control b/debian/control index 2447d29..53b6908 100644 --- a/debian/control +++ b/debian/control @@ -50,6 +50,12 @@ Depends: ${shlibs:Depends}, ${misc:Depends} Description: Osmocom Base Station Controller Network Address Translation Network address translation for BSC. +Package: osmocom-gtphub +Architecture: any +Depends: ${shlibs:Depends}, ${misc:Depends} +Description: Osmocom GTP hub + Proxy for comms between SGSN and GGSN. + Package: osmocom-bsc-dbg Architecture: any Section: debug @@ -105,3 +111,11 @@ Priority: extra Depends: osmocom-bsc-nat (= ${binary:Version}), ${misc:Depends} Description: Debug symbols for the OpenBSC Network Address Translation Make debugging possible + +Package: osmocom-gtphub-dbg +Architecture: any +Section: debug +Priority: extra +Depends: osmocom-gtphub (= ${binary:Version}), ${misc:Depends} +Description: Debug symbols for Osmocom GTP hub + Make debugging possible diff --git a/debian/osmocom-gtphub.default b/debian/osmocom-gtphub.default new file mode 100644 index 0000000..6af82da --- /dev/null +++ b/debian/osmocom-gtphub.default @@ -0,0 +1,2 @@ +CONFIG_FILE="/etc/osmocom/osmo-gtphub.cfg" + diff --git a/debian/osmocom-gtphub.examples b/debian/osmocom-gtphub.examples new file mode 100644 index 0000000..48c2dc0 --- /dev/null +++ b/debian/osmocom-gtphub.examples @@ -0,0 +1 @@ +openbsc/doc/examples/osmo-gtphub diff --git a/debian/osmocom-gtphub.init b/debian/osmocom-gtphub.init new file mode 100755 index 0000000..4dc67b3 --- /dev/null +++ b/debian/osmocom-gtphub.init @@ -0,0 +1,150 @@ +#!/bin/sh +### BEGIN INIT INFO +# Provides: osmo-gtphub +# Required-Start: $network $local_fs +# Required-Stop: +# Default-Start: 2 3 4 5 +# Default-Stop: 0 1 6 +# Short-Description: Osmocom GTP hub +# Description: Osmocom GTP hub +### END INIT INFO + +# Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> + +# PATH should only include /usr/* if it runs after the mountnfs.sh script +PATH=/sbin:/usr/sbin:/bin:/usr/bin +NAME=osmo-gtphub # Introduce the short server's name here +DESC="Osmocom GTP hub" # Introduce a short description here +DAEMON=/usr/bin/osmo-gtphub # Introduce the server's location here +SCRIPTNAME=/etc/init.d/osmocom-gtphub + +# Exit if the package is not installed +[ -x $DAEMON ] || exit 0 + +# Read configuration variable file if it is present +[ -r /etc/default/osmocom-gtphub ] && . /etc/default/osmocom-gtphub + +# Load the VERBOSE setting and other rcS variables +. /lib/init/vars.sh + +# Define LSB log_* functions. +# Depend on lsb-base (>= 3.0-6) to ensure that this file is present. +. /lib/lsb/init-functions + +DAEMON_ARGS="$DAEMON_ARGS -D -c $CONFIG_FILE" + +# +# Function that starts the daemon/service +# +do_start() +{ + # Return + # 0 if daemon has been started + # 1 if daemon was already running + # 2 if daemon could not be started + start-stop-daemon --start --quiet --exec $DAEMON --test > /dev/null \ + || return 1 + start-stop-daemon --start --quiet --exec $DAEMON -- \ + $DAEMON_ARGS \ + || return 2 + # Add code here, if necessary, that waits for the process to be ready + # to handle requests from services started subsequently which depend + # on this one. As a last resort, sleep for some time. +} + +# +# Function that stops the daemon/service +# +do_stop() +{ + # Return + # 0 if daemon has been stopped + # 1 if daemon was already stopped + # 2 if daemon could not be stopped + # other if a failure occurred + start-stop-daemon --stop --quiet --retry=TERM/30/KILL/5 --name $NAME + RETVAL="$?" + [ "$RETVAL" = 2 ] && return 2 + # Wait for children to finish too if this is a daemon that forks + # and if the daemon is only ever run from this initscript. + # If the above conditions are not satisfied then add some other code + # that waits for the process to drop all resources that could be + # needed by services started subsequently. A last resort is to + # sleep for some time. + start-stop-daemon --stop --quiet --oknodo --retry=0/30/KILL/5 --exec $DAEMON + [ "$?" = 2 ] && return 2 + return "$RETVAL" +} + +# +# Function that sends a SIGHUP to the daemon/service +# +do_reload() { + # + # If the daemon can reload its configuration without + # restarting (for example, when it is sent a SIGHUP), + # then implement that here. + # + start-stop-daemon --stop --signal 1 --quiet $PIDFILE --name $NAME + return 0 +} + +case "$1" in + start) + [ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC " "$NAME" + do_start + case "$?" in + 0|1) [ "$VERBOSE" != no ] && log_end_msg 0 ;; + 2) [ "$VERBOSE" != no ] && log_end_msg 1 ;; + esac + ;; + stop) + [ "$VERBOSE" != no ] && log_daemon_msg "Stopping $DESC" "$NAME" + do_stop + case "$?" in + 0|1) [ "$VERBOSE" != no ] && log_end_msg 0 ;; + 2) [ "$VERBOSE" != no ] && log_end_msg 1 ;; + esac + ;; + status) + status_of_proc "$DAEMON" "$NAME" && exit 0 || exit $? + ;; + #reload|force-reload) + # + # If do_reload() is not implemented then leave this commented out + # and leave 'force-reload' as an alias for 'restart'. + # + #log_daemon_msg "Reloading $DESC" "$NAME" + #do_reload + #log_end_msg $? + #;; + restart|force-reload) + # + # If the "reload" option is implemented then remove the + # 'force-reload' alias + # + log_daemon_msg "Restarting $DESC" "$NAME" + do_stop + case "$?" in + 0|1) + do_start + case "$?" in + 0) log_end_msg 0 ;; + 1) log_end_msg 1 ;; # Old process is still running + *) log_end_msg 1 ;; # Failed to start + esac + ;; + *) + # Failed to stop + log_end_msg 1 + ;; + esac + ;; + *) + #echo "Usage: $SCRIPTNAME {start|stop|restart|reload|force-reload}" >&2 + echo "Usage: $SCRIPTNAME {start|stop|status|restart|force-reload}" >&2 + exit 3 + ;; +esac + +: diff --git a/debian/osmocom-gtphub.install b/debian/osmocom-gtphub.install new file mode 100644 index 0000000..908c1a5 --- /dev/null +++ b/debian/osmocom-gtphub.install @@ -0,0 +1 @@ +/usr/bin/osmo-gtphub diff --git a/debian/rules b/debian/rules index 8047b79..62518d9 100755 --- a/debian/rules +++ b/debian/rules @@ -34,6 +34,7 @@ override_dh_strip: dh_strip -posmocom-sgsn --dbg-package=osmocom-sgsn-dbg dh_strip -posmocom-gbproxy --dbg-package=osmocom-gbproxy-dbg dh_strip -posmocom-bsc-nat --dbg-package=osmocom-bsc-nat-dbg + dh_strip -posmocom-gtphub --dbg-package=osmocom-gtphub-dbg override_dh_auto_configure: echo $(VERSION) > openbsc/.tarball-version diff --git a/openbsc/doc/examples/osmo-gtphub/osmo-gtphub.cfg b/openbsc/doc/examples/osmo-gtphub/osmo-gtphub.cfg new file mode 100644 index 0000000..c9bb4cf --- /dev/null +++ b/openbsc/doc/examples/osmo-gtphub/osmo-gtphub.cfg @@ -0,0 +1,23 @@ +! +! Osmocom gtphub configuration +! + +line vty + no login + +gtphub + ! Local addresses to listen on and send from, each on standard ports + ! 2123 and 2152. Setting these addresses is mandatory. + bind-to-sgsns 127.0.0.1 + bind-to-ggsns 127.0.0.2 + + ! Local nonstandard ports or separate IPs: + !bind-to-sgsns ctrl 127.0.0.1 2342 user 127.0.0.1 4223 + + ! Proxy: unconditionally direct all traffic to... + !ggsn-proxy 127.0.0.3 + !sgsn-proxy 127.0.0.4 + + ! Proxy with nonstandard ports or separate IPs: + !ggsn-proxy ctrl 127.0.0.3 2123 user 127.0.0.5 2152 + -- 2.1.4

2 7

[PATCH 1/3] mncc: Implement helper functions to convert MNCC cause to a string.
by Alexander Chemeris 13 Dec '15

13 Dec '15

--- openbsc/include/openbsc/mncc.h | 5 +- openbsc/src/libmsc/mncc.c | 103 ++++++++++++++++++++++++++++++++++++++--- 2 files changed, 100 insertions(+), 8 deletions(-) diff --git a/openbsc/include/openbsc/mncc.h b/openbsc/include/openbsc/mncc.h index 46ba237..92389c2 100644 --- a/openbsc/include/openbsc/mncc.h +++ b/openbsc/include/openbsc/mncc.h @@ -191,8 +191,11 @@ struct gsm_mncc_rtp { uint32_t payload_msg_type; }; -char *get_mncc_name(int value); +const char *get_mncc_name(int value); void mncc_set_cause(struct gsm_mncc *data, int loc, int val); +int mncc_has_cause(struct gsm_mncc *data); +const char *get_mncc_location(int value); +const char *get_mncc_cause(int value); void cc_tx_to_mncc(struct gsm_network *net, struct msgb *msg); /* input from CC code into mncc_builtin */ diff --git a/openbsc/src/libmsc/mncc.c b/openbsc/src/libmsc/mncc.c index 2767faa..e8bd9ba 100644 --- a/openbsc/src/libmsc/mncc.c +++ b/openbsc/src/libmsc/mncc.c @@ -34,10 +34,12 @@ #include <openbsc/transaction.h> #include <openbsc/rtp_proxy.h> -static struct mncc_names { +struct name_value { char *name; int value; -} mncc_names[] = { +}; + +static struct name_value mncc_names[] = { {"MNCC_SETUP_REQ", 0x0101}, {"MNCC_SETUP_IND", 0x0102}, {"MNCC_SETUP_RSP", 0x0103}, @@ -95,16 +97,103 @@ static struct mncc_names { {NULL, 0} }; -char *get_mncc_name(int value) +static struct name_value mncc_locations[] = { + {"GSM48_CAUSE_LOC_USER", 0x00}, + {"GSM48_CAUSE_LOC_PRN_S_LU", 0x01}, + {"GSM48_CAUSE_LOC_PUN_S_LU", 0x02}, + {"GSM48_CAUSE_LOC_TRANS_NET", 0x03}, + {"GSM48_CAUSE_LOC_PUN_S_RU", 0x04}, + {"GSM48_CAUSE_LOC_PRN_S_RU", 0x05}, + /* not defined */ + {"GSM48_CAUSE_LOC_INN_NET", 0x07}, + {"GSM48_CAUSE_LOC_NET_BEYOND", 0x0a}, + + {NULL, 0} }; + +static struct name_value mncc_causes[] = { + {"GSM48_CC_CAUSE_UNASSIGNED_NR", 1}, + {"GSM48_CC_CAUSE_NO_ROUTE", 3}, + {"GSM48_CC_CAUSE_CHAN_UNACCEPT", 6}, + {"GSM48_CC_CAUSE_OP_DET_BARRING", 8}, + {"GSM48_CC_CAUSE_NORM_CALL_CLEAR", 16}, + {"GSM48_CC_CAUSE_USER_BUSY", 17}, + {"GSM48_CC_CAUSE_USER_NOTRESPOND", 18}, + {"GSM48_CC_CAUSE_USER_ALERTING_NA", 19}, + {"GSM48_CC_CAUSE_CALL_REJECTED", 21}, + {"GSM48_CC_CAUSE_NUMBER_CHANGED", 22}, + {"GSM48_CC_CAUSE_PRE_EMPTION", 25}, + {"GSM48_CC_CAUSE_NONSE_USER_CLR", 26}, + {"GSM48_CC_CAUSE_DEST_OOO", 27}, + {"GSM48_CC_CAUSE_INV_NR_FORMAT", 28}, + {"GSM48_CC_CAUSE_FACILITY_REJ", 29}, + {"GSM48_CC_CAUSE_RESP_STATUS_INQ", 30}, + {"GSM48_CC_CAUSE_NORMAL_UNSPEC", 31}, + {"GSM48_CC_CAUSE_NO_CIRCUIT_CHAN", 34}, + {"GSM48_CC_CAUSE_NETWORK_OOO", 38}, + {"GSM48_CC_CAUSE_TEMP_FAILURE", 41}, + {"GSM48_CC_CAUSE_SWITCH_CONG", 42}, + {"GSM48_CC_CAUSE_ACC_INF_DISCARD", 43}, + {"GSM48_CC_CAUSE_REQ_CHAN_UNAVAIL", 44}, + {"GSM48_CC_CAUSE_RESOURCE_UNAVAIL", 47}, + {"GSM48_CC_CAUSE_QOS_UNAVAIL", 49}, + {"GSM48_CC_CAUSE_REQ_FAC_NOT_SUBSC", 50}, + {"GSM48_CC_CAUSE_INC_BARRED_CUG", 55}, + {"GSM48_CC_CAUSE_BEARER_CAP_UNAUTH", 57}, + {"GSM48_CC_CAUSE_BEARER_CA_UNAVAIL", 58}, + {"GSM48_CC_CAUSE_SERV_OPT_UNAVAIL", 63}, + {"GSM48_CC_CAUSE_BEARERSERV_UNIMPL", 65}, + {"GSM48_CC_CAUSE_ACM_GE_ACM_MAX", 68}, + {"GSM48_CC_CAUSE_REQ_FAC_NOTIMPL", 69}, + {"GSM48_CC_CAUSE_RESTR_BCAP_AVAIL", 70}, + {"GSM48_CC_CAUSE_SERV_OPT_UNIMPL", 79}, + {"GSM48_CC_CAUSE_INVAL_TRANS_ID", 81}, + {"GSM48_CC_CAUSE_USER_NOT_IN_CUG", 87}, + {"GSM48_CC_CAUSE_INCOMPAT_DEST", 88}, + {"GSM48_CC_CAUSE_INVAL_TRANS_NET", 91}, + {"GSM48_CC_CAUSE_SEMANTIC_INCORR", 95}, + {"GSM48_CC_CAUSE_INVAL_MAND_INF", 96}, + {"GSM48_CC_CAUSE_MSGTYPE_NOTEXIST", 97}, + {"GSM48_CC_CAUSE_MSGTYPE_INCOMPAT", 98}, + {"GSM48_CC_CAUSE_IE_NOTEXIST", 99}, + {"GSM48_CC_CAUSE_COND_IE_ERR", 100}, + {"GSM48_CC_CAUSE_MSG_INCOMP_STATE", 101}, + {"GSM48_CC_CAUSE_RECOVERY_TIMER", 102}, + {"GSM48_CC_CAUSE_PROTO_ERR", 111}, + {"GSM48_CC_CAUSE_INTERWORKING", 127}, + + {NULL, 0} }; + +const char *get_name_by_value(struct name_value *pairs, int value, const char *default_val) { int i; - for (i = 0; mncc_names[i].name; i++) { - if (mncc_names[i].value == value) - return mncc_names[i].name; + for (i = 0; pairs[i].name; i++) { + if (pairs[i].value == value) + return pairs[i].name; } - return "MNCC_Unknown"; + return default_val; +} + + +const char *get_mncc_name(int value) +{ + return get_name_by_value(mncc_names, value, "MNCC_Unknown"); +} + +const char *get_mncc_location(int value) +{ + return get_name_by_value(mncc_locations, value, "GSM48_CAUSE_LOC_Unknown"); +} + +const char *get_mncc_cause(int value) +{ + return get_name_by_value(mncc_causes, value, "GSM48_CC_CAUSE_Unknown"); +} + +int mncc_has_cause(struct gsm_mncc *data) +{ + return data->fields & MNCC_F_CAUSE; } void mncc_set_cause(struct gsm_mncc *data, int loc, int val) -- 1.9.1

3 6

OpenBSC compile error --> tests --> GTP hub
by Sipos Csaba 03 Dec '15

03 Dec '15

Dear Neels, Today just grabbed the latest OpenBSC master, and got this compile error: Making all in gtphub make[3]: Entering directory `/root/new_osmocom/openbsc/openbsc/tests/gtphub' CC gtphub_test.o CC ../../src/gprs/gtphub.o ../../src/gprs/gtphub.c:2191:1: fatal error: opening dependency file .deps/../../src/gprs/gtphub.Tpo: No such file or directory } ^ compilation terminated. make[3]: *** [../../src/gprs/gtphub.o] Error 1 make[3]: Leaving directory `/root/new_osmocom/openbsc/openbsc/tests/gtphub' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/root/new_osmocom/openbsc/openbsc/tests' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/root/new_osmocom/openbsc/openbsc' make: *** [all] Error 2 Do you have any idea why is this happening? Regards, Csaba

3 4

[PATCH 1/3] gtphub: lose obsolete comment.
by Neels Hofmeyr 30 Nov '15

30 Nov '15

The del_cb is now also used for ares (GGSN resolution) timeouts, and expiry is anyway separated from nr_map, so this comment is void. Sponsored-by: On-Waves ehi --- openbsc/include/openbsc/gtphub.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/openbsc/include/openbsc/gtphub.h b/openbsc/include/openbsc/gtphub.h index 49d685c..68cf90e 100644 --- a/openbsc/include/openbsc/gtphub.h +++ b/openbsc/include/openbsc/gtphub.h @@ -248,8 +248,6 @@ int expiry_tick(struct expiry *exq, time_t now); * Mapping allocation and a del_cb are provided by the caller. If del_cb is * NULL, no deallocation will be done (allowing statically allocated entries). */ -/* TODO at some point I thought the allocation & del_cb complexity was - * needed/helpful, but by now it seems like overkill. Maybe lose that again. */ typedef int nr_t; -- 2.1.4

3 10

Meas_web and meas_json
by Sipos Csaba 30 Nov '15

30 Nov '15

Hi Alexander, Just wanted to thank you for the web version of meas_vis utility, and wanted to confirm that it works very well with Nokia Site family (E1 based) and the USRP B200 too :-) If someone missed it, the web version can be found here: https://github.com/fairwaves/meas_web It would make life easier if the meas_json utility would make it to the master branch: http://cgit.osmocom.org/openbsc/log/?h=achemeris/meas_json Is there a reason it is not being merged? Regards, Csaba

3 8

<0004> abis_rsl.c:1423 BTS 0 CHAN RQD: no resources for SDCCH 0xf
by Sipos Csaba 29 Nov '15

29 Nov '15

Dear List, I am in the process of further updating the following Wiki article: The goal is to have a clean, up to date manual which tells in detail how to set up OpenBSC. In the light of recent changes I decided to change this already working setup to use the "master" branches of every involved Osmocom project. It is finally possible to compile and run every project after the proper dependencies are met. But some new problem popped up I haven't seen before. After everything is started up (OpenBSC, GGSN, SGSN, LCR, TRX, and PCU), when a phone tries to RACH, this is what I get in the BSC log: Sat Nov 28 14:09:08 2015 <0004> abis_rsl.c:1423 BTS 0 CHAN RQD: no resources for SDCCH 0xf Sat Nov 28 14:09:19 2015 <0004> abis_rsl.c:1423 BTS 0 CHAN RQD: no resources for SDCCH 0x6 Sat Nov 28 14:09:30 2015 <0004> abis_rsl.c:1423 BTS 0 CHAN RQD: no resources for SDCCH 0x6 On the BTS side, this is what I get: <0006> scheduler.c:1186 Received Access Burst on RACH fn=9868 toa=5.88 <0006> scheduler.c:1192 Received bad AB frame at fn=9868 (25/51) <0006> scheduler.c:1186 Received Access Burst on RACH fn=52459 toa=-1.50 <0006> scheduler.c:1192 Received bad AB frame at fn=52459 (31/51) <0006> scheduler.c:1186 Received Access Burst on RACH fn=67956 toa=-0.06 <0006> scheduler.c:1192 Received bad AB frame at fn=67956 (24/51) Because I used exactly the same config files I used before when it all worked, I analyzed the logs a littlebit more. In the BTS log, during the OML setup this is what I found: <0001> oml.c:802 ADM state already was Unlocked <0001> oml.c:256 OC=BASEBAND-TRANSCEIVER INST=(00,00,ff) OPER STATE NULL -> Enabled <0001> oml.c:217 OC=BASEBAND-TRANSCEIVER INST=(00,00,ff) Tx STATE CHG REP <000b> trx_if.c:366 Response message 'RSP ERR 1' does not match command message 'CMD SETBSIC 62' !!!!!! <0001> oml.c:1059 Rx IPA RSL CONNECT IP=127.0.0.1 PORT=3003 STREAM=0x00 <0011> input/ipa.c:129 connection done. <0011> input/ipaccess.c:693 received ID get <0000> rsl.c:279 Tx RSL RF RESource INDication Maybe the recent changes in the BSIC/TSC handling part is causing this? Anyway it seems that the BSIC I set in the BSC is the correct one the BTS tries to configure during the timeslot, transceiver and BTS setup. I attached the corresponding OML trace, and the logs. If someone has any ideas, please let me know. Regards, Csaba

2 3

[PATCH 1/8] debug: Add DSS category for supplementary service
by Sergey.Kostanbaev 29 Nov '15

29 Nov '15

From: Sergey Kostanbaev <sergey.kostanbaev(a)gmail.com> This series of patches add support for external USSD processing via simplified MAP-like protocol over SUP socket. As an example of a such external application simple USSD to SIP proxy is provided (it targets TS 124 390) --- openbsc/include/openbsc/debug.h | 1 + openbsc/src/libcommon/debug.c | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/openbsc/include/openbsc/debug.h b/openbsc/include/openbsc/debug.h index 19d8fc2..10b0f46 100644 --- a/openbsc/include/openbsc/debug.h +++ b/openbsc/include/openbsc/debug.h @@ -33,6 +33,7 @@ enum { DCTRL, DSMPP, DFILTER, + DSS, Debug_LastEntry, }; diff --git a/openbsc/src/libcommon/debug.c b/openbsc/src/libcommon/debug.c index 7fb3ecb..6536944 100644 --- a/openbsc/src/libcommon/debug.c +++ b/openbsc/src/libcommon/debug.c @@ -165,6 +165,12 @@ static const struct log_info_cat default_categories[] = { .description = "BSC/NAT IMSI based filtering", .enabled = 1, .loglevel = LOGL_DEBUG, }, + [DSS] = { + .name = "DSS", + .description = "Layer3 Supplementary Service (SS)", + .color = "\033[0;33m", + .enabled = 1, .loglevel = LOGL_DEBUG, + }, }; enum log_filter { -- 1.9.1

5 17

[PATCH 1/3] mncc: Implement helper functions to convert MNCC cause to a string.
by Alexander Chemeris 25 Nov '15

25 Nov '15

This is the first patch of the series. The first two patches are improvements of the log output and are independent of the 3rd patch in terms of code - proposed logging improvements just make it easier to debug issues with MNCC cause codes. The code is also a part of the achemeris/mncc_cause_fixes_master branch. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

2 3

[PATCH 1/4] core: RELEASE COMPLETE can be without any payload
by Sergey.Kostanbaev 25 Nov '15

25 Nov '15

From: Sergey Kostanbaev <Sergey.Kostanbaev(a)gmail.com> This series of patches supposed to add support of USSD-menu style message handling with language support. --- src/gsm/gsm0480.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c index 952604b..9bd54fa 100644 --- a/src/gsm/gsm0480.c +++ b/src/gsm/gsm0480.c @@ -248,12 +248,6 @@ int gsm0480_decode_ss_request(const struct gsm48_hdr *hdr, uint16_t len, struct ss_request *req) { int rc = 0; - - if (len < sizeof(*hdr) + 2) { - LOGP(0, LOGL_DEBUG, "SS Request is too short.\n"); - return 0; - } - if ((hdr->proto_discr & 0x0f) == GSM48_PDISC_NC_SS) { req->transaction_id = hdr->proto_discr & 0x70; rc = parse_ss(hdr, len, req); -- 1.9.1

1 3

[PATCH 3/3] mncc: Send "Dest OOO" cause in case of a link radio failure.
by Alexander Chemeris 24 Nov '15

24 Nov '15

Previously we were sending a generic "Resource unavailable" cause code making it impossible to distinguish real error cases from a regular radio link failure. This was the reason for many "unknown" call errors we've seen at Rhizomatica installations. Now they are properly classified as non-erroneous call failures. The code is also a part of the achemeris/mncc_cause_fixes_master branch. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. https://fairwaves.co

1 2