OpenBSC November 2011

openbsc@lists.osmocom.org

21 participants
25 discussions

Re: new timer code: semantics of osmo_timer_schedule for already scheduled timer
by Sylvain Munaut 13 Nov '11

13 Nov '11

Hi, >> Yes, this scenario is strange, but I think we try to cover all possible >> situations. So I think my patch should be applied instead. > > Will the two of you please figure out what is the best option to > proceed? Revert one of Sylvains patches and apply Pablos patch? I applied Pablo's patch this morning after testing it worked as well. Cheers, Sylvain

1 0

[PATCH] tests: timer: add parameter to select the number of steps
by Pablo Neira Ayuso 13 Nov '11

13 Nov '11

Holger likes having a parameter to set the number of steps in this test. Now you can set it via `-s' option. Signed-off-by: Pablo Neira Ayuso <pablo(a)gnumonks.org> --- tests/timer/timer_test.c | 25 ++++++++++++++++++++++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/tests/timer/timer_test.c b/tests/timer/timer_test.c index bcaafdb..a01a9e5 100644 --- a/tests/timer/timer_test.c +++ b/tests/timer/timer_test.c @@ -24,6 +24,7 @@ #include <stdio.h> #include <stdlib.h> +#include <getopt.h> #include <osmocom/core/talloc.h> #include <osmocom/core/timer.h> @@ -60,6 +61,7 @@ struct test_timer { #define TIMER_PRES_SECS 0 #define TIMER_PRES_USECS 10000 +static int timer_nsteps = MAIN_TIMER_NSTEPS; static unsigned int expired_timers = 0; static unsigned int total_timers = 0; static unsigned int too_late = 0; @@ -70,7 +72,7 @@ static void main_timer_fired(void *data) unsigned int add_in_this_step; int i; - if (*step == MAIN_TIMER_NSTEPS) { + if (*step == timer_nsteps) { printf("Main timer has finished, please, wait a bit for the " "final report.\n"); return; @@ -134,11 +136,28 @@ static void secondary_timer_fired(void *data) } } -int main(int argc, char** argv) +int main(int argc, char *argv[]) { + int c; + + while ((c = getopt_long(argc, argv, "s:", NULL, NULL)) != -1) { + switch(c) { + case 's': + timer_nsteps = atoi(optarg); + if (timer_nsteps <= 0) { + fprintf(stderr, "%s: steps must be > 0\n", + argv[0]); + exit(EXIT_FAILURE); + } + break; + default: + exit(EXIT_FAILURE); + } + } + printf("Running timer test for %u steps, accepting imprecision " "of %u.%.6u seconds\n", - MAIN_TIMER_NSTEPS, TIMER_PRES_SECS, TIMER_PRES_USECS); + timer_nsteps, TIMER_PRES_SECS, TIMER_PRES_USECS); osmo_timer_schedule(&main_timer, 1, 0); -- 1.7.2.5 --k1lZvvs/B4yU6o8G--

1 0

[PATCH] timer: fix active timer re-scheduling situation
by Pablo Neira Ayuso 12 Nov '11

12 Nov '11

This patch re-adds support the timer re-scheduling situation which used to be supported until I introduced the rb-tree based timer. Signed-off-by: Pablo Neira Ayuso <pablo(a)gnumonks.org> --- src/timer.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/timer.c b/src/timer.c index 6852983..e68040f 100644 --- a/src/timer.c +++ b/src/timer.c @@ -68,6 +68,7 @@ static void __add_timer(struct osmo_timer_list *timer) */ void osmo_timer_add(struct osmo_timer_list *timer) { + osmo_timer_del(timer); timer->active = 1; INIT_LLIST_HEAD(&timer->list); __add_timer(timer); -- 1.7.2.5 --FCuugMFkClbJLl1L--

1 0

LCR + Asterisk + NanoBTS: Strange Voice Behaviour "Dropping incompatible voice frame on lcr/1"
by Luca Bongiorni 08 Nov '11

08 Nov '11

Hi all, i compiled and configured all (mISDN, lcr, asterisk, etc...), unfortunately, when i try to place a call from the softphone to the MS, i can ear only the voice originated from the laptop to the MS and not viceversa. I'm using it on an Ubuntu 10.4, Asterisk 1.6.2.5 and the others sources from "last git". Configurations: - extension.conf: http://pastebin.com/mHH46HbQ - sip.conf: http://pastebin.com/SkPN3z6q - gsm.conf: http://pastebin.com/C1Eckdgh - interface.conf: http://pastebin.com/ctGapa1F - options.conf: http://pastebin.com/6xhgL0P1 - routing.conf: http://pastebin.com/TVNvwTEB Logs: - osmo-nitb's log: http://pastebin.com/X10B5NjE - lcr's log: http://pastebin.com/uLY9VAiB - Asterisk's log: http://pastebin.com/8qzw6aMn As you can see from Asterisk, there is a mismatch: "NOTICE[2315]: channel.c:2960 __ast_read: Dropping incompatible voice frame on lcr/1 of format alaw since our native format has changed to 0x0 (nothing) " I tried to set alaw / ulaw on the configurations, to change efr, fr and amr, but it didn't change nothing. Ideas or hints for further investigations are welcome. Regards, Luca

4 6

[RFC] MNCC introduce a hello packet to include a version number
by Holger Hans Peter Freyther 01 Nov '11

01 Nov '11

Hi Jolly, all, I spent some time figuring out why LCR and OpenBSC wouldn't want to work with each other. The reason was the addition of an element to the MNCC structure. I propose to send a hello packet down the MNCC socket and leave it to the client to decide if the version is acceptable. I will need to move the mncc header to libosmocore as osmocomBB is currently using a copy of the OpenBSC header. comments holger

2 2

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC November 2011