OpenBSC November 2009

openbsc@lists.osmocom.org

18 participants
54 discussions

patch: subscriber usage debug
by Andreas.Eversberg 17 Nov '09

17 Nov '09

this patch will give more detailed debug information about subscriber usage. when subcriber structure is allocated, it will be shown on debug output. subscr_get() and subscr_put() debug will also show the calling function for better understanding. diff --git a/openbsc/include/openbsc/gsm_subscriber.h b/openbsc/include/openbsc/gsm_subscriber.h index d612ed5..02e193a 100644 --- a/openbsc/include/openbsc/gsm_subscriber.h +++ b/openbsc/include/openbsc/gsm_subscriber.h @@ -71,8 +71,10 @@ enum gsm_subscriber_update_reason { GSM_SUBSCRIBER_UPDATE_EQUIPMENT, }; -struct gsm_subscriber *subscr_get(struct gsm_subscriber *subscr); -struct gsm_subscriber *subscr_put(struct gsm_subscriber *subscr); +#define subscr_get(subscr) _subscr_get(__FUNCTION__, subscr) +struct gsm_subscriber *_subscr_get(const char *func, struct gsm_subscriber *subscr); +#define subscr_put(subscr) _subscr_put(__FUNCTION__, subscr) +struct gsm_subscriber *_subscr_put(const char *func, struct gsm_subscriber *subscr); struct gsm_subscriber *subscr_get_by_tmsi(struct gsm_network *net, u_int32_t tmsi); struct gsm_subscriber *subscr_get_by_imsi(struct gsm_network *net, @@ -87,7 +89,8 @@ void subscr_get_channel(struct gsm_subscriber *subscr, int type, gsm_cbfn *cbfn, void *param); /* internal */ -struct gsm_subscriber *subscr_alloc(void); +#define subscr_alloc() _subscr_alloc(__FUNCTION__) +struct gsm_subscriber *_subscr_alloc(const char *func); extern struct llist_head active_subscribers; #endif /* _GSM_SUBSCR_H */ diff --git a/openbsc/src/gsm_subscriber_base.c b/openbsc/src/gsm_subscriber_base.c index bcf55d1..7fe2f21 100644 --- a/openbsc/src/gsm_subscriber_base.c +++ b/openbsc/src/gsm_subscriber_base.c @@ -113,7 +113,7 @@ static void subscr_send_paging_request(struct gsm_subscriber *subscr) } } -struct gsm_subscriber *subscr_alloc(void) +struct gsm_subscriber *_subscr_alloc(const char *func) { struct gsm_subscriber *s; @@ -123,6 +123,8 @@ struct gsm_subscriber *subscr_alloc(void) memset(s, 0, sizeof(*s)); llist_add_tail(&s->entry, &active_subscribers); + DEBUGP(DCC, "(from %s) new subscr allocated, setting usage to: 1\n", + func); s->use_count = 1; s->tmsi = GSM_RESERVED_TMSI; @@ -137,19 +139,19 @@ static void subscr_free(struct gsm_subscriber *subscr) talloc_free(subscr); } -struct gsm_subscriber *subscr_get(struct gsm_subscriber *subscr) +struct gsm_subscriber *_subscr_get(const char *func, struct gsm_subscriber *subscr) { subscr->use_count++; - DEBUGP(DCC, "subscr %s usage increases usage to: %d\n", - subscr->extension, subscr->use_count); + DEBUGP(DCC, "(from %s) subscr %s usage increases usage to: %d\n", + func, subscr->extension, subscr->use_count); return subscr; } -struct gsm_subscriber *subscr_put(struct gsm_subscriber *subscr) +struct gsm_subscriber *_subscr_put(const char *func, struct gsm_subscriber *subscr) { subscr->use_count--; - DEBUGP(DCC, "subscr %s usage decreased usage to: %d\n", - subscr->extension, subscr->use_count); + DEBUGP(DCC, "(from %s) subscr %s usage decreased usage to: %d\n", + func, subscr->extension, subscr->use_count); if (subscr->use_count <= 0) subscr_free(subscr); return NULL;

2 1

AW: patch: fix of compiler warnings
by Andreas.Eversberg 17 Nov '09

17 Nov '09

there is an error in this patch: + if (found < 0) { this is correct: + if (!found) {

1 0

GPRS branch status update
by Harald Welte 16 Nov '09

16 Nov '09

Hi! I've applied a series of fixes and extensions to the GPRS branch, and would like to invited interested nanoBTS users to give it another try. Right now, I am getting fully through GPRS routing area update and attach request, i.e. the phones can fully register to the GPRS network. Minimal PDP context activation and deactivation has been implemented, i.e. the phone will send a ACTIVATE PDP CONTEXT REQUEST, and the network will simply ACK it. However, since the network does not add any IPCP options, the phone will typically DEACTIVATE the context immediately after that. Have fun, -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

3 3

Unable to compile because of missing dbi/dbi.h
by ನಾಗೇಶ್ 14 Nov '09

14 Nov '09

Hi, I am trying to compile the source code but, I am stuck with the dbi.h header file. Where can I get this include file so that I can successfully compile ? N.

3 2

nanoBTS transmit power
by Bjoern Heller 14 Nov '09

14 Nov '09

Hi, how do I configure the nanoBTS transmit power? regards Björn - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Björn Heller Jabber: tec(a)jabber.hellercom.de

2 1

Unable to do menuconfig.
by ನಾಗೇಶ್ 13 Nov '09

13 Nov '09

Hi, I am following instruction from this page : http://openbsc.gnumonks.org/trac/wiki/Debian_Getting_Started When I do make menuconfig I get to the point until I have to select the mISDN modules. Firstly, I had to download the 2.6.31.6 kernel which is different as described in the page above. And, secondly, when I do select (based on the best 'guess'), there is no change at all ! I am forced to select 'Exit' - it does not proceed further. Is there anything you would like to suggest ? I am running minimal Ubuntu Linux (https://help.ubuntu.com/community/Installation/MinimalCD) as a guest OS using VirtualBox hosted on Ubuntu 9.10. N.

1 0

Testing an OpenBSC installation.
by ನಾಗೇಶ್ 12 Nov '09

12 Nov '09

Hi, Your tutorial on getting started with Debian system is good. Once the installation is over, what tests would you suggest to know the system is ok ? Similarly, how would one ensure that the machine running OpenBSC is talking nice with the BTS ? N

2 1

[Fwd: Testing an OpenBSC installation.]
by ನಾಗೇಶ್ 12 Nov '09

12 Nov '09

Never mind, I think, I found it. http://bs11-abis.gnumonks.org/trac/wiki/BS11_Getting_Started Thanks ! -------- Forwarded Message -------- From: ನಾಗೇಶ್ <openbscuser(a)gmail.com> Reply-to: openbscuser(a)gmail.com To: openbsc <openbsc(a)lists.gnumonks.org> Subject: Testing an OpenBSC installation. Date: Thu, 12 Nov 2009 23:24:32 +0530 Hi, Your tutorial on getting started with Debian system is good. Once the installation is over, what tests would you suggest to know the system is ok ? Similarly, how would one ensure that the machine running OpenBSC is talking nice with the BTS ? N

1 0

RFC: Establishing logging standards
by Holger Freyther 11 Nov '09

11 Nov '09

Hey, I think in the next days I will go around the sourcecode and change a couple of logging messages. My two primary goals are increase the usefulness to figure out what was going wrong and the second to be able to put some of these into the syslog. Should we use DEBUG* to also log to syslog or introduce a new set of macros? Log Levels: I think Harald has expressed the wish to introduce log levels. Should we follow the log levels of syslog(3)? Messages: I would like to collect formats for various actions. Currently I'm thinking of the following but would like to have more input. subscriber: When talking about a subscriber use TMSI, IMSI and Extension. lchan: Include refcount, channel type, link_id, subscriber sccp: Talk about SCCP source local reference and pointer transaction: Print the transaction? gsm0408: Print the lchan which prints the subscriber? comments? holger

3 8

[PATCH] implemented GSM340_TP_VPF_ABSOLUTE
by Steffen 'stefreak' Neubauer 11 Nov '09

11 Nov '09

From: Steffen Neubauer <stefreak(a)stefreak.de> - Added function "gsm340_scts" to decode the service center time stamp into a UTC/GMT timestamp - in function gsm340_validity_period: can now decode validity period format absolute. I hope it's good ;) Greetings, Steffen

2 4

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC November 2009