Small patch to fix building librtlsdr on OpenBSD - osmocom-sdr - lists.osmocom.org

List overview All Threads
Download

Small patch to fix building librtlsdr on OpenBSD

[PATCH] build gr-iqbal w/ clang

Re: Small patch to fix building...

Brian Waters

5 Nov 2019 5 Nov '19

5:05 p.m.

Gets rid of librt, which doesn't exist on OpenBSD. The version of librtlsdr in the OpenBSD ports tree is extremely old (~2013), so this should help some users. Tested against tag 0.6.0, but it should apply just fine to HEAD. Thanks, Brian Waters -- Brian M. Waters brian(a)brianmwaters.net

Attachments:

openbsd.patch (text/x-patch — 411 bytes)

Reply

Show replies by date

Brian Waters

8 Nov 8 Nov

5:49 p.m.

Looks like I mistakenly included the patch as an attachment, so it may not have gone through. Here it is: diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 07d64ab..015fd48 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -125,7 +125,7 @@ if(UNIX) target_link_libraries(rtl_fm m) target_link_libraries(rtl_adsb m) target_link_libraries(rtl_power m) -if(APPLE) +if(APPLE OR CMAKE_SYSTEM MATCHES "OpenBSD") target_link_libraries(rtl_test m) else() target_link_libraries(rtl_test m rt) Thanks, BW -- Brian M. Waters brian(a)brianmwaters.net On Tue, Nov 5, 2019, at 5:05 PM, Brian Waters wrote:

Gets rid of librt, which doesn't exist on OpenBSD. The version of librtlsdr in the OpenBSD ports tree is extremely old (~2013), so this should help some users. Tested against tag 0.6.0, but it should apply just fine to HEAD. Thanks, Brian Waters -- Brian M. Waters brian(a)brianmwaters.net Attachments: * openbsd.patch

Reply

Adrian Chadd

9 Nov 9 Nov

11:56 a.m.

is this applicable to the other BSDs too? Ideally the rule would be "only link in rt if it's present", right? -adrian On Sat, 9 Nov 2019 at 03:08, Brian Waters <brian(a)brianmwaters.net> wrote:

Looks like I mistakenly included the patch as an attachment, so it may not have gone through. Here it is: diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 07d64ab..015fd48 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -125,7 +125,7 @@ if(UNIX) target_link_libraries(rtl_fm m) target_link_libraries(rtl_adsb m) target_link_libraries(rtl_power m) -if(APPLE) +if(APPLE OR CMAKE_SYSTEM MATCHES "OpenBSD") target_link_libraries(rtl_test m) else() target_link_libraries(rtl_test m rt) Thanks, BW -- Brian M. Waters brian(a)brianmwaters.net On Tue, Nov 5, 2019, at 5:05 PM, Brian Waters wrote: > Gets rid of librt, which doesn't exist on OpenBSD. The version of > librtlsdr in the OpenBSD ports tree is extremely old (~2013), so this > should help some users. > > Tested against tag 0.6.0, but it should apply just fine to HEAD. > > Thanks, > Brian Waters > > -- > Brian M. Waters > brian(a)brianmwaters.net > Attachments: > * openbsd.patch

Reply

Harald Welte

11 Nov 11 Nov

8:29 a.m.

Hi Brian, On Tue, Nov 05, 2019 at 05:05:47PM -0500, Brian Waters wrote:

Gets rid of librt, which doesn't exist on OpenBSD. The version of librtlsdr in the OpenBSD ports tree is extremely old (~2013), so this should help some users.

thanks, applied. -- - Harald Welte <laforge(a)osmocom.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

Reply

2071

days inactive

2077

days old

osmocom-sdr@lists.osmocom.org

Manage subscription

3 comments

3 participants

tags (0)

participants (3)

Adrian Chadd
Brian Waters
Harald Welte