4 Dec
2018
4 Dec
'18
9:47 a.m.
Hello everyone,
I implemented decoding of the [O|H]PLMNwAcT elementary file in pySim.
Here https://github.com/lazlo/pysim-dec-plmn you will also find unit tests
for the code I wrote.
Let me know if I should further refactor the code (maybe to use more of the
existing conversions functions in pySim/util.py). I'm aware it is not the
most elegant code but it does its job.
Best,
Lazlo
4 Dec
4 Dec
9:55 a.m.
Sorry! The patch had one error (name of argument mismatch with use in
function body). Fixed it.
On Tue, Dec 4, 2018 at 9:47 AM Daniel Laszlo Sitzer <laszlo.sitzer(a)sumup.com>
wrote:
Hello everyone,
I implemented decoding of the [O|H]PLMNwAcT elementary file in pySim.
Here https://github.com/lazlo/pysim-dec-plmn you will also find unit
tests for the code I wrote.
Let me know if I should further refactor the code (maybe to use more of
the existing conversions functions in pySim/util.py). I'm aware it is not
the most elegant code but it does its job.
Best,
Lazlo
2:46 p.m.
Laszlo! Great to hear from you!!
Also thanks for the patch. In the meantime we have moved to using gerrit for
code review in osmocom, and pysim is also there now. It can be a bit cumbersome
to register and login and all that, but if you don't mind it would be great if
you could submit the patch on gerrit. This wiki page should guide you through
the process: https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit
Feel free to ping here or on freenode #osmocom if you need anything!
~N
2391
days inactive
2391
days old
2 comments
2 participants
participants (2)
-
Daniel Laszlo Sitzer -
Neels Hofmeyr