Re: [PATCH] tlv/msgb: Be able to generate and parse TLV as used by LLDP

Holger Hans Peter Freyther wrote:

+++ b/src/gsm/tlv_parser.c @@ -51,6 +51,25 @@ int tlv_parse_one(uint8_t *o_tag, uint16_t *o_len, const uint8_t **o_val, return 1; }

• /*

• * Check if this could be a T7L9V tag. Do it by
  

• * shifting it to the right once. Note that this
  

• * means that mixing T7L9V with other tags is not
  

• * possible.
  

Why not explicitly specify to do this test for each tag?

Ie. leave the old function as-is, add a new function with the T7L9V heuristic, and use the new function only at call sites where T7L9V may actually be encountered.

//Peter