7 Apr
2016
7 Apr
'16
12:21 p.m.
On Thu, Apr 07, 2016 at 11:15:31AM +0200, Max wrote:
also nice to mention in the log message body
"vty_test_runner: ipa_send: factor out 2, add 3 functions"
:)
BTW, just to set the tone, I would like to mention that my feedback is
generally meant as friendly comment, in a happy office, from colleague to
colleague ;) (I'd be glad if you'd return such reviews on my patches.)
~Neels
They were useful for debugging the tests but once
it's ready the'd just
clutter the output unnecessary. Still, they'll be useful again when we
want to expand tests further so instead of adding and removing them
every time I'd prefer to keep them.
would be nice to mention in the log message body...
- 5 functions
are added, only two are used. Why add unused functions?
Will they ever be used?
Perhaps :) - Two
functions are factored out and three others are added afresh. Admitted,
the second part of the log message mentions adding functions, yet the summary
above sounds like it's only factoring out.
How would you summarize it?