31 May
2016
31 May
'16
11:38 a.m.
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/128/1/openbsc/src/gprs/gprs_llc.c
File openbsc/src/gprs/gprs_llc.c:
Line 413: uint64_t kc = *(uint64_t *)&lle->llme->kc;
If I look at:
unsigned gprs_cipher_key_length(enum gprs_ciph_algo algo) of libosmocore
Does key_length relate to sizeof(kc) here? If yes then uint64_t is even too small besides
that you are right and we should pass the address.. but maybe just use
&lle->llme->kc directly?
--
To view, visit https://gerrit.osmocom.org/128
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f1b7454a0de5b7f4734aca4d03dbe67db5de189
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Gerrit-HasComments: Yes