Re: [PATCH] Use generic osmocom auth api

Hi Max, thanks for your patch. I think it would make more sense to 1) add XOR to libosmocore 2) have a table or function to map from AUTH_ALGO_COMP128v1 to OSMO_AUTH_ALG_COMP128v1 (as well as mappings for any other ciphers at that time, _use_xor() / _use_comp128_v1() become superfluous, and auth_get_tuple_for_subscr() can call osmo_auth_gen_vec() directly. This way, adding more algorithms only has to add mappings for the AUTH_ALGO_* to OSMO_AUTH_ALG_ values (and a way how the vty can change the algorithm for a given subscriber). What do you think? Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)