10 Oct
2018
10 Oct
'18
1:09 p.m.
On Wed, Oct 10, 2018 at 09:17:52AM +0200, Stefan Sperling wrote:
Multi-user history support could be left for later.
...is impossible to do server-side, without adding the concept of a user name,
which I'd -1.
For now, we could simply have the server write the
history of any
connected session to the file when command history is enabled.
when a telnet vty closes, append all history to
$history_path/$program_name.history
ok, simple enough.
Yet it adds potentially large I/O to the server process, which would block
until the history is written. That might be undesirable...
Could also flush the history to file every time it reaches a given size to make
sure of light I/O load.
I sometimes invoke the vty with 'watch', or otherwise scripted, to keep showing
the lchan summary, for example. That would produce a history entry for every
single invocation, cause disk I/O and spam the history file. Do we need to
enable history explicitly in each vty session? Or a a "no history" command per
vty-session?
A client-side impl is much simpler from that angle. It just keeps so much cruft
out of the server process, and "all we need" is a readline() that knows vty
special characters.
A client-side history solution could still be added
later, independently
of any server-side solution.
I doubt we will have the other when one is already there.
So I guess it's up to who will contribute code first.
~N