Re: [PATCH 6/9] mgcp: Set output_enabled flags based on the MGCP mode

On Tue, Jan 07, 2014 at 12:07:48PM +0100, Jacob Erlbeck wrote:

Good Morning,

diff --git a/openbsc/tests/mgcp/mgcp_test.ok b/openbsc/tests/mgcp/mgcp_test.ok index 43a7402..6db7226 100644 --- a/openbsc/tests/mgcp/mgcp_test.ok +++ b/openbsc/tests/mgcp/mgcp_test.ok

In the test case you force the output_enabled variable to 0. Now that the state is set based on the connection mode I think it is dangerous to set the state inside the testcase. mgcp_free_endpoint should reset it and we should rely and test that.

What do you think?