Re: Coverity issues in lapd_core/gsm mncc

Holger Hans Peter Freyther wrote:

so maybe it simplifies the code just to assume/assert that the msgb is present in the primitive? As you freed the msgb, this means that OsmocomBB currently leaks this msgb during the handling of assignment?

hi holger,

lapdm.c takes the re-establishment message and forwards it to lapd_core.c, so we can assume that msg is set. i case there is data in the re-establishment msg, it is moved into send_buffer. in case of no data it must be freed. (currently i don't know why resume/re-establishment requires content in SABM message.)

regards,

andreas