From: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Hi,
This is the second version of the libosmo-abis patchset. Mostly
aiming to improve robustness and fix leaks in error paths.
I have tried to address all Holger comments, I leave two things
for my TODO list:
1) automate testing via automated testing while compilation
2) check the bfd->fd = -1 to make sure we need it in all cases
I have also intensively tested (although it was quite manual)
this changes with the IPA BSC/BTS tests, running valgrind to
check for leaks.
If you find any issue or you think it's OK, please ACK/NACK.
Thanks.
Pablo Neira Ayuso (13):
ipa: fix missing set of write_cb for IPA client connection
ipaccess: fix leak of e1inp_line
tests: e1inp_ipa_bsc_test: fix crash
ipaccess: improve error handling
tests: e1inp_ipa_bts_test: fix compilation warnings
lapd: use C99 structure initialization for profile templates
input: dahdi: use logging facilities instead of fprintf and stderr
input: dahdi: replace exit by return
input: add generic PCAP interface for LAPD
tests: fix CPU suckup e1inp_ipa_bts_test after test finish
tests: e1inp_ipa_*_test: add signal handling for process termination
tests: e1inp_ipa_*_test: fix leak of msgb in ->sign_link path
ipaccess: fix leak of IPA control messages in the BTS side
include/Makefile.am | 2 +-
include/osmocom/abis/lapd.h | 1 +
include/osmocom/abis/lapd_pcap.h | 11 ++
src/Makefile.am | 1 +
src/e1_input.c | 1 +
src/input/dahdi.c | 54 ++++++----
src/input/hsl.c | 3 -
src/input/ipa.c | 3 +
src/input/ipaccess.c | 210 ++++++++++++++++++++++++++------------
src/input/lapd.c | 66 +++++++-----
src/input/lapd_pcap.c | 159 +++++++++++++++++++++++++++++
tests/e1inp_ipa_bsc_test.c | 26 ++++-
tests/e1inp_ipa_bts_test.c | 31 +++++-
13 files changed, 443 insertions(+), 125 deletions(-)
create mode 100644 include/osmocom/abis/lapd_pcap.h
create mode 100644 src/input/lapd_pcap.c
--
1.7.10.4