Re: [PATCH 9/9] mgcp: Send RTP keepalive dummy packets to net

On 13.01.2014 09:57, Holger Hans Peter Freyther wrote:

On Tue, Jan 07, 2014 at 12:07:51PM +0100, Jacob Erlbeck wrote:

...

• for (i = 1; i < tcfg->number_endpoints; ++i) {

• struct mgcp_endpoint *endp = &tcfg->endpoints[i];
  

• if (endp->bts_end.output_enabled)
  

Shouldn't this code look at the connection mode? E.g. the output is enabled even in SEND_RECV mode and then we certainly don't need to send dummy packets?

If (and only if) we can rely on incoming packets from any type of BTS when SEND_RECV is used, we could optimize these few packets away.

Otherwise I'd rather check, whether packets have been sent to the net since the last timeout and only send a keep alive packet if there were none.

Jacob