16 Mar
2016
16 Mar
'16
6:48 p.m.
Hi Max,
On Wed, Mar 16, 2016 at 05:34:58PM +0100, msuraev@sysmocom.de wrote:
+/* EARFCN (16 bits) array */
- uint16_t *arfcn;
comment should have same indent as the struct member
- for (i = 0; i < e->length; i++)
if (OSMO_EARFCN_INVALID == e->arfcn[i]) {
missing {} around the indented if block. The rule is (please check Linux kernel coding style) that only if there is a single line inside the block, we dont use curly braces.
- return ENOMEM;
generally we return negative values for errors, so it should be -ENOMEM.
--
- Harald Welte laforge@gnumonks.org http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)