21 Jul
2013
21 Jul
'13
10:48 a.m.
Hi Pablo,
On Mon, Jul 08, 2013 at 01:28:44AM +0200, Pablo Neira Ayuso wrote:
BTW, I'm hitting this compilation warning here:
trau/osmo_ortp.c: In function 'osmo_rtcp_fd_cb':
trau/osmo_ortp.c:207:2: warning: implicit declaration of function
'rtp_session_rtcp_recv' [-Wimplicit-function-declaration]
I can find that function defined in a private header of ortp, any clue
on why we need it there?
Please read the comment in the source above it:
/* We probably don't need this at all, as
* rtp_session_recvm_with_ts() will alway also poll the RTCP
* file descriptor for new data */
Theoretically it is the right thing for the application/osmocore select
loop handling to detect the arrival of a RTCP message on the socket and
let the ortp library know.
However, ortp seems to prefer to simply poll that file descriptor every
time a RTP data frame arrives. So if you receive an RTCP message but
not an RTP frame in a long time, that RTCP will get delayed witnhout any
good reason.
So I thought it might be a good idea to simply pass this information
into the library.
RTCP handling of libosmo-trau was never tested so far, AFAIK.
Regards,
Harald
--
- Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)