18 May
2016
18 May
'16
9:29 a.m.
Patch Set 3:
Hi,
we (specially I am) are a bit picky on granularity of changes. Could you move the .gitignore part to a different patch please. In terms of OSX did you try to run make check? We hijack/overload/interpose some of the "libc" symbols in our tests and this fails on OSX because in OSX the symbol look-up is per DSO.
There is an option in the OSX linker to disable it but I never made up my mind if:
* we skip these test on OSX * force the linker to be more like GNU/Linux and FreeBSD
Do you have an opinion?
--
To view, visit https://gerrit.osmocom.org/74
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I580a500edcf4812e570be586890abef746083a8c
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Arran Cudbard-bell a.cudbardb@freeradius.org
Gerrit-Reviewer: Holger Freyther holger@freyther.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No