Patch Set 5:
(1 comment)
SIP needs to be disabled anyway for SCTP NKE. So could use LD_PRELOAD... OR something
else if you wanted me to investigate abstracting SCTP out and using usrsctp.
https://gerrit.osmocom.org/#/c/74/4/src/stats.c
File src/stats.c:
Line 357: #ifdef MSG_NOSIGNAL
I don't like #ifdefs in code too much. I will let
this one in but in genera
The issue I have with defining macros to be no ops is that
it makes things harder to track down. If you put MSG_NOSIGNAL in a bitmask you expect
that behaviour, not for it to be ignored.
Usually I try and define abstract macros that deal with the variances between systems, but
that's not possible here.
--
To view, visit
https://gerrit.osmocom.org/74
To unsubscribe, visit
https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I580a500edcf4812e570be586890abef746083a8c
Gerrit-PatchSet: 5
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Arran Cudbard-bell <a.cudbardb(a)freeradius.org>
Gerrit-Reviewer: Arran Cudbard-bell <a.cudbardb(a)freeradius.org>
Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes