Re: Bad signalling message

Pablo Neira Ayuso wrote:

+++ b/src/input/ipaccess.c @@ -450,10 +450,13 @@ static int handle_ts1_read(struct osmo_fd *bfd) goto err_msg; } if (e1i_ts->line->ops->sign_link(msg) < 0) {

• /* Don't close the signalling link if the upper layers report
  

•  * an error, that's too strict. BTW, the signalling layer is
  

•  * resposible for releasing the message.
  

•  */
  

  LOGP(DLINP, LOGL_ERROR, "Bad signalling message," "sign_link returned error\n"); ret = -EINVAL;

• goto err;
  

  }

  return 0;

If the code flow will be to fall through to the 'return 0' statement then I suggest to also remove the ret = -EINVAL line inside the condition. I think it creates some confusion about what is really intended.

//Peter