On 14/03/2017 12:21, Neels Hofmeyr wrote:
Ah, so that part is SQlite DB related. I've been very active in Osmocom for the past 15 or so months thanks to sysmocom, but still learning new aspects of the code base regularly :)
Yep, there are some big FIXME message in openbsc/src/libmsc/db.c: db_sms_store()
Regarding removing SMS - it should be fine based on validity time of the
I am mildly concerned about concurrent write access to the sqlite hlr, although I saw the SMS table corrupted once, that prevented the nitb strting, I'm not even sure it was caused by concurrent writes. I read up about locking and how sqlite handles this, it should be OK.
SMS and it was completely broken. I had a patch set which fixed validity time handling, but IIRC it wasn't merged. We can probably dug it up, but I don't have much time to rebase / adapt it to the new codebase right now. If there are any volunteers, that would be great.
For Osmocom's future plans in general, we are moving away from having an SQLite database in the OsmoNITB (and the new OsmoMSC). So we would probably not want to spend effort on optimizing the old SMS storage "just before" we go on to get rid of it altogether.
Yep.. how long is just before? (in ms please) :-) There isn't really an uncomplicated (out-of-the-box) SMSC solution at this time. We should probably fix this up and create some internal purging of sent SMS? I wanted to write routines to view more info about the SMS queue from the vty. Maybe this part is not worth it, especially as I've done it in python.
Sending SMS to the wrong recipient though is probably worth fixing. That should really not happen.
No, it makes people rather irate. :-(