18 Dec
2016
18 Dec
'16
4:26 p.m.
Hi.
Some comments are inline.
18.12.2016 16:53, Neels Hofmeyr пишет:
I'd like to +1 this, but for one implementation
detail: at the moment e.g. an
installation of libosmocore finds the most recent signed tag in git and bases
the installed version number on that. So either we need a "moving tag" that
continuously follows master (I think not), or we change the way that
./configure figures out what the current version number to be installed is.
Could describe this in more details? What exactly do you mean by "installation
finds"? When I install new libosmocore locally via dpkg the version number is
defined
by the latest entry in debian/changelog.
It's nice to have an automatic lookup, so that the
git tag magically gives the
right version number, but we do also have manual work to do in the debian files
for a release anyway. So I guess it would be handy to note the version manually
instead of using git tags (i.e. keep the .version file in git), then we could
go with this scheme. We could have some sort of validation step in the release
process to ensure a tag is also set on a revision with matching content in
.version.
I think it's a really good idea, what do you others think?
I think it's extremely bad idea to keep auto-generated data under version control and
than try to deal with version controlled vs autogenerated mess.
Besides I don't really understand the problem you're trying to solve to begin
with,
but I'm pretty sure that storing generated version data under git is not the best way
to go.
--
Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte