Re: [PATCH 3/3] Add utility to check proper scheduling of SI

Hi Max, I merged all three of your patches in this series. On Thu, Mar 17, 2016 at 11:37:24AM +0100, msuraev(a)sysmocom.de wrote: I think this is overly complicatd and it requires tshark, relies on tshark string output stays constant/backwards-compatible/... I would have preferred if this was a simple C program that parses the GSMTAP header to detemine frame number and other derived timing information, simply checks for frames sent on BCCH and then checks the L3 msg_type to determine whcih SI message is being sent. Such a small C-language program could/should be compiled alongside with the other test programs, and wouldn't have any external dependencies or depend on implementation details of those dependencies not changing over time. I understand that one advantage of using a different tool like tshark is of course that they parse the messages with a different implementation. But then, we only need to extract very few fields, like * arfcn * gsm frame number * channel type BCCH * L3 message ID and there's no real parsing of the SI message content involved. So next time for similar tasks, please try to avoid constructs like tshark+gawk, particularly if all that's neded would pe possible to do in one relatively simple C source file using the osmocom abstraction for sockets, definition of gsmtap messages, etc. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)