Re: [PATCH 2/3] Improve BSSGP debug output

On Wed, Mar 09, 2016 at 12:29:24PM +0100, msuraev@sysmocom.de wrote:

Print string representation of Cause IE and PDU type in addition to numerical value.

thanks. I'd like to merge, but

• DEBUGP(DBSSGP, "BSSGP BVCI=%u Rx PDU type 0x%02x not [yet] "
  

• 	"implemented\n", bctx->bvci, pdu_type);
  

• DEBUGP(DBSSGP, "BSSGP BVCI=%u Rx PDU type 0x%02x (%s) not [yet] "
  

•        "implemented\n", bctx->bvci, pdu_type, bssgp_pdu_str(pdu_type));
  

pleaes remove the 0x%02x numeric printing. The %s via bssgp_pdu_str() will automatically fall back to printing the numeric type as "unknown 0x%x" when it is unknown, as part of the value_string implementation, IIRC.