Hi everybody,
as some of you may have noticed due to the generated noise in gerrit ml
during last days, I have been adding some autotest setup to osmo-trx in
order to have several tests being run during gerrit review. Since
osmo-trx has some specific code built with NEON instructions, I also
added some infrastructure to jenkin.sh to generate and use a prebuilt
debian armhf rootfs so we can easily build and run tests using qemu-arm
from our local workstations or from jenkins slaves, which will check
that support for those architectures doesn't become broken.
In order to set up the make check tests, I re-used existing tests and
moved them to the tests/ directory. I also moved
utils/convolvtest/main.c into "tests/Transceiver52M/convolve_test" [1]
to become a test that checks "convolve_{real,complex}" APIs.
I noticed, however, that this test prints slightly (or not that
slightly) different outputs on different machine architectures, which of
course make tests fail as it matches the exact values.
So far the output is different in my x86_64 workstation, my i686 netbook
(or i586 OBS host) and in my qemu-arm (armhf).
As each machine uses different instructions sets, I indeed can
understand that there appear small differences due to floating
operations and rounding, but sometimes I can see relatively big
difference between one implementation and the other one (eg 7.032490 vs
6.655972).
I'm thinking about modifying the test to, instead of matching the output
exactly, check that for each value in the vector it is similar to a
value with a maximum epsilon distance from a reference vector. However,
as I don't have any knowledge regarding the maths and theory behind the
convolution codes, I must admit I am not sure which epsilon should I be
using, or which should be the expected output for the test. It may
perhaps make sense to have separate reference output for different
architectures, I don't know. Can somebody shed some light on this topic?
Any advise or hint is welcome.
It would also be nice to have some tests for the "convert" API, which
uses optimized instructions sets too. If somebody wants to provide those
or any hint on how to implement them that's going to be handy.
All the test infrastructure is merged now, only the patch adding the
qemu part is not merged but already working in [2], I'll merge it
tomorrow if nobody is angry with it. You can find related output for the
test I was speaking of for different machine arch (x86_64, i686, arm) in
[3] and [4].
[1]https://git.osmocom.org/osmo-trx/tree/tests/Transceiver52M/convolve_test.c
[2] https://gerrit.osmocom.org/#/c/5763
[3] https://osmocom.org/issues/2826
[4] https://osmocom.org/issues/2828
--
- Pau Espin Pedrol <pespin(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte
Ahh ok. Im so stupid not really mean with a simple english.
Thanks Neels.
DUO
On Jan 15, 2018 6:57 PM, "Neels Hofmeyr" <nhofmeyr(a)sysmocom.de> wrote:
> here is the config https://pastebin.com/BKcPUbzb
Prepend a 'no' to disable it:
nitb
no subscriber-create-on-demand
~N
Hello,Is the osmonitb3G have capabilities to roam with the existing operator in the world!?
And, is it possible to launch call and sms to some existing operator !?
Chears,
See <http://jenkins.osmocom.org/jenkins/job/Coverity-Upload/label=linux_amd64_de…>
------------------------------------------
[...truncated 2.14 MB...]
make[4]: Nothing to be done for 'install-exec-am'.
make[4]: Nothing to be done for 'install-data-am'.
make[4]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh/doc'
make[3]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh/doc'
make[2]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh/doc'
make[2]: Entering directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh'
make[3]: Entering directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh'
make[3]: Nothing to be done for 'install-exec-am'.
/bin/mkdir -p '/home/osmocom-build/osmo-ci/coverity/install-Osmocom/lib/pkgconfig'
/usr/bin/install -c -m 644 libosmo-ranap.pc '/home/osmocom-build/osmo-ci/coverity/install-Osmocom/lib/pkgconfig'
make[3]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh'
make[2]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh'
make[1]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh'
+ popd
~/osmo-ci/coverity/source-Osmocom
+ build_osmopcu
+ pushd osmo-pcu
~/osmo-ci/coverity/source-Osmocom/osmo-pcu ~/osmo-ci/coverity/source-Osmocom
+ do_build --enable-sysmocom-bts=yes --enable-sysmocom-dsp=yes
+ autoreconf --install --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and
libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree.
libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
configure.ac:21: installing './compile'
configure.ac:24: installing './config.guess'
configure.ac:24: installing './config.sub'
configure.ac:9: installing './install-sh'
configure.ac:9: installing './missing'
src/Makefile.am: installing './depcomp'
tests/Makefile.am:13: warning: source file 'alloc/AllocTest.cpp' is in a subdirectory,
tests/Makefile.am:13: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled. For now, the corresponding output
automake: object file(s) will be placed in the top-level directory. However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
tests/Makefile.am:29: warning: source file 'bitcomp/BitcompTest.cpp' is in a subdirectory,
tests/Makefile.am:29: but option 'subdir-objects' is disabled
tests/Makefile.am:29: warning: source file '../src/egprs_rlc_compression.cpp' is in a subdirectory,
tests/Makefile.am:29: but option 'subdir-objects' is disabled
tests/Makefile.am:88: warning: source file 'codel/codel_test.c' is in a subdirectory,
tests/Makefile.am:88: but option 'subdir-objects' is disabled
tests/Makefile.am:35: warning: source file 'edge/EdgeTest.cpp' is in a subdirectory,
tests/Makefile.am:35: but option 'subdir-objects' is disabled
tests/Makefile.am:43: warning: source file 'emu/pcu_emu.cpp' is in a subdirectory,
tests/Makefile.am:43: but option 'subdir-objects' is disabled
tests/Makefile.am:43: warning: source file 'emu/test_replay_gprs_attach.cpp' is in a subdirectory,
tests/Makefile.am:43: but option 'subdir-objects' is disabled
tests/Makefile.am:43: warning: source file 'emu/openbsc_clone.c' is in a subdirectory,
tests/Makefile.am:43: but option 'subdir-objects' is disabled
tests/Makefile.am:43: warning: source file 'emu/test_pdp_activation.cpp' is in a subdirectory,
tests/Makefile.am:43: but option 'subdir-objects' is disabled
tests/Makefile.am:94: warning: source file 'fn/FnTest.cpp' is in a subdirectory,
tests/Makefile.am:94: but option 'subdir-objects' is disabled
tests/Makefile.am:72: warning: source file 'llc/LlcTest.cpp' is in a subdirectory,
tests/Makefile.am:72: but option 'subdir-objects' is disabled
tests/Makefile.am:83: warning: source file 'llist/LListTest.cpp' is in a subdirectory,
tests/Makefile.am:83: but option 'subdir-objects' is disabled
tests/Makefile.am:61: warning: source file 'ms/MsTest.cpp' is in a subdirectory,
tests/Makefile.am:61: but option 'subdir-objects' is disabled
tests/Makefile.am:7: warning: source file 'rlcmac/RLCMACTest.cpp' is in a subdirectory,
tests/Makefile.am:7: but option 'subdir-objects' is disabled
tests/Makefile.am:21: warning: source file 'tbf/TbfTest.cpp' is in a subdirectory,
tests/Makefile.am:21: but option 'subdir-objects' is disabled
tests/Makefile.am:53: warning: source file 'types/TypesTest.cpp' is in a subdirectory,
tests/Makefile.am:53: but option 'subdir-objects' is disabled
+ ./configure --prefix=/home/osmocom-build/osmo-ci/coverity/install-Osmocom --enable-sysmocom-bts=yes --enable-sysmocom-dsp=yes
configure: WARNING: unrecognized options: --enable-sysmocom-bts
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether make supports nested variables... (cached) yes
checking whether make sets $(MAKE)... (cached) yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking for pkg-config... /usr/bin/pkg-config
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.20... yes
checking for ANSI C header files... (cached) yes
checking for LIBOSMOCORE... yes
checking for LIBOSMOVTY... yes
checking for LIBOSMOGSM... yes
checking for LIBOSMOGB... yes
checking whether to enable direct DSP access for PDCH of sysmocom-bts... yes
checking whether to enable direct PHY access for PDCH of NuRAN Wireless Litecell 1.5 BTS... no
checking whether to enable VTY tests... no
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating osmo-pcu.pc
config.status: creating include/Makefile
config.status: creating src/Makefile
config.status: creating examples/Makefile
config.status: creating tests/Makefile
config.status: creating Makefile
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
configure: WARNING: unrecognized options: --enable-sysmocom-bts
+ make -j 3
Making all in include
make[1]: Entering directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-pcu/include'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-pcu/include'
Making all in src
make[1]: Entering directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-pcu/src'
CXX gprs_debug.lo
CXX csn1.lo
CXX gsm_rlcmac.lo
CXX gprs_bssgp_pcu.lo
gprs_bssgp_pcu.cpp:967:2: warning: #warning "This causes ASAN to complain. It is not critical for normal operation but should be fixed nevertheless" [-Wcpp]
#warning "This causes ASAN to complain. It is not critical for normal operation but should be fixed nevertheless"
^
gprs_bssgp_pcu.cpp:76:12: warning: 'int parse_ra_cap(tlv_parsed*, MS_Radio_Access_capability_t*)' defined but not used [-Wunused-function]
static int parse_ra_cap(struct tlv_parsed *tp, MS_Radio_Access_capability_t *rac)
^
CXX gprs_rlcmac.lo
CXX gprs_rlcmac_sched.lo
CXX gprs_rlcmac_meas.lo
CXX gprs_rlcmac_ts_alloc.lo
CXX gprs_ms.lo
CXX gprs_ms_storage.lo
CXX gsm_timer.lo
CXX pcu_l1_if.lo
CC pcu_vty.lo
CXX pcu_vty_functions.lo
CC mslot_class.lo
CXX tbf.lo
In file included from bts.h:37:0,
from pcu_vty_functions.cpp:26:
tbf.h: In function 'void tbf_print_vty_info(vty*, gprs_rlcmac_tbf*)':
tbf.h:623:21: error: 'gprs_rlc_ul_window gprs_rlcmac_ul_tbf::m_window' is protected
gprs_rlc_ul_window m_window;
^
pcu_vty_functions.cpp:70:38: error: within this context
gprs_rlc_ul_window *win = &ul_tbf->m_window;
^
In file included from bts.h:37:0,
from pcu_vty_functions.cpp:26:
tbf.h:562:21: error: 'gprs_rlc_dl_window gprs_rlcmac_dl_tbf::m_window' is protected
gprs_rlc_dl_window m_window;
^
pcu_vty_functions.cpp:82:38: error: within this context
gprs_rlc_dl_window *win = &dl_tbf->m_window;
^
Makefile:763: recipe for target 'pcu_vty_functions.lo' failed
make[1]: *** [pcu_vty_functions.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-pcu/src'
Makefile:448: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
[WARNING] Build command ./build_Osmocom.sh exited with code 2. Please verify that the build completed successfully.
Emitted 1876 C/C++ compilation units (100%) successfully
1876 C/C++ compilation units (100%) are ready for analysis
For more details, please look at:
/home/osmocom-build/osmo-ci/coverity/source-Osmocom/cov-int/build-log.txt
Build step 'Execute shell' marked build as failure
Hi Neels,
I've seen some discusion (unfortunately on the sysmocom internal jaberr room,
not on a public osmocom channel) related to the docker based jenkins verification
jobs as follows:
ADD http://download.opensuse.org/repositories/network:/osmocom:/nightly/Debian_… /tmp/Release
RUN apt-get update && apt-get install -y --no-install-recommends libosmocore-dev
The "ADD" line will check if the "Release" file of the repository has changed.
If yes, the cache will be invalidated, and the following line[s] will be re-run.
If no, then the cache will remain.
It's sub-optimal in that any change to the repository (even those that are
unrelated to the packages used, [libosmocore-dev in this example]) will trigger
an image re-build. But at least it will guarantee that any update to the
libosmocore-dev package will trigger an image rebuild.
See http://git.osmocom.org/docker-playground/tree/osmo-stp-master/Dockerfile for
a real-world example
Regards,
Harald
--
- Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
Hello,I have some question, it just for curiosity! It's possible that a phone tell to the bts he did support only A5/0 encryption or it just only the BTS to command the ciphering !? and it is possible to do that for the osmocomBB !?
Chears,