OpenBSC

openbsc@lists.osmocom.org

16 participants
4247 discussions

New features without tests :/
by Harald Welte 24 May '19

24 May '19

Dear fellow Osmocom developers, I just would like to use this as a gentle reminder that we shouldn't be merging new features without having automatic tests for them in place. What comes to my mind immediately right now (but I'm sure there are other examples) is the "subscriber create on demand" feature. I couldn't find any tests in HLR_Tests.ttcn about this feature. What this means is, that it will *eventually* break unnoticed, particularly until somebody is using that feature and updating frequently to master, which is unlikely to happen. Either you run a production system and then you don't follow master, or you're just playing around and then that feature is probably not something you'd be using in many cases. What actually bugs me most about it, is that the tests should have been written first. For most of our development [1], the existing infrastructure in terms of TTCN3 Modules is very strong, and adding related tests is rather quick. This means it's *very* feasible to write the tests first and then the actual code. In fact, my own experience shows that development is much faster this way, as maual testing of the entire stack with phones is sloooow. This is not to complain to Oliver or any single person, but just a general reminder to all of us. That includes first and foremost myself as I'm merging most of the development, but is addressed to all of the developers and reviewers: IF something doesn't have a test, but could reasonably be tested without spending a multitude of the development time on tests, we should mandate that tests are available at the time of merge. We of course cannot mandate or enforce that developers write the tests first and follow test-driven development methodology. But I would at least strongly encourage everyone to try that. If you first spend tons of time with manual testing and then write a test case, it's much less efficient as you spend time for both. OTOTH, if you first invest the time into writing the test, then the development can make very quick progress and you save a lot of time that would otherwise be wasted with manual testing. Regards, Harald [1] I'm referring to rather self-cntained, small features. For sure, e.g. testing inter-MSC-HO requires lots of new tsting infrastructure to be developed, as does testing of the PCU. So yes, there are exception. -- - Harald Welte <hwelte(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

3 3

osmo_fsm and time_t
by Harald Welte 23 May '19

23 May '19

Hi Neels, in the following commit: commit 89991fdb7c01fa42e323577b4026985e580763cf Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Jan 28 19:06:53 2019 +0100 you introduce language about restricting the timeout to a signed 32bit value, as time_t is not well-defined on 32bit systems. What I'm somehow missing is where we are using time_t in this context? Neither osmo_fsm code nor the underlying osmo_timer_list seems to be using time_t. So why would we bother about time_t here? Thanks for sharing your thoughts. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

2 1

osmo_fsm and sub-second timeouts
by Harald Welte 18 May '19

18 May '19

Hi all! As some of you know, I'm currently using libosmocore, and specifically osmo_fsm inside some cortex-m microcontroller projects. One of the features I need there: FSM timeouts below 1s. osmo_fsm uses osmo_timer_list as underlying timer, and that timer can express any timeval (seconds + microseconds) as timeout. Only the osmo_fsm API doesn't expose that part. What I could now do: Simply add osmo_fsm_inst_state_chg2 which takes one more argument for microseconds. However, I find that "second, microsecond" style with two arguments everywhere quite clumsy. So what I'm instead suggesting is to add new API that use one single timeout value (like the current API), but specify the timeout in milliseconds. The old API then becomes a wrapper around the new API, simply multiplyin timeouts by a factor of 1000. Does anyone think this is too restrictive? I currently cannot think of use cases where timeouts below one 1ms or with granularity below 1ms matter *and* where one would want to use osmo-fsm. But given how speeds of systems (both processors and communications systems) are increasing, it might be that we'd eventually need that? I'd currently assume osmo_fsm with all of its internal logging, etc. is too heavy-weight for such super-time-constrained use cases. And in terms of value range: Assuming a 32bit architecture, the scale of a 2^32 microsecond value is sufficient to express timeouts up to 1193 hours, which in turn is about 49 days. Any comments, ideas, thoughts? Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

1 0

External clock source for LimeSDR mini
by Rafael Diniz 08 May '19

08 May '19

Hi all, Could anyone advise me which solution should I look for feeding the LimeSDR mini with external clock GPSDO locked? Btw, which you think it's a better option for a home brew BTS: the LimeSDR mini with external clock plus an intel mini-pc, or the LimeNet mini? Cheers, Rafael Diniz

1 0

ttcn3: bsc-sccplite
by Neels Hofmeyr 08 May '19

08 May '19

Looking at https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test-sccplite/… looks quite horrible since build 357. However, with my own manual tests, all of those pass. It looks like most of those failures are sporadic, and I cannot reproduce them. I am not sure how to find out what is going there, I can just say that osmo-bsc looks quite stable AFAICT and that it seems to be non-determinism / timing in the ttcn3 and/or system load causing the failures. ~N

1 0

osmo_quote_str_c()
by Neels Hofmeyr 07 May '19

07 May '19

I think here is a bug: char *osmo_quote_str_c(const void *ctx, const char *str, int in_len) { char *buf = talloc_size(ctx, OSMO_MAX(in_len+2, 32)); if (!buf) return NULL; return osmo_quote_str_buf2(buf, 32, str, in_len); } We may allocate more than 32 bytes (see OSMO_MAX()) but still allow to write only 32 bytes? Looks like the allocated len should be stored in a local variable to pass to osmo_quote_str_buf2(). And if I'm right, what is the 32 for? At least 32?? ~N

3 2

Large increase in osmo-bsc SCCPlite test failures
by Harald Welte 06 May '19

06 May '19

Dear all, as you can see at https://jenkins.osmocom.org/jenkins/job/ttcn3-bsc-test-sccplite/test_result… there has been a large increase in test failures of the SCCPlite related tests in osmo-bsc over the last two builds/tests. Does anyone know what kind of changes they made which could have impacted the relted behavior? We don't see any such failures on AoIP, leading me to suspect that some changes were tested only for AoIP but not for SCCPlite? Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

1 0

Problem 2
by BT Infinite 06 May '19

06 May '19

Make Host Layer23 Command cannot build these library. I writer make command but it show those problems. (Picture 1).

3 2

Hard-dropping a PDP Context (SGSN)
by Mykola Shchetinin 23 Apr '19

23 Apr '19

Dear Osmocom community, A question about this part of code - function sgsn_ggsn_ctx_drop_pdp: http://git.osmocom.org/osmo-sgsn/tree/src/gprs/gprs_sgsn.c#n720 The second branch of the condition (hard-dropping) is called even when the phone is registered, and hence no Deactivate PDP Context Request is sent to the phone. Due to that, the phone doesn't know that the PDP Context was deleted on the network side and keeps acting as if it is still active -> the PS isn't working when this happens. Any suggestions/thoughts on how this can be fixed? Thanks Kind regards, Mykola

2 1

LimeNet Micro for BTS
by Rafael Diniz 15 Apr '19

15 Apr '19

Hi all, Have anyone tried Osmo GSM stack (including the trx) with the LimeNet Micro with the Pi compute module? My question is if it is stable enough for any real deployment or just another toy for the lab. With the USB3 LimeSDR, after a few hours I _always_ get a broken trx, with lots of failure messages... Thanks, Rafael Diniz Rhizomatica

5 7

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC