OpenBSC

openbsc@lists.osmocom.org

3 participants
4155 discussions

by Holger Hans Peter Freyther

Hi Pablo, all I have pushed GNU autotest[1] integration of libosmocore into the zecke/gnu-autotest branch and invoking make check will execute the testsuite. The output looks like this: ## ------------------------------------- ## ## libosmocore 0.4.0.10-c015 test suite. ## ## ------------------------------------- ## Regression tests. 1: bits ok 2: msgfile ok 3: sms ok 4: smscb ok 5: timer FAILED (testsuite.at:38) 6: ussd FAILED (testsuite.at:44) GNU autotest will execute an external application and then can check the exit code, compare the stdout/stderr to a file. In this case the timer test fails as the test itself is randomized and does not always provide the same output. Pablo if your time permits it would be nice if you could: - Provide a cli option to make the test have less iterations (to make make check run faster) - Provide a cli option to produce a repeatable output (e.g. by omitting the expired output). What do you think? In some ways I think that executing the timer test as part of our regression tests makes sense but maybe specially on a loaded machine the test might be flaky... holger [1] http://www.gnu.org/s/hello/manual/autoconf/Using-Autotest.html#Using-Autote…

13 years, 7 months

[PATCH 2/2] tests: timer: set maximum wait time to obtain test results

by Pablo Neira Ayuso

If the timer test takes more than 2 * (number of steps + 10), we abort the test. This calculation is based on the maximum timeout randomly set (10 seconds) plus the number of steps (some existing timers may be reset in each step). We double this to have some extra grace time to finish. --- tests/timer/timer_test.c | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/tests/timer/timer_test.c b/tests/timer/timer_test.c index 72c07a9..3775151 100644 --- a/tests/timer/timer_test.c +++ b/tests/timer/timer_test.c @@ -24,6 +24,7 @@ #include <stdio.h> #include <stdlib.h> +#include <signal.h> #include <getopt.h> #include <osmocom/core/talloc.h> @@ -137,10 +138,22 @@ static void secondary_timer_fired(void *data) } } +static void alarm_handler(int signum) +{ + fprintf(stderr, "ERROR: We took too long to run the timer test, " + "something seems broken, aborting.\n"); + exit(EXIT_FAILURE); +} + int main(int argc, char *argv[]) { int c; + if (signal(SIGALRM, alarm_handler) == SIG_ERR) { + perror("cannot register signal handler"); + exit(EXIT_FAILURE); + } + while ((c = getopt_long(argc, argv, "s:", NULL, NULL)) != -1) { switch(c) { case 's': @@ -162,6 +175,12 @@ int main(int argc, char *argv[]) osmo_timer_schedule(&main_timer, 1, 0); + /* if the test takes too long, we may consider that the timer scheduler + * has hung. We set some maximum wait time which is the double of the + * maximum timeout randomly set (10 seconds, worst case) plus the + * number of steps (since some of them are reset each step). */ + alarm(2 * (10 + timer_nsteps)); + #ifdef HAVE_SYS_SELECT_H while (1) { osmo_select_main(0); -- 1.7.2.5 --fdj2RfSjLxBAspz7--

13 years, 7 months

[PATCH 1/2] tests: timer: use stderr for non-repeatable output

by Pablo Neira Ayuso

This makes happy gnu-autotest for the timer test. We may still may fail if we run the test on a very heavy loaded system, but given the amount of timers that we using for the automatic test (only 32), this seems very unlikely to me. --- tests/timer/timer_test.c | 17 +++++++++-------- tests/timer/timer_test.ok | 21 ++------------------- 2 files changed, 11 insertions(+), 27 deletions(-) diff --git a/tests/timer/timer_test.c b/tests/timer/timer_test.c index a01a9e5..72c07a9 100644 --- a/tests/timer/timer_test.c +++ b/tests/timer/timer_test.c @@ -73,8 +73,8 @@ static void main_timer_fired(void *data) int i; if (*step == timer_nsteps) { - printf("Main timer has finished, please, wait a bit for the " - "final report.\n"); + fprintf(stderr, "Main timer has finished, please, " + "wait a bit for the final report.\n"); return; } /* add 2^step pair of timers per step. */ @@ -96,7 +96,7 @@ static void main_timer_fired(void *data) osmo_timer_schedule(&v->timer, seconds, 0); llist_add(&v->head, &timer_test_list); } - printf("added %d timers in step %u (expired=%u)\n", + fprintf(stderr, "added %d timers in step %u (expired=%u)\n", add_in_this_step, *step, expired_timers); total_timers += add_in_this_step; osmo_timer_schedule(&main_timer, TIME_BETWEEN_STEPS, 0); @@ -112,7 +112,8 @@ static void secondary_timer_fired(void *data) timersub(&current, &v->stop, &res); if (timercmp(&res, &precision, >)) { - printf("ERROR: timer %p has expired too late!\n", v->timer); + fprintf(stderr, "ERROR: timer %p has expired too late!\n", + v->timer); too_late++; } @@ -120,7 +121,7 @@ static void secondary_timer_fired(void *data) talloc_free(data); expired_timers++; if (expired_timers == total_timers) { - printf("test over: added=%u expired=%u too_late=%u \n", + fprintf(stdout, "test over: added=%u expired=%u too_late=%u \n", total_timers, expired_timers, too_late); exit(EXIT_SUCCESS); } @@ -155,8 +156,8 @@ int main(int argc, char *argv[]) } } - printf("Running timer test for %u steps, accepting imprecision " - "of %u.%.6u seconds\n", + fprintf(stdout, "Running timer test for %u steps, accepting " + "imprecision of %u.%.6u seconds\n", timer_nsteps, TIMER_PRES_SECS, TIMER_PRES_USECS); osmo_timer_schedule(&main_timer, 1, 0); @@ -166,6 +167,6 @@ int main(int argc, char *argv[]) osmo_select_main(0); } #else - printf("Select not supported on this platform!\n"); + fprintf(stdout, "Select not supported on this platform!\n"); #endif } diff --git a/tests/timer/timer_test.ok b/tests/timer/timer_test.ok index b1792f1..b4e0e11 100644 --- a/tests/timer/timer_test.ok +++ b/tests/timer/timer_test.ok @@ -1,19 +1,2 @@ -Running timer test for 16 steps, accepting imprecision of 0.010000 seconds -added 1 timers in step 0 (expired=0) -added 2 timers in step 1 (expired=0) -added 4 timers in step 2 (expired=0) -added 8 timers in step 3 (expired=0) -added 16 timers in step 4 (expired=1) -added 32 timers in step 5 (expired=4) -added 64 timers in step 6 (expired=33) -added 128 timers in step 7 (expired=87) -added 256 timers in step 8 (expired=183) -added 512 timers in step 9 (expired=466) -added 1024 timers in step 10 (expired=970) -added 2048 timers in step 11 (expired=1968) -added 4096 timers in step 12 (expired=3994) -added 8192 timers in step 13 (expired=8035) -added 16384 timers in step 14 (expired=16324) -added 32768 timers in step 15 (expired=32641) -Main timer has finished, please, wait a bit for the final report. -test over: added=65535 expired=65535 too_late=0 +Running timer test for 5 steps, accepting imprecision of 0.010000 seconds +test over: added=31 expired=31 too_late=0 -- 1.7.2.5 --fdj2RfSjLxBAspz7 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-tests-timer-set-maximum-wait-time-to-obtain-test-res.patch"

13 years, 7 months

new timer code: semantics of osmo_timer_schedule for already scheduled timer

by Sylvain Munaut

Hi, While updating libosmocore in osmocom-bb, a problem arised: 100%CPU usage and hanging. Turns out 'mobile' sometimes call osmo_timer_schedule for an already scheduled timer. Obviously this used to work and now it doesn't. The question is : Was there a defined semantics for this case previously ? Or is it supposed to be unsupported ? What would you expect it to do ? Cheers, Sylvain

13 years, 7 months

Re: new timer code: semantics of osmo_timer_schedule for already scheduled timer

by Pablo Neira Ayuso

On Sun, Nov 13, 2011 at 11:45:28AM +0100, Harald Welte wrote: > Hi Pablo and Sylvain, > > On Sun, Nov 13, 2011 at 01:28:30AM +0100, Pablo Neira Ayuso wrote: > > > Hm, I think I found one weird scenario which is not handled fine with > > your patch. [...] > > > > Yes, this scenario is strange, but I think we try to cover all possible > > situations. So I think my patch should be applied instead. > > Will the two of you please figure out what is the best option to > proceed? Revert one of Sylvains patches and apply Pablos patch? I think so. I can make it myself if you want.

13 years, 7 months

Re: new timer code: semantics of osmo_timer_schedule for already scheduled timer

by Sylvain Munaut

Hi, >> Yes, this scenario is strange, but I think we try to cover all possible >> situations. So I think my patch should be applied instead. > > Will the two of you please figure out what is the best option to > proceed? Revert one of Sylvains patches and apply Pablos patch? I applied Pablo's patch this morning after testing it worked as well. Cheers, Sylvain

13 years, 7 months

[PATCH] tests: timer: add parameter to select the number of steps

by Pablo Neira Ayuso

Holger likes having a parameter to set the number of steps in this test. Now you can set it via `-s' option. Signed-off-by: Pablo Neira Ayuso <pablo(a)gnumonks.org> --- tests/timer/timer_test.c | 25 ++++++++++++++++++++++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/tests/timer/timer_test.c b/tests/timer/timer_test.c index bcaafdb..a01a9e5 100644 --- a/tests/timer/timer_test.c +++ b/tests/timer/timer_test.c @@ -24,6 +24,7 @@ #include <stdio.h> #include <stdlib.h> +#include <getopt.h> #include <osmocom/core/talloc.h> #include <osmocom/core/timer.h> @@ -60,6 +61,7 @@ struct test_timer { #define TIMER_PRES_SECS 0 #define TIMER_PRES_USECS 10000 +static int timer_nsteps = MAIN_TIMER_NSTEPS; static unsigned int expired_timers = 0; static unsigned int total_timers = 0; static unsigned int too_late = 0; @@ -70,7 +72,7 @@ static void main_timer_fired(void *data) unsigned int add_in_this_step; int i; - if (*step == MAIN_TIMER_NSTEPS) { + if (*step == timer_nsteps) { printf("Main timer has finished, please, wait a bit for the " "final report.\n"); return; @@ -134,11 +136,28 @@ static void secondary_timer_fired(void *data) } } -int main(int argc, char** argv) +int main(int argc, char *argv[]) { + int c; + + while ((c = getopt_long(argc, argv, "s:", NULL, NULL)) != -1) { + switch(c) { + case 's': + timer_nsteps = atoi(optarg); + if (timer_nsteps <= 0) { + fprintf(stderr, "%s: steps must be > 0\n", + argv[0]); + exit(EXIT_FAILURE); + } + break; + default: + exit(EXIT_FAILURE); + } + } + printf("Running timer test for %u steps, accepting imprecision " "of %u.%.6u seconds\n", - MAIN_TIMER_NSTEPS, TIMER_PRES_SECS, TIMER_PRES_USECS); + timer_nsteps, TIMER_PRES_SECS, TIMER_PRES_USECS); osmo_timer_schedule(&main_timer, 1, 0); -- 1.7.2.5 --k1lZvvs/B4yU6o8G--

13 years, 7 months

[PATCH] timer: fix active timer re-scheduling situation

by Pablo Neira Ayuso

This patch re-adds support the timer re-scheduling situation which used to be supported until I introduced the rb-tree based timer. Signed-off-by: Pablo Neira Ayuso <pablo(a)gnumonks.org> --- src/timer.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/timer.c b/src/timer.c index 6852983..e68040f 100644 --- a/src/timer.c +++ b/src/timer.c @@ -68,6 +68,7 @@ static void __add_timer(struct osmo_timer_list *timer) */ void osmo_timer_add(struct osmo_timer_list *timer) { + osmo_timer_del(timer); timer->active = 1; INIT_LLIST_HEAD(&timer->list); __add_timer(timer); -- 1.7.2.5 --FCuugMFkClbJLl1L--

13 years, 7 months

LCR + Asterisk + NanoBTS: Strange Voice Behaviour "Dropping incompatible voice frame on lcr/1"

by Luca Bongiorni

Hi all, i compiled and configured all (mISDN, lcr, asterisk, etc...), unfortunately, when i try to place a call from the softphone to the MS, i can ear only the voice originated from the laptop to the MS and not viceversa. I'm using it on an Ubuntu 10.4, Asterisk 1.6.2.5 and the others sources from "last git". Configurations: - extension.conf: http://pastebin.com/mHH46HbQ - sip.conf: http://pastebin.com/SkPN3z6q - gsm.conf: http://pastebin.com/C1Eckdgh - interface.conf: http://pastebin.com/ctGapa1F - options.conf: http://pastebin.com/6xhgL0P1 - routing.conf: http://pastebin.com/TVNvwTEB Logs: - osmo-nitb's log: http://pastebin.com/X10B5NjE - lcr's log: http://pastebin.com/uLY9VAiB - Asterisk's log: http://pastebin.com/8qzw6aMn As you can see from Asterisk, there is a mismatch: "NOTICE[2315]: channel.c:2960 __ast_read: Dropping incompatible voice frame on lcr/1 of format alaw since our native format has changed to 0x0 (nothing) " I tried to set alaw / ulaw on the configurations, to change efr, fr and amr, but it didn't change nothing. Ideas or hints for further investigations are welcome. Regards, Luca

13 years, 8 months

[RFC] MNCC introduce a hello packet to include a version number

by Holger Hans Peter Freyther

Hi Jolly, all, I spent some time figuring out why LCR and OpenBSC wouldn't want to work with each other. The reason was the addition of an element to the MNCC structure. I propose to send a hello packet down the MNCC socket and leave it to the client to decide if the version is acceptable. I will need to move the mncc header to libosmocore as osmocomBB is currently using a copy of the OpenBSC header. comments holger

13 years, 8 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC