OpenBSC

openbsc@lists.osmocom.org

13 participants
4278 discussions

Re: lchan->s and integer overflow
by jolly 16 Mar '13

16 Mar '13

hi, (somehow i already sent this patch to the list. but it seems to be gone.) this patch should fix the underrun problem. it will only send radio link failure to bsc one and then stop processing timeout counter. regards, andreas

3 6

[PATCH] Fix: Stop RADIO LINK TIMEOUT couter S from counting, if it has reached 0
by Andreas Eversberg 14 Mar '13

14 Mar '13

In case that the counter S reached 0, it will stay 0. Subsequent received good and bad SACCH frames must not cause to trigger radio link failure again. Once the BSC has been indicated about link failure, it will release channel. The counting of S has been moved to a seperate function. This patch will ensure that the link failure is indicated only once. But even if the link failure would be sent multiple times, the BSC should ignore it. The BSC releases the channel and may only reuse it after confirm from BTS. (There cannot be any link failure indications after confirm of channel release.) The allowed timeout value range is 4..64, as defined in TS 05.08, so if the BSC sends an attribute with value out of range or other failure criterion, the Set BTS Attributes message is NACKed. --- src/common/oml.c | 12 ++++++++-- src/osmo-bts-sysmo/l1_if.c | 50 +++++++++++++++++++++++++++---------------- 2 files changed, 40 insertions(+), 22 deletions(-) diff --git a/src/common/oml.c b/src/common/oml.c index 4e2dead..bf90ff1 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -446,10 +446,16 @@ static int oml_rx_set_bts_attr(struct gsm_bts *bts, struct msgb *msg) btsb->interference.intave = *TLVP_VAL(&tp, NM_ATT_INTAVE_PARAM); /* 9.4.14 Connection Failure Criterion */ - if (TLVP_PRESENT(&tp, NM_ATT_CONN_FAIL_CRIT) && - (TLVP_LEN(&tp, NM_ATT_CONN_FAIL_CRIT) >= 2) && - *TLVP_VAL(&tp, NM_ATT_CONN_FAIL_CRIT) == 0x01) { + if (TLVP_PRESENT(&tp, NM_ATT_CONN_FAIL_CRIT)) { const uint8_t *val = TLVP_VAL(&tp, NM_ATT_CONN_FAIL_CRIT); + + if (TLVP_LEN(&tp, NM_ATT_CONN_FAIL_CRIT) < 2 + || val[0] != 0x01 || val[1] < 4 || val[1] > 64) { + LOGP(DOML, LOGL_NOTICE, "Given Conn. Failure Criterion " + "not supported. Please use critetion 0x01 with " + "RADIO_LINK_TIMEOUT value of 4..64\n"); + return oml_fom_ack_nack(msg, NM_NACK_PARAM_RANGE); + } btsb->radio_link_timeout = val[1]; } /* if val[0] != 0x01: can be 'operator dependent' and needs to diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index df660c5..bdba4c2 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -647,11 +647,39 @@ static int process_meas_res(struct gsm_lchan *lchan, GsmL1_MeasParam_t *m) return lchan_new_ul_meas(lchan, &ulm); } +/* process radio link timeout counter S */ +static void radio_link_timeout(struct gsm_lchan *lchan, int bad_frame) +{ + struct gsm_bts_role_bts *btsb = lchan->ts->trx->bts->role; + + /* if link loss criterion already reached */ + if (lchan->s == 0) + return; + + if (bad_frame) { + /* count down radio link counter S */ + lchan->s--; + DEBUGP(DMEAS, "counting down radio link counter S=%d\n", + lchan->s); + if (lchan->s == 0) + rsl_tx_conn_fail(lchan, RSL_ERR_RADIO_LINK_FAIL); + return; + } + + if (lchan->s < btsb->radio_link_timeout) { + /* count up radio link counter S */ + lchan->s += 2; + if (lchan->s > btsb->radio_link_timeout) + lchan->s = btsb->radio_link_timeout; + DEBUGP(DMEAS, "counting up radio link counter S=%d\n", + lchan->s); + } +} + static int handle_ph_data_ind(struct femtol1_hdl *fl1, GsmL1_PhDataInd_t *data_ind, struct msgb *l1p_msg) { struct gsm_bts_trx *trx = fl1->priv; - struct gsm_bts_role_bts *btsb = trx->bts->role; struct osmo_phsap_prim pp; struct gsm_lchan *lchan; struct lapdm_entity *le; @@ -681,25 +709,9 @@ static int handle_ph_data_ind(struct femtol1_hdl *fl1, GsmL1_PhDataInd_t *data_i switch (data_ind->sapi) { case GsmL1_Sapi_Sacch: - /* process radio link timeout coniter S */ - if (data_ind->msgUnitParam.u8Size == 0) { - /* count down radio link counter S */ - lchan->s--; - DEBUGP(DMEAS, "counting down radio link counter S=%d\n", - lchan->s); - if (lchan->s == 0) - rsl_tx_conn_fail(lchan, - RSL_ERR_RADIO_LINK_FAIL); + radio_link_timeout(lchan, (data_ind->msgUnitParam.u8Size == 0)); + if (data_ind->msgUnitParam.u8Size == 0) break; - } - if (lchan->s < btsb->radio_link_timeout) { - /* count up radio link counter S */ - lchan->s += 2; - if (lchan->s > btsb->radio_link_timeout) - lchan->s = btsb->radio_link_timeout; - DEBUGP(DMEAS, "counting up radio link counter S=%d\n", - lchan->s); - } /* save the SACCH L1 header in the lchan struct for RSL MEAS RES */ if (data_ind->msgUnitParam.u8Size < 2) { LOGP(DL1C, LOGL_NOTICE, "SACCH with size %u<2 !?!\n", -- 1.7.3.4 --------------050705040601090706090209--

1 0

[PATCH] Fix: Stop RADIO LINK TIMEOUT couter S from counting, if it has reached 0
by Andreas Eversberg 14 Mar '13

14 Mar '13

In case that the counter S reached 0, it will stay 0. Subsequent received good and bad SACCH frames must not cause to trigger radio link failure again. Once the BSC has been indicated about link failure, it will release channel. This patch will ensure that the link failure is indicated only once. But even if the link failure would be sent multiple times, the BSC should ignore it. The BSC releases the channel and may only reuse it after confirm from BTS. (There cannot be any link failure indications after confirm of channel release.) The minimum timeout value is 4, as defined in TS 05.08, so if the BSC sends an attribute with a value < 4, this (wrong) value is ignored and the default value of 32 is used. --- src/common/oml.c | 6 +++--- src/osmo-bts-sysmo/l1_if.c | 7 +++++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/common/oml.c b/src/common/oml.c index 4e2dead..afedefd 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -447,10 +447,10 @@ static int oml_rx_set_bts_attr(struct gsm_bts *bts, struct msgb *msg) /* 9.4.14 Connection Failure Criterion */ if (TLVP_PRESENT(&tp, NM_ATT_CONN_FAIL_CRIT) && - (TLVP_LEN(&tp, NM_ATT_CONN_FAIL_CRIT) >= 2) && - *TLVP_VAL(&tp, NM_ATT_CONN_FAIL_CRIT) == 0x01) { + (TLVP_LEN(&tp, NM_ATT_CONN_FAIL_CRIT) >= 2)) { const uint8_t *val = TLVP_VAL(&tp, NM_ATT_CONN_FAIL_CRIT); - btsb->radio_link_timeout = val[1]; + if (val[0] == 0x01 && val[1] >= 4) + btsb->radio_link_timeout = val[1]; } /* if val[0] != 0x01: can be 'operator dependent' and needs to * be parsed by bts driver */ diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index df660c5..5728df0 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -681,8 +681,11 @@ static int handle_ph_data_ind(struct femtol1_hdl *fl1, GsmL1_PhDataInd_t *data_i switch (data_ind->sapi) { case GsmL1_Sapi_Sacch: - /* process radio link timeout coniter S */ + /* process radio link timeout counter S */ if (data_ind->msgUnitParam.u8Size == 0) { + /* if link loss criterion already reached */ + if (lchan->s == 0) + break; /* count down radio link counter S */ lchan->s--; DEBUGP(DMEAS, "counting down radio link counter S=%d\n", @@ -692,7 +695,7 @@ static int handle_ph_data_ind(struct femtol1_hdl *fl1, GsmL1_PhDataInd_t *data_i RSL_ERR_RADIO_LINK_FAIL); break; } - if (lchan->s < btsb->radio_link_timeout) { + if (lchan->s > 0 && lchan->s < btsb->radio_link_timeout) { /* count up radio link counter S */ lchan->s += 2; if (lchan->s > btsb->radio_link_timeout) -- 1.7.3.4 --------------050806080900000401040704--

1 0

[osmo-bts] new cleaned version of l1sap slit of osmo-bts.
by jolly 14 Mar '13

14 Mar '13

hi harald, i just pushed a new branch with the cleaned up l1sap split. regards, andreas

1 0

[PATCH] Fix: Stop RADIO LINK TIMEOUT couter S from counting, if it has reached 0
by Andreas Eversberg 13 Mar '13

13 Mar '13

In case that the counter S reached 0 (or have been initialized with 0 value at start of lchan), it will stay 0. Subsequent received good and bad SACCH frames must not cause to trigger radio link failure again. Once the BSC has been indicated about link failure, it will close channel. --- src/osmo-bts-sysmo/l1_if.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index df660c5..5728df0 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -681,8 +681,11 @@ static int handle_ph_data_ind(struct femtol1_hdl *fl1, GsmL1_PhDataInd_t *data_i switch (data_ind->sapi) { case GsmL1_Sapi_Sacch: - /* process radio link timeout coniter S */ + /* process radio link timeout counter S */ if (data_ind->msgUnitParam.u8Size == 0) { + /* if link loss criterion already reached */ + if (lchan->s == 0) + break; /* count down radio link counter S */ lchan->s--; DEBUGP(DMEAS, "counting down radio link counter S=%d\n", @@ -692,7 +695,7 @@ static int handle_ph_data_ind(struct femtol1_hdl *fl1, GsmL1_PhDataInd_t *data_i RSL_ERR_RADIO_LINK_FAIL); break; } - if (lchan->s < btsb->radio_link_timeout) { + if (lchan->s > 0 && lchan->s < btsb->radio_link_timeout) { /* count up radio link counter S */ lchan->s += 2; if (lchan->s > btsb->radio_link_timeout) -- 1.7.3.4 --------------030009070902010606020306--

1 0

[PATCH] Refactored tests to not ignore stderr.
by Katerina Barone-Adesi 12 Mar '13

12 Mar '13

It's probably worth checking if the ussd stderr output is correct. --- tests/lapd/lapd_test.err | 4 ++++ tests/testsuite.at | 39 ++++++++++++++++++++++++++------------- tests/timer/timer_test.err | 6 ++++++ tests/ussd/ussd_test.err | 21 +++++++++++++++++++++ 4 files changed, 57 insertions(+), 13 deletions(-) create mode 100644 tests/lapd/lapd_test.err create mode 100644 tests/timer/timer_test.err create mode 100644 tests/ussd/ussd_test.err diff --git a/tests/lapd/lapd_test.err b/tests/lapd/lapd_test.err new file mode 100644 index 0000000..55bbd68 --- /dev/null +++ b/tests/lapd/lapd_test.err @@ -0,0 +1,4 @@ +<0001> lapd_core.c:886 Store content res. +[0;m<0001> lapd_core.c:1735 writing an empty message is not possible. +[0;m<0001> lapdm.c:1081 ((nil)) RLL Message 'REL_REQ' received without LAPDm context. (sapi 0) +[0;m \ No newline at end of file diff --git a/tests/testsuite.at b/tests/testsuite.at index 21fad1d..dc56517 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -6,7 +6,8 @@ AT_BANNER([Regression tests.]) AT_SETUP([a5]) AT_KEYWORDS([a5]) cat $abs_srcdir/a5/a5_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/a5/a5_test], [], [expout]) +cat $abs_srcdir/a5/a5_test.err > experr +AT_CHECK([$abs_top_builddir/tests/a5/a5_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([bssgp-fc]) @@ -19,13 +20,15 @@ AT_CLEANUP AT_SETUP([bits]) AT_KEYWORDS([bits]) cat $abs_srcdir/bits/bitrev_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/bits/bitrev_test], [], [expout]) +cat $abs_srcdir/bits/bitrev_test.err > experr +AT_CHECK([$abs_top_builddir/tests/bits/bitrev_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([conv]) AT_KEYWORDS([conv]) cat $abs_srcdir/conv/conv_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/conv/conv_test], [], [expout]) +cat $abs_srcdir/conv/conv_test.err > experr +AT_CHECK([$abs_top_builddir/tests/conv/conv_test], [], [expout], [experr]) AT_CLEANUP if ENABLE_MSGFILE @@ -33,56 +36,65 @@ AT_SETUP([msgfile]) AT_KEYWORDS([msgfile]) cp $abs_srcdir/msgfile/msgconfig.cfg . cat $abs_srcdir/msgfile/msgfile_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/msgfile/msgfile_test], [], [expout]) +cat $abs_srcdir/msgfile/msgfile_test.err > experr +AT_CHECK([$abs_top_builddir/tests/msgfile/msgfile_test], [], [expout], [experr]) AT_CLEANUP endif AT_SETUP([sms]) AT_KEYWORDS([sms]) cat $abs_srcdir/sms/sms_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/sms/sms_test], [], [expout]) +cat $abs_srcdir/sms/sms_test.err > experr +AT_CHECK([$abs_top_builddir/tests/sms/sms_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([smscb]) AT_KEYWORDS([smscb]) cat $abs_srcdir/smscb/smscb_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/smscb/smscb_test], [], [expout]) +cat $abs_srcdir/smscb/smscb_test.err > experr +AT_CHECK([$abs_top_builddir/tests/smscb/smscb_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([timer]) AT_KEYWORDS([timer]) cat $abs_srcdir/timer/timer_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/timer/timer_test -s 5], [], [expout], [ignore]) +cat $abs_srcdir/timer/timer_test.err > experr +AT_CHECK([$abs_top_builddir/tests/timer/timer_test -s 5], [], [expout], [experr]) AT_CLEANUP AT_SETUP([ussd]) AT_KEYWORDS([ussd]) cat $abs_srcdir/ussd/ussd_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/ussd/ussd_test], [], [expout], [ignore]) +cat $abs_srcdir/ussd/ussd_test.err > experr +AT_CHECK([$abs_top_builddir/tests/ussd/ussd_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([auth]) AT_KEYWORDS([auth]) cat $abs_srcdir/auth/milenage_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/auth/milenage_test], [], [expout], [ignore]) +cat $abs_srcdir/auth/milenage_test.err > experr +AT_CHECK([$abs_top_builddir/tests/auth/milenage_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([lapd]) AT_KEYWORDS([lapd]) cat $abs_srcdir/lapd/lapd_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/lapd/lapd_test], [], [expout], [ignore]) +cat $abs_srcdir/lapd/lapd_test.err > experr +AT_CHECK([$abs_top_builddir/tests/lapd/lapd_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([gsm0808]) AT_KEYWORDS([gsm0808]) cat $abs_srcdir/gsm0808/gsm0808_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/gsm0808/gsm0808_test], [], [expout], [ignore]) +cat $abs_srcdir/gsm0808/gsm0808_test.err > experr +AT_CHECK([$abs_top_builddir/tests/gsm0808/gsm0808_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([gsm0408]) AT_KEYWORDS([gsm0408]) cat $abs_srcdir/gsm0408/gsm0408_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/gsm0408/gsm0408_test], [], [expout], [ignore]) +cat $abs_srcdir/gsm0408/gsm0408_test.err > experr +AT_CHECK([$abs_top_builddir/tests/gsm0408/gsm0408_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([logging]) @@ -110,5 +122,6 @@ AT_CLEANUP AT_SETUP([strrb]) AT_KEYWORDS([strrb]) cat $abs_srcdir/strrb/strrb_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/strrb/strrb_test], [], [expout], [ignore]) +cat $abs_srcdir/strrb/strrb_test.err > experr +AT_CHECK([$abs_top_builddir/tests/strrb/strrb_test], [], [expout], [experr]) AT_CLEANUP diff --git a/tests/timer/timer_test.err b/tests/timer/timer_test.err new file mode 100644 index 0000000..946bf49 --- /dev/null +++ b/tests/timer/timer_test.err @@ -0,0 +1,6 @@ +added 1 timers in step 0 (expired=0) +added 2 timers in step 1 (expired=0) +added 4 timers in step 2 (expired=0) +added 8 timers in step 3 (expired=0) +added 16 timers in step 4 (expired=3) +Main timer has finished, please, wait a bit for the final report. diff --git a/tests/ussd/ussd_test.err b/tests/ussd/ussd_test.err new file mode 100644 index 0000000..774a357 --- /dev/null +++ b/tests/ussd/ussd_test.err @@ -0,0 +1,21 @@ +<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m<0000> gsm0480.c:299 Component does not fit. +[0;m \ No newline at end of file -- 1.8.1.4

2 1

lchan->s and integer overflow
by Holger Hans Peter Freyther 12 Mar '13

12 Mar '13

Dear Jolly, from a quick look it appears to be that a very long running connection could overflow lchan->s to a negative number. Could you either make this code robust or explain why it is not needed? E.g. if we assume that this happens once per multiframe the counter will overflow within 1.3 hours? holger

4 7

[PATCH] Modified openbsc tests to not ignore stderr
by Katerina Barone-Adesi 12 Mar '13

12 Mar '13

The mgcp, bsc-nat, and abis tests are now rather fragile. It's probably worth checking that everything in their .err files should actually be there and is expected. --- openbsc/tests/abis/abis_test.err | 13 +++++++++++++ openbsc/tests/bsc-nat/bsc_nat_test.err | 6 ++++++ openbsc/tests/mgcp/mgcp_test.err | 25 +++++++++++++++++++++++++ openbsc/tests/testsuite.at | 24 ++++++++++++++++-------- 4 files changed, 60 insertions(+), 8 deletions(-) create mode 100644 openbsc/tests/abis/abis_test.err create mode 100644 openbsc/tests/bsc-nat/bsc_nat_test.err create mode 100644 openbsc/tests/mgcp/mgcp_test.err diff --git a/openbsc/tests/abis/abis_test.err b/openbsc/tests/abis/abis_test.err new file mode 100644 index 0000000..56a86f3 --- /dev/null +++ b/openbsc/tests/abis/abis_test.err @@ -0,0 +1,13 @@ +[1;36m<0005> abis_nm.c:410 FILE_VERSION attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:410 FILE_VERSION attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:410 FILE_VERSION attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:410 FILE_VERSION attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:410 FILE_VERSION attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:410 FILE_VERSION attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:398 FILE_ID attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:398 FILE_ID attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:398 FILE_ID attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:398 FILE_ID attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:398 FILE_ID attribute identifier not found! +[0;m[1;36m<0005> abis_nm.c:398 FILE_ID attribute identifier not found! +[0;m \ No newline at end of file diff --git a/openbsc/tests/bsc-nat/bsc_nat_test.err b/openbsc/tests/bsc-nat/bsc_nat_test.err new file mode 100644 index 0000000..2ba39cb --- /dev/null +++ b/openbsc/tests/bsc-nat/bsc_nat_test.err @@ -0,0 +1,6 @@ +<000b> ../../src/osmo-bsc_nat/bsc_mgcp_utils.c:317 Failed to find the connection. +[0;m<0014> ../../src/osmo-bsc_nat/bsc_nat_filter.c:189 Filtering 244052130421059 by nat imsi_deny on bsc nr: 0. +[0;m<0014> ../../src/osmo-bsc_nat/bsc_nat_filter.c:189 Filtering 244052130421059 by nat imsi_deny on bsc nr: 0. +[0;m<0014> ../../src/osmo-bsc_nat/bsc_nat_filter.c:178 Filtering 244052130421059 by imsi_deny on bsc nr: 0. +[0;m<0014> ../../src/osmo-bsc_nat/bsc_nat_filter.c:78 Duplicate entry for IMSI(12123124) +[0;mfull talloc report on 'sccp' (total 1 bytes in 1 blocks) diff --git a/openbsc/tests/mgcp/mgcp_test.err b/openbsc/tests/mgcp/mgcp_test.err new file mode 100644 index 0000000..3ce9a3c --- /dev/null +++ b/openbsc/tests/mgcp/mgcp_test.err @@ -0,0 +1,25 @@ +<000b> mgcp_protocol.c:354 Unable to find Endpoint `ds/e1-2/1(a)172.16.6.66' +[0;m<000b> mgcp_protocol.c:354 Unable to find Endpoint `ds/e1-3/1(a)172.16.6.66' +[0;m<000b> mgcp_protocol.c:645 Endpoint is not holding a connection. 0x2 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'v'/118 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'c'/99 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'm'/109 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'a'/97 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'v'/118 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'c'/99 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'm'/109 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'a'/97 on 0x1 +[0;m<000b> mgcp_protocol.c:228 msg too short: 2 +[0;m<000b> mgcp_protocol.c:377 MGCP status line too short. +[0;m<000b> mgcp_protocol.c:377 MGCP status line too short. +[0;m<000b> mgcp_protocol.c:377 MGCP status line too short. +[0;m<000b> mgcp_protocol.c:377 MGCP status line too short. +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'v'/118 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'c'/99 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'm'/109 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'a'/97 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'v'/118 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'c'/99 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'm'/109 on 0x1 +[0;m<000b> mgcp_protocol.c:537 Unhandled option: 'a'/97 on 0x1 +[0;m \ No newline at end of file diff --git a/openbsc/tests/testsuite.at b/openbsc/tests/testsuite.at index e649f03..b5b972e 100644 --- a/openbsc/tests/testsuite.at +++ b/openbsc/tests/testsuite.at @@ -4,31 +4,36 @@ AT_BANNER([Regression tests.]) AT_SETUP([gsm0408]) AT_KEYWORDS([gsm0408]) cat $abs_srcdir/gsm0408/gsm0408_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/gsm0408/gsm0408_test], [], [expout], [ignore]) +cat $abs_srcdir/gsm0408/gsm0408_test.err > experr +AT_CHECK([$abs_top_builddir/tests/gsm0408/gsm0408_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([db]) AT_KEYWORDS([db]) cat $abs_srcdir/db/db_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/db/db_test], [], [expout], [ignore]) +cat $abs_srcdir/db/db_test.err > experr +AT_CHECK([$abs_top_builddir/tests/db/db_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([channel]) AT_KEYWORDS([channel]) cat $abs_srcdir/channel/channel_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/channel/channel_test], [], [expout], [ignore]) +cat $abs_srcdir/channel/channel_test.err > experr +AT_CHECK([$abs_top_builddir/tests/channel/channel_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([mgcp]) AT_KEYWORDS([mgcp]) cat $abs_srcdir/mgcp/mgcp_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/mgcp/mgcp_test], [], [expout], [ignore]) +cat $abs_srcdir/mgcp/mgcp_test.err > experr +AT_CHECK([$abs_top_builddir/tests/mgcp/mgcp_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([gprs]) AT_KEYWORDS([gprs]) cat $abs_srcdir/gprs/gprs_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/gprs/gprs_test], [], [expout], [ignore]) +cat $abs_srcdir/gprs/gprs_test.err > experr +AT_CHECK([$abs_top_builddir/tests/gprs/gprs_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([bsc-nat]) @@ -37,17 +42,20 @@ AT_CHECK([test "$enable_nat_test" != no || exit 77]) cp $abs_srcdir/bsc-nat/barr.cfg . cp $abs_srcdir/bsc-nat/barr_dup.cfg . cat $abs_srcdir/bsc-nat/bsc_nat_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/bsc-nat/bsc_nat_test], [], [expout], [ignore]) +cat $abs_srcdir/bsc-nat/bsc_nat_test.err > experr +AT_CHECK([$abs_top_builddir/tests/bsc-nat/bsc_nat_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([si]) AT_KEYWORDS([si]) cat $abs_srcdir/si/si_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/si/si_test], [], [expout], [ignore]) +cat $abs_srcdir/si/si_test.err > experr +AT_CHECK([$abs_top_builddir/tests/si/si_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([abis]) AT_KEYWORDS([abis]) cat $abs_srcdir/abis/abis_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/abis/abis_test], [], [expout], [ignore]) +cat $abs_srcdir/abis/abis_test.err > experr +AT_CHECK([$abs_top_builddir/tests/abis/abis_test], [], [expout], [experr]) AT_CLEANUP -- 1.8.1.4

1 0

[osmo-bts] Review of jolly/trx jolly/l1sap
by Harald Welte 12 Mar '13

12 Mar '13

Hi Andreas, I've found some time to review the trx and l1sap branches you have created in the osmo-bts.git repository. Let me start by mentioning that I support and encourage your work. However, I think we have to set some general rules before we can merge the code. For us, the most important factor is that we do not loose features or introduce regressions with more or less every new commit to osmo-bts. Furthermore, we would like to stay with 'one commit, one feature/fix'. I understand your primary goal ist go generalize some code and then create a working solution for the OpenBTS or OsmocomBB based transceiver. However, for the way to get the changes are integrated is to first introduce all the infrastructure/core changes while keeping osmo-bts-sysmo functional and that with all existing features. Once those core/infrastructure changes are merged, we can easily include support the extra code for the osmo-bts-trx and in fact even do all development commits to master, as long as they don't touch the core code. Looking at your commits: http://cgit.osmocom.org/cgit/osmo-bts/commit/?h=jolly/trx&id=a82995738303d7… is fine, as it just removes old code. http://cgit.osmocom.org/cgit/osmo-bts/commit/?h=jolly/trx&id=9be2099855532c… looks fine to me, too, we should be able to merge that. My only comment would be: Are you sure this should not be configured via OML from the BSC? I think TS 12.21 Chapter 9.4.14 should be the proper way to configure it. Do you agree? If yes, please use OML configuration and remove the VTY option. http://cgit.osmocom.org/cgit/osmo-bts/commit/?h=jolly/trx&id=7322254e68b7d5… seems fine to me. Can you pleaes confirm from your side that it _should_ not alter/remove any existing code/behavior, but just introduce that L1SAP intermediate interface? Have you tested it with osmo-bts-sysmo? http://cgit.osmocom.org/cgit/osmo-bts/commit/?h=jolly/trx&id=1c3712962195d1… seems to not just remove the direct handling of primitives, but also add some code, particularly the gsmtap_ip command line argument. Can you please split that in a separate patch? Also, have you tested osmo-bts-sysmo after this commit? Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

4 4

Re: neighbour cells
by Holger Hans Peter Freyther 12 Mar '13

12 Mar '13

On Wed, Feb 29, 2012 at 09:21:34AM +0100, jolly wrote: > hi, Hi jolly, > i have tested it with several configurations. i would like to commit it > to master. any suggestions? Do you remember your test setup and the results of it? There appears to be an issue with iPhone4s and iPhone5 phones (and PCS). It appears to me that there are at least three issues with the generation: * The SI1 rest_octets indicated DCS while PCS was used (this is fixed) * The Ext-Ind claims that SI2 carries the complete BA even if SI2ter/2bis are scheduled. * The BA-Ind is the same for SDCCH/BCCH. We should use 0/1. Could you have a look at it? thanks holger

2 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC