OpenBSC January 2018

openbsc@lists.osmocom.org

29 participants
47 discussions

by Vadim Yanitskiy

Dear Harald, In this mail I would like to express my thoughts and ideas regarding to the 'external interface for USSD'. To provide some background for other mailing list members, who are not aware of this topic, I'll explain it in a few sentences. We already have an external interface for SMS - SMPP. But unfortunately, the same cannot be said about USSD. There is no built-in support of any interface, which could be used to handle USSD requests in a separate application. So, at the moment we only handle *#100# (own number request), which is implemented as a part of both OsmoMSC and legacy OsmoNiTB. And if one would like to implement additional USSD commands, it's required to modify and recompile the whole project :/ Fairwaves team already have some draft implementation for legacy OsmoNiTB, which relays on the libosmocore's GSM 04.80 API. And having the external interface in the mainline would be great not only for Fairwaves, but for the whole Osmocom project and its users. The problem is that the current libosmocore's GSM 04.80 API is not complete and requires some critical modifications, which of course cannot be integrated immediately. Moreover, this implementation doesn't follow Osmocom coding style, for example, unlike other functions, where return code rc = 0 means success, there it means error... So, first of all, we need to know, how many projects are using the current API, especially non-Osmocom projects. After that (taking it into account), it shall be decided: - Should we keep the old API / ABI and maintain all new features among with it. This way would force us to duplicate the existing code and use different symbols. Then the old API would continuously became deprecated... - Should we make all the critical changes in the current API (increasing the libosmocore version?). This way would break builds of dependent projects and would suppose fixing compatibility with the new API. But, at the same time, the implementation would be cleaner and closer to the specification, without any deprecated duplication... Personally, I prefer the second way. At the same time, I want to make the modification as much transparent as possible. Speaking about Osmocom projects, the only users of the GSM 04.80 API are OsmoMSC and legacy OsmoNiTB. Both projects utilize it for '*#100#' handling only :/ To be more convincing, let's look at the following code: #define MAX_LEN_USSD_STRING 31 struct ss_request { uint8_t opcode; uint8_t ss_code; uint8_t ussd_text[MAX_LEN_USSD_STRING + 1]; uint8_t transaction_id; uint8_t invoke_id; }; This is what the current API allows you to obtain from a SS-request (e.g. '*#100#') coming from user. And what's wrong here? - The 'ss_request' doesn't indicate a part of the library it comes from. Would be better to use 'gsm0480_ss_request'. - The 'ussd_text' length doesn't follow the specification, where USSD OCTET STRING length is 160 bytes. So, the amount of characters depends on used coding scheme. - The information about SS-message type, component type, text length and used DCS (Data Coding Scheme), etc. is missing. Despite it could be important for the external application. So, let's discuss together all the 'pros and cons', and decide together, how should we facilitate the external USSD interface development. With best regards, Vadim Yanitskiy.

7 years, 5 months

osmo-bsc_nat dropped in unrelated patch

by Neels Hofmeyr

Hi dexter, reading a commit of yours apparently merged to osmo-bsc in November, I notice that you "secretly sneaked in" this: diff --git a/src/Makefile.am b/src/Makefile.am index d04f025..dd1ad3d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -33,5 +33,4 @@ SUBDIRS += \ utils \ ipaccess \ osmo-bsc \ - osmo-bsc_nat \ $(NULL) in a patch that was supposed to "mgcp: use osmo-mgw to switch RTP streams". http://git.osmocom.org/osmo-bsc/commit/?id=39c609b7c924524172ad311bdf89f92b… So since we merged that patch, osmo-bsc_nat is no longer part of the osmo-bsc build. That's certainly not intended, is it? Confirm and please fix that. thx! ~N

7 years, 5 months

USRP2 and OsmoTRX

by Rafael Diniz

Hi people, I'm doing some tests with an old USRP2 + RF900 daughterboard, and I get a very unstable system (with osmo-trx, osmo-bts-trx and osmo-nitb) - some phones can connect, some dont. I'd like to identify the problem - is it a bad GBit ethernet or the lack of a GPSDO connected to the 10MHz port? Here is osmo-trx startup: +++ Info: SSE3 support compiled in and supported by CPU Info: SSE4.1 support compiled in and supported by CPU Config Settings Log Level............... DEBUG Device args............. TRX Base Port........... 5700 TRX Address............. 127.0.0.1 GSM Core Address.........127.0.0.1 Channels................ 1 Tx Samples-per-Symbol... 4 Rx Samples-per-Symbol... 1 EDGE support............ Disabled Reference............... Internal C0 Filler Table......... Disabled Multi-Carrier........... Disabled Tuning offset........... 0 RSSI to dBm offset...... 0 Swap channels........... 0 INFO 140529100949376 09:57:53.4 UHDDevice.cpp:623:open: Using discovered UHD device type=usrp2,addr=192.168.10.2,name=,serial=024N11043 -- Opening a USRP2/N-Series device... -- Current recv frame size: 1472 bytes -- Current send frame size: 1472 bytes INFO 140529100949376 09:57:54.6 UHDDevice.cpp:441:set_rates: Rates configured for N2XX 4/1 Tx/Rx SPS INFO 140529100949376 09:57:54.7 UHDDevice.cpp:401:init_gains: Supported Tx gain range [0; 0] INFO 140529100949376 09:57:54.7 UHDDevice.cpp:406:init_gains: Supported Rx gain range [0; 70] INFO 140529100949376 09:57:54.7 UHDDevice.cpp:410:init_gains: Default setting Tx gain for channel 0 to 0 INFO 140529100949376 09:57:54.7 UHDDevice.cpp:417:init_gains: Default setting Rx gain for channel 0 to 35 INFO 140529100949376 09:57:54.7 UHDDevice.cpp:712:open: Single USRP: Device: USRP2 / N-Series Device Mboard 0: USRP2 r4 RX Channel: 0 RX DSP: 0 RX Dboard: A RX Subdev: RFX900 RX TX Channel: 0 TX DSP: 0 TX Dboard: A TX Subdev: RFX900 TX -- Transceiver active with 1 channel(s) +++ From osmo-trx I get millions of messages: +++ DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.1 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 7:1142324 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 0:1142349 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 0:1142325 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 1:1142349 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 2:1142349 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 3:1142349 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 4:1142349 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 5:1142349 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 6:1142349 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 7:1142349 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 2:1142325 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 4:1142325 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 6:1142325 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 7:1142325 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 0:1142350 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 0:1142326 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 1:1142350 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 2:1142350 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 3:1142350 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 4:1142350 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 5:1142350 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 6:1142350 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 7:1142350 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 2:1142326 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 4:1142326 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 6:1142326 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 7:1142326 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 0:1142351 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 0:1142327 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 1:1142351 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 2:1142351 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 3:1142351 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 4:1142351 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 5:1142351 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 6:1142351 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 7:1142351 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 3:1142327 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 4:1142327 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 6:1142327 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 7:1142327 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 0:1142352 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 1:1142352 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 0:1142328 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 2:1142352 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 3:1142352 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 4:1142352 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 5:1142352 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 6:1142352 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 7:1142352 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 3:1142328 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 4:1142328 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 6:1142328 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 7:1142328 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 0:1142353 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 1:1142353 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 0:1142329 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 2:1142353 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 3:1142353 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 4:1142353 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 5:1142353 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 6:1142353 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 7:1142353 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 3:1142329 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 4:1142329 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 6:1142329 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 7:1142329 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 0:1142354 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 1:1142354 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 2:1142354 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 3:1142354 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 0:1142330 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 4:1142354 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 5:1142354 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 6:1142354 DEBUG 140529099826944 10:02:27.4 Transceiver.cpp:852:driveTxPriorityQueue: rcvd. burst at: 7:1142354 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 3:1142330 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 4:1142330 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:946:readSamples: Received timestamp = 32693.2 DEBUG 140529101072128 10:02:27.4 Transceiver.cpp:960:driveTxFIFO: radio clock 6:1142330 DEBUG 140529101039360 10:02:27.4 UHDDevice.cpp:902:readSamples: Requested timestamp = 32693.2 +++ and from osmo-bts-trx: +++ (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127677/850/05/16/45 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127677/850/05/16/45 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127683/850/11/22/03 (bts=0,trx=0,ts=0) SDCCH/4(0): PH-RTS.ind: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:418 1127683/850/11/22/03 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:480 1127714/850/16/02/34 (bts=0,trx=0,ts=0) BCCH: PH-RTS.ind: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:418 1127714/850/16/02/34 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:480 1127718/850/20/06/38 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127718/850/20/06/38 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127724/850/00/12/44 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127724/850/00/12/44 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127728/850/04/16/48 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127728/850/04/16/48 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127734/850/10/22/02 (bts=0,trx=0,ts=0) SDCCH/4(0): PH-RTS.ind: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:418 1127734/850/10/22/02 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:480 1127754/850/04/42/22 (bts=0,trx=0,ts=0) SACCH/4(0): PH-RTS.ind: chan_nr=0x20 link_id=0x40 <0007> scheduler.c:418 1127754/850/04/42/22 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x20 link_id=0x40 <0007> scheduler.c:480 1127765/850/15/02/33 (bts=0,trx=0,ts=0) BCCH: PH-RTS.ind: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:418 1127765/850/15/02/33 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:480 1127769/850/19/06/37 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127769/850/19/06/37 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0006> scheduler_trx.c:1619 TRX Clock Ind: elapsed_us= 997110, elapsed_fn=217, error_us=-4345 <0006> scheduler_trx.c:1637 GSM clock jitter: 3322 us (elapsed_fn=1) <0007> scheduler.c:480 1127775/850/25/12/43 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127775/850/25/12/43 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0006> scheduler_trx.c:1660 We were 1 FN slower than TRX, compensated <0007> scheduler.c:480 1127779/850/03/16/47 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127779/850/03/16/47 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127785/850/09/22/01 (bts=0,trx=0,ts=0) SDCCH/4(0): PH-RTS.ind: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:418 1127785/850/09/22/01 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:480 1127816/850/14/02/32 (bts=0,trx=0,ts=0) BCCH: PH-RTS.ind: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:418 1127816/850/14/02/32 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:480 1127820/850/18/06/36 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127820/850/18/06/36 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127826/850/24/12/42 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127826/850/24/12/42 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127830/850/02/16/46 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127830/850/02/16/46 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127836/850/08/22/00 (bts=0,trx=0,ts=0) SDCCH/4(0): PH-RTS.ind: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:418 1127836/850/08/22/00 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:480 1127856/850/02/42/20 (bts=0,trx=0,ts=0) SACCH/4(0): PH-RTS.ind: chan_nr=0x20 link_id=0x40 <0007> scheduler.c:418 1127856/850/02/42/20 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x20 link_id=0x40 <0007> scheduler.c:480 1127867/850/13/02/31 (bts=0,trx=0,ts=0) BCCH: PH-RTS.ind: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:418 1127867/850/13/02/31 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:480 1127871/850/17/06/35 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127871/850/17/06/35 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127877/850/23/12/41 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127877/850/23/12/41 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127881/850/01/16/45 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127881/850/01/16/45 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127887/850/07/22/51 (bts=0,trx=0,ts=0) SDCCH/4(0): PH-RTS.ind: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:418 1127887/850/07/22/51 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:480 1127918/850/12/02/30 (bts=0,trx=0,ts=0) BCCH: PH-RTS.ind: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:418 1127918/850/12/02/30 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:480 1127922/850/16/06/34 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127922/850/16/06/34 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127928/850/22/12/40 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127928/850/22/12/40 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127932/850/00/16/44 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127932/850/00/16/44 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127938/850/06/22/02 (bts=0,trx=0,ts=0) SDCCH/4(0): PH-RTS.ind: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:418 1127938/850/06/22/02 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:480 1127958/850/00/42/22 (bts=0,trx=0,ts=0) SACCH/4(0): PH-RTS.ind: chan_nr=0x20 link_id=0x40 <0007> scheduler.c:418 1127958/850/00/42/22 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x20 link_id=0x40 <0007> scheduler.c:480 1127969/850/11/02/33 (bts=0,trx=0,ts=0) BCCH: PH-RTS.ind: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:418 1127969/850/11/02/33 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:480 1127973/850/15/06/37 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127973/850/15/06/37 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127979/850/21/12/43 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127979/850/21/12/43 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127983/850/25/16/47 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1127983/850/25/16/47 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:480 1127989/850/05/22/01 (bts=0,trx=0,ts=0) SDCCH/4(0): PH-RTS.ind: chan_nr=0x20 link_id=0x00 <0007> scheduler.c:418 1127989/850/05/22/01 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x20 link_id=0x00 <0006> scheduler_trx.c:1619 TRX Clock Ind: elapsed_us= 998173, elapsed_fn=216, error_us=+1333 <0006> scheduler_trx.c:1637 GSM clock jitter: -2537 us (elapsed_fn=0) <0000> rsl.c:2458 (bts=0,trx=0,ts=0,ss=0) Rx RSL DEACTIVATE_SACCH <0006> l1sap.c:1394 deactivating sacch chan_nr=0x20 trx=0 <0006> scheduler.c:1383 Deactivating SACCH/4(0) on trx=0 ts=0 <0000> rsl.c:2458 (bts=0,trx=0,ts=0,ss=0) Rx RSL RF_CHAN_REL <0006> l1sap.c:1378 deactivating channel chan_nr=0x20 trx=0 <0006> scheduler.c:1383 Deactivating SDCCH/4(0) on trx=0 ts=0 <0006> l1sap.c:602 deactivate confirm chan_nr=0x20 trx=0 <0000> rsl.c:580 (bts=0,trx=0,ts=0,ss=0) Tx RF CHAN REL ACK <0007> scheduler.c:480 1128020/850/10/02/32 (bts=0,trx=0,ts=0) BCCH: PH-RTS.ind: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:418 1128020/850/10/02/32 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0x80 link_id=0x00 <0007> scheduler.c:480 1128024/850/14/06/36 (bts=0,trx=0,ts=0) CCCH: PH-RTS.ind: chan_nr=0x90 link_id=0x00 <0007> scheduler.c:418 1128024/850/14/06/36 (bts=0,trx=0,ts=0) : PH-DATA.req: chan_nr=0 +++ From NITB: +++ Mon Jan 15 10:04:11 2018 <0005> abis_nm.c:507 BTS0 feature 'EGPRS' reported via OML does not match statically set feature: 0 != 1. Please fix. Mon Jan 15 10:04:11 2018 <0005> abis_nm.c:507 BTS0 feature 'OML Alerts' reported via OML does not match statically set feature: 1 != 0. Please fix. Mon Jan 15 10:04:11 2018 <0005> abis_nm.c:573 BTS0: ARI reported sw[0/2]: sysmobts is 0.7.0.20180114 Mon Jan 15 10:04:11 2018 <0005> abis_nm.c:446 BTS0 reported variant: omso-bts-trx Mon Jan 15 10:04:11 2018 <0005> abis_nm.c:468 BTS0 Attribute Manufacturer Dependent State is unreported Mon Jan 15 10:04:11 2018 <0005> abis_nm.c:573 BTS0: ARI reported sw[0/1]: TRX_PHY_VERSION is Unknown +++ And after some time, osmo-trx stops reading samples from UHD and osmo-bts-trx shuts down. Thanks, Rafael Diniz

7 years, 5 months

osmo-trx test setup & convolve_test failures on different machines

by Pau Espin Pedrol

Hi everybody, as some of you may have noticed due to the generated noise in gerrit ml during last days, I have been adding some autotest setup to osmo-trx in order to have several tests being run during gerrit review. Since osmo-trx has some specific code built with NEON instructions, I also added some infrastructure to jenkin.sh to generate and use a prebuilt debian armhf rootfs so we can easily build and run tests using qemu-arm from our local workstations or from jenkins slaves, which will check that support for those architectures doesn't become broken. In order to set up the make check tests, I re-used existing tests and moved them to the tests/ directory. I also moved utils/convolvtest/main.c into "tests/Transceiver52M/convolve_test" [1] to become a test that checks "convolve_{real,complex}" APIs. I noticed, however, that this test prints slightly (or not that slightly) different outputs on different machine architectures, which of course make tests fail as it matches the exact values. So far the output is different in my x86_64 workstation, my i686 netbook (or i586 OBS host) and in my qemu-arm (armhf). As each machine uses different instructions sets, I indeed can understand that there appear small differences due to floating operations and rounding, but sometimes I can see relatively big difference between one implementation and the other one (eg 7.032490 vs 6.655972). I'm thinking about modifying the test to, instead of matching the output exactly, check that for each value in the vector it is similar to a value with a maximum epsilon distance from a reference vector. However, as I don't have any knowledge regarding the maths and theory behind the convolution codes, I must admit I am not sure which epsilon should I be using, or which should be the expected output for the test. It may perhaps make sense to have separate reference output for different architectures, I don't know. Can somebody shed some light on this topic? Any advise or hint is welcome. It would also be nice to have some tests for the "convert" API, which uses optimized instructions sets too. If somebody wants to provide those or any hint on how to implement them that's going to be handy. All the test infrastructure is merged now, only the patch adding the qemu part is not merged but already working in [2], I'll merge it tomorrow if nobody is angry with it. You can find related output for the test I was speaking of for different machine arch (x86_64, i686, arm) in [3] and [4]. [1]https://git.osmocom.org/osmo-trx/tree/tests/Transceiver52M/convolve_test.c [2] https://gerrit.osmocom.org/#/c/5763 [3] https://osmocom.org/issues/2826 [4] https://osmocom.org/issues/2828 -- - Pau Espin Pedrol <pespin(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

7 years, 5 months

Re: [osmocom/gr-osmosdr] Sdrplay2 (#12)

by Neels Hofmeyr

The github robot is still telling people to submit patches on the mailing lists. Can we please change that message to link to this wiki page instead? http://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards#S… Thanks! ~N On Fri, Jan 12, 2018 at 09:17:53AM -0800, tsaitgaist wrote: > GitHub is only used to mirror [osmocom projects](http://git.osmocom.org/). Please use the [mailing lists](https://lists.osmocom.org/mailman/listinfo) to [submit patches](http://projects.osmocom.org/projects/cellular-infrastructure/wiki/…. > > -- > You are receiving this because you are subscribed to this thread. > Reply to this email directly or view it on GitHub: > https://github.com/osmocom/gr-osmosdr/pull/12#issuecomment-357299416

7 years, 5 months

Re: New Defects reported by Coverity Scan for Osmocom

by Neels Hofmeyr

The hnbgw ones are my fault, am a bit puzzled that they took this long to show up in coverity. ~N On Sat, Jan 13, 2018 at 04:26:56PM +0000, scan-admin(a)coverity.com wrote: > > Hi, > > Please find the latest report on new defect(s) introduced to Osmocom found with Coverity Scan. > > 6 new defect(s) introduced to Osmocom found with Coverity Scan. > 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. > > New defect(s) Reported-by: Coverity Scan > Showing 6 of 6 defect(s) > > > ** CID 181969: (UNINIT) > /source-Osmocom/osmo-iuh/src/hnbgw_rua.c: 218 in rua_to_scu() > /source-Osmocom/osmo-iuh/src/hnbgw_rua.c: 274 in rua_to_scu() > > > ________________________________________________________________________________________________________ > *** CID 181969: (UNINIT) > /source-Osmocom/osmo-iuh/src/hnbgw_rua.c: 218 in rua_to_scu() > 212 > 213 prim = (struct osmo_scu_prim *) msgb_put(msg, sizeof(*prim)); > 214 osmo_prim_init(&prim->oph, SCCP_SAP_USER, type, PRIM_OP_REQUEST, msg); > 215 > 216 switch (type) { > 217 case OSMO_SCU_PRIM_N_UNITDATA: > >>> CID 181969: (UNINIT) > >>> Using uninitialized value "map". > 218 DEBUGP(DRUA, "rua_to_scu() %s to %s, rua_ctx_id %u (unitdata, no scu_conn_id)\n", > 219 cn_domain_indicator_to_str(cN_DomainIndicator), > 220 osmo_sccp_addr_dump(remote_addr), > 221 map->rua_ctx_id); > 222 break; > 223 default: > /source-Osmocom/osmo-iuh/src/hnbgw_rua.c: 274 in rua_to_scu() > 268 msg->l2h = msgb_put(msg, len); > 269 memcpy(msg->l2h, data, len); > 270 } > 271 > 272 rc = osmo_sccp_user_sap_down(cn->sccp_user, &prim->oph); > 273 > >>> CID 181969: (UNINIT) > >>> Using uninitialized value "map". > 274 if (map && release_context_map) > 275 context_map_deactivate(map); > 276 > 277 return rc; > 278 } > 279 > > ** CID 181968: Uninitialized variables (UNINIT) > /source-Osmocom/osmo-iuh/src/hnbgw_cn.c: 219 in _cn_ranap_rx() > > > ________________________________________________________________________________________________________ > *** CID 181968: Uninitialized variables (UNINIT) > /source-Osmocom/osmo-iuh/src/hnbgw_cn.c: 219 in _cn_ranap_rx() > 213 default: > 214 LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " > 215 "presence %u from CN, ignoring\n", pdu->present); > 216 break; > 217 } > 218 > >>> CID 181968: Uninitialized variables (UNINIT) > >>> Using uninitialized value "rc". > 219 return rc; > 220 } > 221 > 222 static int handle_cn_ranap(struct hnbgw_cnlink *cnlink, const uint8_t *data, > 223 unsigned int len) > 224 { > > ** CID 181967: Security best practices violations (DC.WEAK_CRYPTO) > /source-Osmocom/osmo-trx/tests/Transceiver52M/convolve_test.c: 22 in gen_floats() [...] > *** CID 135219: API usage errors (PW.PRINTF_ARG_MISMATCH) > /source-Osmocom/osmo-iuh/src/hnbgw_rua.c: 201 in () > 195 break; > 196 case RUA_CN_DomainIndicator_ps_domain: > 197 remote_addr = &hnb->gw->sccp.iups_remote_addr; > 198 is_ps = true; > 199 break; > 200 default: > >>> CID 135219: API usage errors (PW.PRINTF_ARG_MISMATCH) > >>> argument is incompatible with corresponding format string conversion > 201 LOGP(DRUA, LOGL_ERROR, "Unsupported Domain %u\n", > 202 cN_DomainIndicator); > 203 return -1; > 204 } > 205 > 206 if (!cn) { > > ** CID 57733: Uninitialized variables (MISSING_RETURN) > /source-Osmocom/osmo-iuh/src/hnbgw_hnbap.c: 531 in hnbgw_rx_unsuccessful_outcome_msg() > > > ________________________________________________________________________________________________________ > *** CID 57733: Uninitialized variables (MISSING_RETURN) > /source-Osmocom/osmo-iuh/src/hnbgw_hnbap.c: 531 in hnbgw_rx_unsuccessful_outcome_msg() > 525 > 526 } > 527 > 528 static int hnbgw_rx_unsuccessful_outcome_msg(struct hnb_context *hnb, UnsuccessfulOutcome_t *msg) > 529 { > 530 > >>> CID 57733: Uninitialized variables (MISSING_RETURN) > >>> Arriving at the end of a function without returning a value. > 531 } > 532 > 533 > 534 static int _hnbgw_hnbap_rx(struct hnb_context *hnb, HNBAP_PDU_t *pdu) > 535 { > 536 int rc = 0; > > ** CID 57732: Uninitialized variables (MISSING_RETURN) > /source-Osmocom/osmo-iuh/src/hnbgw_hnbap.c: 526 in hnbgw_rx_successful_outcome_msg() > > > ________________________________________________________________________________________________________ > *** CID 57732: Uninitialized variables (MISSING_RETURN) > /source-Osmocom/osmo-iuh/src/hnbgw_hnbap.c: 526 in hnbgw_rx_successful_outcome_msg() > 520 return rc; > 521 } > 522 > 523 static int hnbgw_rx_successful_outcome_msg(struct hnb_context *hnb, SuccessfulOutcome_t *msg) > 524 { > 525 > >>> CID 57732: Uninitialized variables (MISSING_RETURN) > >>> Arriving at the end of a function without returning a value. > 526 } > 527 > 528 static int hnbgw_rx_unsuccessful_outcome_msg(struct hnb_context *hnb, UnsuccessfulOutcome_t *msg) > 529 { > 530 > 531 } > > > ________________________________________________________________________________________________________ > To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… > > To manage Coverity Scan email notifications for "nhofmeyr(a)sysmocom.de", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… > -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte

7 years, 5 months

Re: Auto create subscribers on OpenBSC

by Sandi Suhendro

Ahh ok. Im so stupid not really mean with a simple english. Thanks Neels. DUO On Jan 15, 2018 6:57 PM, "Neels Hofmeyr" <nhofmeyr(a)sysmocom.de> wrote: > here is the config https://pastebin.com/BKcPUbzb Prepend a 'no' to disable it: nitb no subscriber-create-on-demand ~N

7 years, 5 months

Auto create subscribers on OpenBSC

by Sandi Suhendro

Any idea how to make : auto create subscriber = no ?? tried subscriber-create-on-demand but the DB subscriber still auto create. Thanks. DUO

7 years, 5 months

OSMONITB 3G and ROAMING roaming with other operator

by Radiarisainana Sitraka

Hello,Is the osmonitb3G have capabilities to roam with the existing operator in the world!? And, is it possible to launch call and sms to some existing operator !? Chears,

7 years, 5 months

Build failed in Jenkins: Coverity-Upload » linux_amd64_debian8 #1729

by jenkins＠lists.osmocom.org

See <http://jenkins.osmocom.org/jenkins/job/Coverity-Upload/label=linux_amd64_de…> ------------------------------------------ [...truncated 2.14 MB...] make[4]: Nothing to be done for 'install-exec-am'. make[4]: Nothing to be done for 'install-data-am'. make[4]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh/doc' make[3]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh/doc' make[2]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh/doc' make[2]: Entering directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh' make[3]: Entering directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh' make[3]: Nothing to be done for 'install-exec-am'. /bin/mkdir -p '/home/osmocom-build/osmo-ci/coverity/install-Osmocom/lib/pkgconfig' /usr/bin/install -c -m 644 libosmo-ranap.pc '/home/osmocom-build/osmo-ci/coverity/install-Osmocom/lib/pkgconfig' make[3]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh' make[2]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh' make[1]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-iuh' + popd ~/osmo-ci/coverity/source-Osmocom + build_osmopcu + pushd osmo-pcu ~/osmo-ci/coverity/source-Osmocom/osmo-pcu ~/osmo-ci/coverity/source-Osmocom + do_build --enable-sysmocom-bts=yes --enable-sysmocom-dsp=yes + autoreconf --install --force libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `.'. libtoolize: copying file `./ltmain.sh' libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree. libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am. configure.ac:21: installing './compile' configure.ac:24: installing './config.guess' configure.ac:24: installing './config.sub' configure.ac:9: installing './install-sh' configure.ac:9: installing './missing' src/Makefile.am: installing './depcomp' tests/Makefile.am:13: warning: source file 'alloc/AllocTest.cpp' is in a subdirectory, tests/Makefile.am:13: but option 'subdir-objects' is disabled automake: warning: possible forward-incompatibility. automake: At least a source file is in a subdirectory, but the 'subdir-objects' automake: automake option hasn't been enabled. For now, the corresponding output automake: object file(s) will be placed in the top-level directory. However, automake: this behaviour will change in future Automake versions: they will automake: unconditionally cause object files to be placed in the same subdirectory automake: of the corresponding sources. automake: You are advised to start using 'subdir-objects' option throughout your automake: project, to avoid future incompatibilities. tests/Makefile.am:29: warning: source file 'bitcomp/BitcompTest.cpp' is in a subdirectory, tests/Makefile.am:29: but option 'subdir-objects' is disabled tests/Makefile.am:29: warning: source file '../src/egprs_rlc_compression.cpp' is in a subdirectory, tests/Makefile.am:29: but option 'subdir-objects' is disabled tests/Makefile.am:88: warning: source file 'codel/codel_test.c' is in a subdirectory, tests/Makefile.am:88: but option 'subdir-objects' is disabled tests/Makefile.am:35: warning: source file 'edge/EdgeTest.cpp' is in a subdirectory, tests/Makefile.am:35: but option 'subdir-objects' is disabled tests/Makefile.am:43: warning: source file 'emu/pcu_emu.cpp' is in a subdirectory, tests/Makefile.am:43: but option 'subdir-objects' is disabled tests/Makefile.am:43: warning: source file 'emu/test_replay_gprs_attach.cpp' is in a subdirectory, tests/Makefile.am:43: but option 'subdir-objects' is disabled tests/Makefile.am:43: warning: source file 'emu/openbsc_clone.c' is in a subdirectory, tests/Makefile.am:43: but option 'subdir-objects' is disabled tests/Makefile.am:43: warning: source file 'emu/test_pdp_activation.cpp' is in a subdirectory, tests/Makefile.am:43: but option 'subdir-objects' is disabled tests/Makefile.am:94: warning: source file 'fn/FnTest.cpp' is in a subdirectory, tests/Makefile.am:94: but option 'subdir-objects' is disabled tests/Makefile.am:72: warning: source file 'llc/LlcTest.cpp' is in a subdirectory, tests/Makefile.am:72: but option 'subdir-objects' is disabled tests/Makefile.am:83: warning: source file 'llist/LListTest.cpp' is in a subdirectory, tests/Makefile.am:83: but option 'subdir-objects' is disabled tests/Makefile.am:61: warning: source file 'ms/MsTest.cpp' is in a subdirectory, tests/Makefile.am:61: but option 'subdir-objects' is disabled tests/Makefile.am:7: warning: source file 'rlcmac/RLCMACTest.cpp' is in a subdirectory, tests/Makefile.am:7: but option 'subdir-objects' is disabled tests/Makefile.am:21: warning: source file 'tbf/TbfTest.cpp' is in a subdirectory, tests/Makefile.am:21: but option 'subdir-objects' is disabled tests/Makefile.am:53: warning: source file 'types/TypesTest.cpp' is in a subdirectory, tests/Makefile.am:53: but option 'subdir-objects' is disabled + ./configure --prefix=/home/osmocom-build/osmo-ci/coverity/install-Osmocom --enable-sysmocom-bts=yes --enable-sysmocom-dsp=yes configure: WARNING: unrecognized options: --enable-sysmocom-bts checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking whether make supports nested variables... (cached) yes checking whether make sets $(MAKE)... (cached) yes checking for gcc... gcc checking whether the C compiler works... yes checking for C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ISO C89... none needed checking whether gcc understands -c and -o together... yes checking for style of include used by make... GNU checking dependency style of gcc... gcc3 checking for g++... g++ checking whether we are using the GNU C++ compiler... yes checking whether g++ accepts -g... yes checking dependency style of g++... gcc3 checking build system type... x86_64-unknown-linux-gnu checking host system type... x86_64-unknown-linux-gnu checking how to print strings... printf checking for a sed that does not truncate output... /bin/sed checking for grep that handles long lines and -e... /bin/grep checking for egrep... /bin/grep -E checking for fgrep... /bin/grep -F checking for ld used by gcc... /usr/bin/ld checking if the linker (/usr/bin/ld) is GNU ld... yes checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B checking the name lister (/usr/bin/nm -B) interface... BSD nm checking whether ln -s works... yes checking the maximum length of command line arguments... 1572864 checking whether the shell understands some XSI constructs... yes checking whether the shell understands "+="... yes checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop checking for /usr/bin/ld option to reload object files... -r checking for objdump... objdump checking how to recognize dependent libraries... pass_all checking for dlltool... no checking how to associate runtime and link libraries... printf %s\n checking for ar... ar checking for archiver @FILE support... @ checking for strip... strip checking for ranlib... ranlib checking command to parse /usr/bin/nm -B output from gcc object... ok checking for sysroot... no checking for mt... mt checking if mt is a manifest tool... no checking how to run the C preprocessor... gcc -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking for dlfcn.h... yes checking for objdir... .libs checking if gcc supports -fno-rtti -fno-exceptions... no checking for gcc option to produce PIC... -fPIC -DPIC checking if gcc PIC flag -fPIC -DPIC works... yes checking if gcc static flag -static works... yes checking if gcc supports -c -o file.o... yes checking if gcc supports -c -o file.o... (cached) yes checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes checking whether -lc should be explicitly linked in... no checking dynamic linker characteristics... GNU/Linux ld.so checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes checking if libtool supports shared libraries... yes checking whether to build shared libraries... yes checking whether to build static libraries... yes checking how to run the C++ preprocessor... g++ -E checking for ld used by g++... /usr/bin/ld -m elf_x86_64 checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes checking for g++ option to produce PIC... -fPIC -DPIC checking if g++ PIC flag -fPIC -DPIC works... yes checking if g++ static flag -static works... yes checking if g++ supports -c -o file.o... yes checking if g++ supports -c -o file.o... (cached) yes checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes checking dynamic linker characteristics... (cached) GNU/Linux ld.so checking how to hardcode library paths into programs... immediate checking for pkg-config... /usr/bin/pkg-config checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.20... yes checking for ANSI C header files... (cached) yes checking for LIBOSMOCORE... yes checking for LIBOSMOVTY... yes checking for LIBOSMOGSM... yes checking for LIBOSMOGB... yes checking whether to enable direct DSP access for PDCH of sysmocom-bts... yes checking whether to enable direct PHY access for PDCH of NuRAN Wireless Litecell 1.5 BTS... no checking whether to enable VTY tests... no checking that generated files are newer than configure... done configure: creating ./config.status config.status: creating osmo-pcu.pc config.status: creating include/Makefile config.status: creating src/Makefile config.status: creating examples/Makefile config.status: creating tests/Makefile config.status: creating Makefile config.status: executing tests/atconfig commands config.status: executing depfiles commands config.status: executing libtool commands configure: WARNING: unrecognized options: --enable-sysmocom-bts + make -j 3 Making all in include make[1]: Entering directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-pcu/include' make[1]: Nothing to be done for 'all'. make[1]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-pcu/include' Making all in src make[1]: Entering directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-pcu/src' CXX gprs_debug.lo CXX csn1.lo CXX gsm_rlcmac.lo CXX gprs_bssgp_pcu.lo gprs_bssgp_pcu.cpp:967:2: warning: #warning "This causes ASAN to complain. It is not critical for normal operation but should be fixed nevertheless" [-Wcpp] #warning "This causes ASAN to complain. It is not critical for normal operation but should be fixed nevertheless" ^ gprs_bssgp_pcu.cpp:76:12: warning: 'int parse_ra_cap(tlv_parsed*, MS_Radio_Access_capability_t*)' defined but not used [-Wunused-function] static int parse_ra_cap(struct tlv_parsed *tp, MS_Radio_Access_capability_t *rac) ^ CXX gprs_rlcmac.lo CXX gprs_rlcmac_sched.lo CXX gprs_rlcmac_meas.lo CXX gprs_rlcmac_ts_alloc.lo CXX gprs_ms.lo CXX gprs_ms_storage.lo CXX gsm_timer.lo CXX pcu_l1_if.lo CC pcu_vty.lo CXX pcu_vty_functions.lo CC mslot_class.lo CXX tbf.lo In file included from bts.h:37:0, from pcu_vty_functions.cpp:26: tbf.h: In function 'void tbf_print_vty_info(vty*, gprs_rlcmac_tbf*)': tbf.h:623:21: error: 'gprs_rlc_ul_window gprs_rlcmac_ul_tbf::m_window' is protected gprs_rlc_ul_window m_window; ^ pcu_vty_functions.cpp:70:38: error: within this context gprs_rlc_ul_window *win = &ul_tbf->m_window; ^ In file included from bts.h:37:0, from pcu_vty_functions.cpp:26: tbf.h:562:21: error: 'gprs_rlc_dl_window gprs_rlcmac_dl_tbf::m_window' is protected gprs_rlc_dl_window m_window; ^ pcu_vty_functions.cpp:82:38: error: within this context gprs_rlc_dl_window *win = &dl_tbf->m_window; ^ Makefile:763: recipe for target 'pcu_vty_functions.lo' failed make[1]: *** [pcu_vty_functions.lo] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/osmo-pcu/src' Makefile:448: recipe for target 'all-recursive' failed make: *** [all-recursive] Error 1 [WARNING] Build command ./build_Osmocom.sh exited with code 2. Please verify that the build completed successfully. Emitted 1876 C/C++ compilation units (100%) successfully 1876 C/C++ compilation units (100%) are ready for analysis For more details, please look at: /home/osmocom-build/osmo-ci/coverity/source-Osmocom/cov-int/build-log.txt Build step 'Execute shell' marked build as failure

7 years, 5 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC January 2018