OpenBSC December 2015

openbsc@lists.osmocom.org

17 participants
40 discussions

FYI: gtphub merged
by Neels Hofmeyr 05 Jan '16

05 Jan '16

Hi list, after a code review session between Holger and me, I've now merged the gtphub branch to master, completely. You can't miss the endless sequence of commits that have just come in on master. This is not to say that the code is glorified beyond doubt. Please do review, if you can spare the time. Thanks, ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte

3 6

[PATCH 1/6] msgb: Add msgb_resize_area and msgb_copy
by Jacob Erlbeck 05 Jan '16

05 Jan '16

These functions originate from openbsc/src/gprs but are generic msgb helper functions. msgb_copy: This function allocates a new msgb, copies the data buffer of msg, and adjusts the pointers (incl. l1h-l4h) accordingly. msgb_resize_area: This resizes a sub area of the msgb data and adjusts the pointers (incl. l1h-l4h) accordingly. Sponsored-by: On-Waves ehf --- include/osmocom/core/msgb.h | 3 ++ src/msgb.c | 88 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 91 insertions(+) diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h index 644a639..21e363a 100644 --- a/include/osmocom/core/msgb.h +++ b/include/osmocom/core/msgb.h @@ -74,6 +74,9 @@ extern struct msgb *msgb_dequeue(struct llist_head *queue); extern void msgb_reset(struct msgb *m); uint16_t msgb_length(const struct msgb *msg); extern const char *msgb_hexdump(const struct msgb *msg); +extern int msgb_resize_area(struct msgb *msg, uint8_t *area, + size_t old_size, size_t new_size); +extern struct msgb *msgb_copy(const struct msgb *msg, const char *name); #ifdef MSGB_DEBUG #include <osmocom/core/panic.h> diff --git a/src/msgb.c b/src/msgb.c index b2fe1d2..a257479 100644 --- a/src/msgb.c +++ b/src/msgb.c @@ -153,6 +153,94 @@ void msgb_set_talloc_ctx(void *ctx) tall_msgb_ctx = ctx; } +/*! \brief Copy an msgb. + * + * This function allocates a new msgb, copies the data buffer of msg, + * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part + * is not copied. + * \param[in] msg The old msgb object + * \param[in] name Human-readable name to be associated with msgb + */ +struct msgb *msgb_copy(const struct msgb *msg, const char *name) +{ + struct msgb *new_msg; + + new_msg = msgb_alloc(msg->data_len, name); + if (!new_msg) + return NULL; + + /* copy data */ + memcpy(new_msg->_data, msg->_data, new_msg->data_len); + + /* copy header */ + new_msg->len = msg->len; + new_msg->data += msg->data - msg->_data; + new_msg->head += msg->head - msg->_data; + new_msg->tail += msg->tail - msg->_data; + + if (msg->l1h) + new_msg->l1h = new_msg->_data + (msg->l1h - msg->_data); + if (msg->l2h) + new_msg->l2h = new_msg->_data + (msg->l2h - msg->_data); + if (msg->l3h) + new_msg->l3h = new_msg->_data + (msg->l3h - msg->_data); + if (msg->l4h) + new_msg->l4h = new_msg->_data + (msg->l4h - msg->_data); + + return new_msg; +} + +/*! \brief Resize an area within an msgb + * + * This resizes a sub area of the msgb data and adjusts the pointers (incl + * l1h-l4h) accordingly. The cb part is not updated. If the area is extended, + * the contents of the extension is undefined. The complete sub area must be a + * part of [data,tail]. + * + * \param[inout] msg The msgb object + * \param[in] area A pointer to the sub-area + * \param[in] old_size The old size of the sub-area + * \param[in] new_size The new size of the sub-area + * \returns 0 on success, -1 if there is not enough space to extend the area + */ +int msgb_resize_area(struct msgb *msg, uint8_t *area, + size_t old_size, size_t new_size) +{ + int rc; + uint8_t *rest = area + old_size; + int rest_len = msg->len - old_size - (area - msg->data); + int delta_size = (int)new_size - (int)old_size; + + if (area < msg->data || rest > msg->tail) + MSGB_ABORT(msg, "Sub area is not fully contained in the msg data\n"); + + if (delta_size == 0) + return 0; + + if (delta_size > 0) { + rc = msgb_trim(msg, msg->len + delta_size); + if (rc < 0) + return rc; + } + + memmove(area + new_size, area + old_size, rest_len); + + if (msg->l1h >= rest) + msg->l1h += delta_size; + if (msg->l2h >= rest) + msg->l2h += delta_size; + if (msg->l3h >= rest) + msg->l3h += delta_size; + if (msg->l4h >= rest) + msg->l4h += delta_size; + + if (delta_size < 0) + msgb_trim(msg, msg->len + delta_size); + + return 0; +} + + /*! \brief Return a (static) buffer containing a hexdump of the msg * \param[in] msg message buffer * \returns a pointer to a static char array -- 1.9.1

2 24

libosmocore: broken pybombs installation because of talloc
by Piotr Krysik 31 Dec '15

31 Dec '15

Hi all, libosmocore can't be installed with GNU Radio's pybombs currently. The reason is that libosmocore requires libtalloc which isn't installed automatically by pybombs. Manually the problem can be solved by installing libtalloc-dev package. It would be good to fix the pybombs recipe however. I would do this simply by adding libtalloc-dev to dependencies but I don't know if this is proper solution from your point of view. Can you (libosmocore developers) fix the recipe or tell me how to fix it appropriately? Best Regards, Piotr Krysik

2 1

Problem with RF and states of sysmoBTS
by Diego Fernandez Alonso 28 Dec '15

28 Dec '15

Hi, I have a problem with my sysmoBTS.I restored the system using a sysmocom-recovery.ubi and executing a sysmocom-restore from a backup file .tar. Everything was apparently ok but the RF Active led is switched off, without transmision, and the state of the BTS is not normal. First of all with a serial conexion I received this message: fpgadl: Error: INIT_B LOW during programming and checking the state I get the parameters: OpenBSC> show bts 0 BTS 0 is of nanobts type in band DCS1800, has CI 0 LAC 1, BSIC 63, TSC 7 and 1 TRX Description: (null) MS Max power: 15 dBm Minimum Rx Level for Access: -110 dBm Cell Reselection Hysteresis: 4 dBm RACH TX-Integer: 9 RACH Max transmissions: 7 Channel Description Attachment: yes Channel Description BS-PA-MFRMS: 5 Channel Description BS-AG_BLKS-RES: 1 System Information present: 0x00000000, static: 0x00000000 Unit ID: 1801/0/0, OML Stream ID 0xff NM State: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' Site Mgr NM State: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' GPRS NSE: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' GPRS CELL: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' GPRS NSVC0: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' GPRS NSVC1: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' Paging: 0 pending requests, 20 free slots OML Link state: disconnected. Current Channel Load: OpenBSC> OpenBSC> show trx 0 0 TRX 0 of BTS 0 is on ARFCN 514 Description: (null) RF Nominal Power: 23 dBm, reduced by 20 dB, resulting BS power: 3 dBm NM State: Oper 'NULL', Admin 'Unlocked', Avail 'Power off' Baseband Transceiver NM State: Oper 'NULL', Admin 'unknown 0x0', Avail 'Power off' ip.access stream ID: 0x00 OpenBSC> I would be very grateful for some idea for recovering the states to 'Enable' Thanks so much. Diego.

2 1

PCU-Testing at CCC
by Jacob Erlbeck 26 Dec '15

26 Dec '15

Hi, it would be great to do some PCU testing at the congress. Branch: jerlbeck/master PCU Configuration: example config NITB/BSC Configuration: At least 2 adjacent PDCH Interesting VTY commands - show tbf all - show ms all - show ms imsi SOME_IMSI Other things to look at: - PCU load (CPU) Please keep me informed on how it works. I'll be able to investigate or fix things on Mon and Tue (and maybe on Sun). Thanks and have fun Jacob -- - Jacob Erlbeck <jerlbeck(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

1 0

Wiki update for B2x0 series
by Sipos Csaba 26 Dec '15

26 Dec '15

Dear list, As of today, I revised and updated the Wiki page for Ettus SDRs. https://openbsc.osmocom.org/trac/wiki/Ettus_USRP_B2xx_family What is tested: - Voice calls (MO and MT with full rate) - Interconnect with Asterisk (voice call routing and interconnecting GSM calls to SIP or other telephony technologies) - SMS (MO and MT) - GPRS What needs to be tested: - Voice calls with half rate and AMR If someone can go through it and revise it, that would be nice. Regards, Csaba

1 0

Osmo-PCU: make error
by Sipos Csaba 26 Dec '15

26 Dec '15

Dear Jacob, Today I started to update my setup to latest master for all the Osmocom projects and hit a compile error with Osmo-PCU: root@D6420:~/newer_osmocom/osmo-pcu# make Making all in src make[1]: Entering directory `/root/newer_osmocom/osmo-pcu/src' CXX gprs_debug.lo CXX csn1.lo CXX gsm_rlcmac.lo CXX gprs_bssgp_pcu.lo In file included from /usr/local/include/osmocom/gsm/prim.h:3:0, from /usr/local/include/osmocom/gprs/gprs_bssgp.h:8, from ./gprs_bssgp_pcu.h:32, from gprs_bssgp_pcu.cpp:22: /usr/local/include/osmocom/core/prim.h:23:27: error: uninitialized const 'osmo_prim_op_names' [-fpermissive] const struct value_string osmo_prim_op_names[5]; ^ In file included from /usr/local/include/osmocom/core/msgb.h:24:0, from /usr/local/include/osmocom/gprs/gprs_ns.h:8, from ./gprs_bssgp_pcu.h:31, from gprs_bssgp_pcu.cpp:22: /usr/local/include/osmocom/core/utils.h:22:8: note: 'const struct value_string' has no user-provided default constructor struct value_string { ^ /usr/local/include/osmocom/core/utils.h:23:15: note: and the implicitly-defined constructor does not initialize 'unsigned int value_string::value' unsigned int value; /*!< \brief numeric value */ ^ make[1]: *** [gprs_bssgp_pcu.lo] Error 1 make[1]: Leaving directory `/root/newer_osmocom/osmo-pcu/src' make: *** [all-recursive] Error 1 I can see that you moving some parts from openbsc to the core library, probably that process is not yet finsihed (or merged to master) and that is causing this problem. Just wanted to give some feedback and notify the list about this. Regards, Csaba

2 3

[PATCH] fix format warnings added by 86ec3118
by Neels Hofmeyr 24 Dec '15

24 Dec '15

Commit 86ec3118 ("msgb: Let msgb_hexdump be more tolerant") added new format warnings to my 64bit build of libosmocore. It's not a pressing matter, really, but the libosmocore build is otherwise clean of such warnings so it'd be nice to keep it that way. This patch fixes the warnings by using PRIdPTR. That seems to be the Correct Way to fix it, but I'm a bit unsure. Thanks for any thoughts! Neels Hofmeyr (1): Fix some recently added formats on 64bit src/msgb.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.1.4

2 2

(no subject)
by Alexander Huemer 24 Dec '15

24 Dec '15

Hi. This patch is for osmo-iuh. Without it the build only works on machines that have the needed headers in the default search path for includes. Otherwise the build fails like this: > gcc -DPACKAGE_NAME=\"osmo-iuh\" -DPACKAGE_TARNAME=\"osmo-iuh\" -DPACKAGE_VERSION=\"0.0\" -DPACKAGE_STRING=\"osmo-iuh\ 0.0\" -DPACKAGE_BUGREPORT=\"\ openbsc(a)lists.osmocom.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"osmo-iuh\" -DVERSION=\"0.0\" -DSTDC_HEADERS=1 -I. -I/home/blackbit/usr/stow/libasn1c/include/ -I/home/blackbit/usr/stow/libasn1c/include/asn1c -I. -g -O2 -MT Criticality.o -MD -MP -MF $depbase.Tpo -c -o Criticality.o Criticality.c &&\ > mv -f $depbase.Tpo $depbase.Po > In file included from Criticality.h:50:0, > from Criticality.c:8: > /home/blackbit/usr/stow/libasn1c/include/asn1c/asn_internal.h:18:33: fatal error: osmocom/core/talloc.h: No such file or directory > compilation terminated. Kind regards, -Alex

2 2

[PATCH] fix build if depenedencies are in distinct directories
by Alexander Huemer 24 Dec '15

24 Dec '15

Hi. This patch is for libosmo-sccp. Without it the build only works on machines that have the needed headers in the default search path for includes. Otherwise the build fails like this: > /bin/bash ../libtool --tag=CC --mode=compile gcc -DPACKAGE_NAME=\"libosmo-sccp\" -DPACKAGE_TARNAME=\"libosmo-sccp\" -DPACKAGE_VERSION=\"0.0.6.3.33-8209\" -DPACKAGE_STRING=\"libosmo-sccp\ 0.0.6.3.33-8209\" -DPACKAGE_BUGREPORT=\"openbsc(a)lists.osmocom.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libosmo-sccp\" -DVERSION=\"0.0.6.3.33-8209\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -I../include -I.. -Wall -I/home/blackbit/usr/stow/libosmocore/include/ -g -O2 -MT sua.lo -MD -MP -MF .deps/sua.Tpo -c -o sua.lo sua.c > libtool: compile: gcc -DPACKAGE_NAME=\"libosmo-sccp\" -DPACKAGE_TARNAME=\"libosmo-sccp\" -DPACKAGE_VERSION=\"0.0.6.3.33-8209\" "-DPACKAGE_STRING=\"libosmo-sccp 0.0.6.3.33-8209\"" -DPACKAGE_BUGREPORT=\"openbsc(a)lists.osmocom.org\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libosmo-sccp\" -DVERSION=\"0.0.6.3.33-8209\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -I../include -I.. -Wall -I/home/blackbit/usr/stow/libosmocore/include/ -g -O2 -MT sua.lo -MD -MP -MF .deps/sua.Tpo -c sua.c -fPIC -DPIC -o .libs/sua.o > sua.c:32:34: fatal error: osmocom/netif/stream.h: No such file or directory > compilation terminated. Kind regards, -Alex

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC December 2015