OpenBSC October 2013

openbsc@lists.osmocom.org

21 participants
45 discussions

by Sipos Csaba

Hi Caleb, The segfault is introduced with this patch: http://cgit.osmocom.org/libosmocore/commit/?id=f5a079f739c57d8be7c59149fd45… Is is not really a bugfix, but if you just comment out the following part from lapd_core.c added by the above patch and recompile openbsc, it will help: dl->tx_hist = NULL; The problem is probably related to the RESET function, because Nokia units are being reset during the initialization phase, and bootstrapped after that. The reason for this is if this reset is not concluded, then the BTS will not apply certain configuration parameters (e.g. change in ARFCN, transmit power, timeslot configuration). I strongly suggest you anyway, to start with TCF/F FR configuration, and if you see major alarm "BCF operation degraded: difference between PCM and BTS clock", it means that your E1 card is not able to provide accurate enough timing for the BTS. According to Nokia, you need +-5Hz accuracy on the E1 to meet the timing requirements, but even then at least 20-25 minutes of operation is needed for the BTS clock to be synced and the alarm goes away. Usually DAHDI or other E1 cards clock are not precise enough but don't worry: even with the alarm you can make pretty good quality phone calls, but remember: if you experience severe call quality degradation, or the phones cannot camp, or they loosing the network all the time, it is going to be a timing related problem. Anyway, do you have the Nokia InSite manager software? If not just write me a mail and I can help with that. You definitely going to need that and an LMP cable to do the initial setup, before you can get started with OpenBSC. BR, Csaba

11 years, 7 months

[PATCH 1/2] vty: Use vty_install_default() instead of bsc_install_default()

by Jacob Erlbeck

Remove ournode_exit_cmd, ournode_end_cmd, and bsc_install_default() since this functionality is provided by the current libosmocore. Replace calls to bsc_install_default() by call to vty_install_default() with the following semantic patch: @rule1@ expression N; @@ - bsc_install_default(N); + vty_install_default(N); Ticket: OW#952 Sponsored-by: On-Waves ehf --- openbsc/include/openbsc/vty.h | 4 --- openbsc/src/gprs/gb_proxy_vty.c | 2 +- openbsc/src/gprs/sgsn_vty.c | 2 +- openbsc/src/libbsc/abis_nm_vty.c | 2 +- openbsc/src/libbsc/abis_om2000_vty.c | 2 +- openbsc/src/libbsc/bsc_vty.c | 8 +++--- openbsc/src/libcommon/common_vty.c | 44 ----------------------------- openbsc/src/libmgcp/mgcp_vty.c | 4 +-- openbsc/src/libmsc/smpp_vty.c | 5 ++-- openbsc/src/libmsc/vty_interface_layer3.c | 2 +- openbsc/src/osmo-bsc/osmo_bsc_vty.c | 4 +-- openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 6 ++-- 12 files changed, 18 insertions(+), 67 deletions(-) diff --git a/openbsc/include/openbsc/vty.h b/openbsc/include/openbsc/vty.h index f74516a..9e07eb7 100644 --- a/openbsc/include/openbsc/vty.h +++ b/openbsc/include/openbsc/vty.h @@ -14,8 +14,6 @@ struct buffer *vty_argv_to_buffer(int argc, const char *argv[], int base); extern struct cmd_element cfg_description_cmd; extern struct cmd_element cfg_no_description_cmd; -extern struct cmd_element ournode_exit_cmd; -extern struct cmd_element ournode_end_cmd; enum bsc_vty_node { GSMNET_NODE = _LAST_OSMOVTY_NODE + 1, @@ -42,8 +40,6 @@ enum bsc_vty_node { extern int bsc_vty_is_config_node(struct vty *vty, int node); extern void bsc_replace_string(void *ctx, char **dst, const char *newstr); -void bsc_install_default(enum node_type node); - struct log_info; int bsc_vty_init(const struct log_info *cat); int bsc_vty_init_extra(void); diff --git a/openbsc/src/gprs/gb_proxy_vty.c b/openbsc/src/gprs/gb_proxy_vty.c index 82d49ca..2de0d3b 100644 --- a/openbsc/src/gprs/gb_proxy_vty.c +++ b/openbsc/src/gprs/gb_proxy_vty.c @@ -85,7 +85,7 @@ int gbproxy_vty_init(void) install_element(CONFIG_NODE, &cfg_gbproxy_cmd); install_node(&gbproxy_node, config_write_gbproxy); - bsc_install_default(GBPROXY_NODE); + vty_install_default(GBPROXY_NODE); install_element(GBPROXY_NODE, &cfg_nsip_sgsn_nsei_cmd); return 0; diff --git a/openbsc/src/gprs/sgsn_vty.c b/openbsc/src/gprs/sgsn_vty.c index 8106b7d..5fb7145 100644 --- a/openbsc/src/gprs/sgsn_vty.c +++ b/openbsc/src/gprs/sgsn_vty.c @@ -418,7 +418,7 @@ int sgsn_vty_init(void) install_element(CONFIG_NODE, &cfg_sgsn_cmd); install_node(&sgsn_node, config_write_sgsn); - bsc_install_default(SGSN_NODE); + vty_install_default(SGSN_NODE); install_element(SGSN_NODE, &cfg_sgsn_bind_addr_cmd); install_element(SGSN_NODE, &cfg_ggsn_remote_ip_cmd); //install_element(SGSN_NODE, &cfg_ggsn_remote_port_cmd); diff --git a/openbsc/src/libbsc/abis_nm_vty.c b/openbsc/src/libbsc/abis_nm_vty.c index 5db667d..a14e5c2 100644 --- a/openbsc/src/libbsc/abis_nm_vty.c +++ b/openbsc/src/libbsc/abis_nm_vty.c @@ -183,7 +183,7 @@ int abis_nm_vty_init(void) install_element(ENABLE_NODE, &oml_classnum_inst_cmd); install_node(&oml_node, dummy_config_write); - bsc_install_default(OML_NODE); + vty_install_default(OML_NODE); install_element(OML_NODE, &oml_chg_adm_state_cmd); install_element(OML_NODE, &oml_opstart_cmd); diff --git a/openbsc/src/libbsc/abis_om2000_vty.c b/openbsc/src/libbsc/abis_om2000_vty.c index eb8f4d5..8325e29 100644 --- a/openbsc/src/libbsc/abis_om2000_vty.c +++ b/openbsc/src/libbsc/abis_om2000_vty.c @@ -445,7 +445,7 @@ int abis_om2k_vty_init(void) install_element(ENABLE_NODE, &om2k_classnum_inst_cmd); install_node(&om2k_node, dummy_config_write); - bsc_install_default(OM2K_NODE); + vty_install_default(OM2K_NODE); install_element(OM2K_NODE, &om2k_reset_cmd); install_element(OM2K_NODE, &om2k_start_cmd); install_element(OM2K_NODE, &om2k_status_cmd); diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c index 5d03b2a..5a9976b 100644 --- a/openbsc/src/libbsc/bsc_vty.c +++ b/openbsc/src/libbsc/bsc_vty.c @@ -3101,7 +3101,7 @@ int bsc_vty_init(const struct log_info *cat) install_element(CONFIG_NODE, &cfg_net_cmd); install_node(&net_node, config_write_net); - bsc_install_default(GSMNET_NODE); + vty_install_default(GSMNET_NODE); install_element(GSMNET_NODE, &cfg_net_ncc_cmd); install_element(GSMNET_NODE, &cfg_net_mnc_cmd); install_element(GSMNET_NODE, &cfg_net_name_short_cmd); @@ -3137,7 +3137,7 @@ int bsc_vty_init(const struct log_info *cat) install_element(GSMNET_NODE, &cfg_bts_cmd); install_node(&bts_node, config_write_bts); - bsc_install_default(BTS_NODE); + vty_install_default(BTS_NODE); install_element(BTS_NODE, &cfg_bts_type_cmd); install_element(BTS_NODE, &cfg_description_cmd); install_element(BTS_NODE, &cfg_no_description_cmd); @@ -3199,7 +3199,7 @@ int bsc_vty_init(const struct log_info *cat) install_element(BTS_NODE, &cfg_trx_cmd); install_node(&trx_node, dummy_config_write); - bsc_install_default(TRX_NODE); + vty_install_default(TRX_NODE); install_element(TRX_NODE, &cfg_trx_arfcn_cmd); install_element(TRX_NODE, &cfg_description_cmd); install_element(TRX_NODE, &cfg_no_description_cmd); @@ -3211,7 +3211,7 @@ int bsc_vty_init(const struct log_info *cat) install_element(TRX_NODE, &cfg_ts_cmd); install_node(&ts_node, dummy_config_write); - bsc_install_default(TS_NODE); + vty_install_default(TS_NODE); install_element(TS_NODE, &cfg_ts_pchan_cmd); install_element(TS_NODE, &cfg_ts_pchan_compat_cmd); install_element(TS_NODE, &cfg_ts_tsc_cmd); diff --git a/openbsc/src/libcommon/common_vty.c b/openbsc/src/libcommon/common_vty.c index 0bf43b0..3f8f16f 100644 --- a/openbsc/src/libcommon/common_vty.c +++ b/openbsc/src/libcommon/common_vty.c @@ -118,40 +118,6 @@ enum node_type bsc_vty_go_parent(struct vty *vty) return vty->node; } -/* Down vty node level. */ -gDEFUN(ournode_exit, - ournode_exit_cmd, "exit", "Exit current mode and down to previous mode\n") -{ - bsc_vty_go_parent (vty); - return CMD_SUCCESS; -} - -/* End of configuration. */ -gDEFUN(ournode_end, - ournode_end_cmd, "end", "End current mode and change to enable mode.") -{ - enum node_type last_node = CONFIG_NODE; - - if (vty->node > ENABLE_NODE) { - /* Repeatedly call go_parent until a top node is reached. */ - while (vty->node > CONFIG_NODE) { - if (vty->node == last_node) { - /* Ensure termination, this shouldn't happen. */ - break; - } - last_node = vty->node; - bsc_vty_go_parent(vty); - } - - vty_config_unlock(vty); - if (vty->node > ENABLE_NODE) - vty->node = ENABLE_NODE; - vty->index = NULL; - vty->index_sub = NULL; - } - return CMD_SUCCESS; -} - int bsc_vty_is_config_node(struct vty *vty, int node) { switch (node) { @@ -174,13 +140,3 @@ void bsc_replace_string(void *ctx, char **dst, const char *newstr) talloc_free(*dst); *dst = talloc_strdup(ctx, newstr); } - -void bsc_install_default(enum node_type node) -{ - install_default (node); - - if (node > CONFIG_NODE) { - install_element(node, &ournode_exit_cmd); - install_element(node, &ournode_end_cmd); - } -} diff --git a/openbsc/src/libmgcp/mgcp_vty.c b/openbsc/src/libmgcp/mgcp_vty.c index 9421f4f..3c239d8 100644 --- a/openbsc/src/libmgcp/mgcp_vty.c +++ b/openbsc/src/libmgcp/mgcp_vty.c @@ -786,7 +786,7 @@ int mgcp_vty_init(void) install_element(CONFIG_NODE, &cfg_mgcp_cmd); install_node(&mgcp_node, config_write_mgcp); - bsc_install_default(MGCP_NODE); + vty_install_default(MGCP_NODE); install_element(MGCP_NODE, &cfg_mgcp_local_ip_cmd); install_element(MGCP_NODE, &cfg_mgcp_bts_ip_cmd); install_element(MGCP_NODE, &cfg_mgcp_bind_ip_cmd); @@ -818,7 +818,7 @@ int mgcp_vty_init(void) install_element(MGCP_NODE, &cfg_mgcp_trunk_cmd); install_node(&trunk_node, config_write_trunk); - bsc_install_default(TRUNK_NODE); + vty_install_default(TRUNK_NODE); install_element(TRUNK_NODE, &cfg_trunk_payload_number_cmd); install_element(TRUNK_NODE, &cfg_trunk_payload_name_cmd); install_element(TRUNK_NODE, &cfg_trunk_payload_number_cmd_old); diff --git a/openbsc/src/libmsc/smpp_vty.c b/openbsc/src/libmsc/smpp_vty.c index bf503f5..75427a9 100644 --- a/openbsc/src/libmsc/smpp_vty.c +++ b/openbsc/src/libmsc/smpp_vty.c @@ -509,7 +509,7 @@ static int config_write_esme(struct vty *v) int smpp_vty_init(void) { install_node(&smpp_node, config_write_smpp); - bsc_install_default(SMPP_NODE); + vty_install_default(SMPP_NODE); install_element(CONFIG_NODE, &cfg_smpp_cmd); install_element(SMPP_NODE, &cfg_smpp_port_cmd); @@ -519,7 +519,7 @@ int smpp_vty_init(void) install_element(SMPP_NODE, &cfg_no_esme_cmd); install_node(&esme_node, config_write_esme); - bsc_install_default(SMPP_ESME_NODE); + vty_install_default(SMPP_ESME_NODE); install_element(SMPP_ESME_NODE, &cfg_esme_passwd_cmd); install_element(SMPP_ESME_NODE, &cfg_esme_no_passwd_cmd); install_element(SMPP_ESME_NODE, &cfg_esme_route_pfx_cmd); @@ -532,7 +532,6 @@ int smpp_vty_init(void) install_element(SMPP_ESME_NODE, &cfg_esme_no_osmo_ext_cmd); install_element(SMPP_ESME_NODE, &cfg_esme_dcs_transp_cmd); install_element(SMPP_ESME_NODE, &cfg_esme_no_dcs_transp_cmd); - install_element(SMPP_ESME_NODE, &ournode_exit_cmd); install_element_ve(&show_esme_cmd); diff --git a/openbsc/src/libmsc/vty_interface_layer3.c b/openbsc/src/libmsc/vty_interface_layer3.c index e0324d6..7869d5b 100644 --- a/openbsc/src/libmsc/vty_interface_layer3.c +++ b/openbsc/src/libmsc/vty_interface_layer3.c @@ -1002,7 +1002,7 @@ int bsc_vty_init_extra(void) install_element(CONFIG_NODE, &cfg_mncc_int_cmd); install_node(&mncc_int_node, config_write_mncc_int); - bsc_install_default(MNCC_INT_NODE); + vty_install_default(MNCC_INT_NODE); install_element(MNCC_INT_NODE, &mnccint_def_codec_f_cmd); install_element(MNCC_INT_NODE, &mnccint_def_codec_h_cmd); diff --git a/openbsc/src/osmo-bsc/osmo_bsc_vty.c b/openbsc/src/osmo-bsc/osmo_bsc_vty.c index fceaa4a..4fac8ea 100644 --- a/openbsc/src/osmo-bsc/osmo_bsc_vty.c +++ b/openbsc/src/osmo-bsc/osmo_bsc_vty.c @@ -676,7 +676,7 @@ int bsc_vty_init_extra(void) install_element(CONFIG_NODE, &cfg_net_bsc_cmd); install_node(&bsc_node, config_write_bsc); - bsc_install_default(BSC_NODE); + vty_install_default(BSC_NODE); install_element(BSC_NODE, &cfg_net_bsc_mid_call_text_cmd); install_element(BSC_NODE, &cfg_net_bsc_mid_call_timeout_cmd); install_element(BSC_NODE, &cfg_net_rf_socket_cmd); @@ -686,7 +686,7 @@ int bsc_vty_init_extra(void) install_element(BSC_NODE, &cfg_net_bsc_no_missing_msc_text_cmd); install_node(&msc_node, config_write_msc); - bsc_install_default(MSC_NODE); + vty_install_default(MSC_NODE); install_element(MSC_NODE, &cfg_net_bsc_token_cmd); install_element(MSC_NODE, &cfg_net_bsc_ncc_cmd); install_element(MSC_NODE, &cfg_net_bsc_mcc_cmd); diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c b/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c index 72a6801..8dea34e 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c @@ -1192,7 +1192,7 @@ int bsc_nat_vty_init(struct bsc_nat *nat) /* nat group */ install_element(CONFIG_NODE, &cfg_nat_cmd); install_node(&nat_node, config_write_nat); - bsc_install_default(NAT_NODE); + vty_install_default(NAT_NODE); install_element(NAT_NODE, &cfg_nat_msc_ip_cmd); install_element(NAT_NODE, &cfg_nat_msc_port_cmd); install_element(NAT_NODE, &cfg_nat_auth_time_cmd); @@ -1233,14 +1233,14 @@ int bsc_nat_vty_init(struct bsc_nat *nat) install_element(NAT_NODE, &cfg_nat_pgroup_cmd); install_element(NAT_NODE, &cfg_nat_no_pgroup_cmd); install_node(&pgroup_node, config_write_pgroup); - bsc_install_default(PGROUP_NODE); + vty_install_default(PGROUP_NODE); install_element(PGROUP_NODE, &cfg_pgroup_lac_cmd); install_element(PGROUP_NODE, &cfg_pgroup_no_lac_cmd); /* BSC subgroups */ install_element(NAT_NODE, &cfg_bsc_cmd); install_node(&bsc_node, config_write_bsc); - bsc_install_default(NAT_BSC_NODE); + vty_install_default(NAT_BSC_NODE); install_element(NAT_BSC_NODE, &cfg_bsc_token_cmd); install_element(NAT_BSC_NODE, &cfg_bsc_lac_cmd); install_element(NAT_BSC_NODE, &cfg_bsc_no_lac_cmd); -- 1.7.9.5

11 years, 7 months

Nokia Insite OpenBSC Segfault

by Caleb Pal

Hello, I decided to connect my Nokia inSite 1900MHz E1 BTS that has been sitting for a while. Shortly after I start OpenBSC, it crashes. I have attached my configuration files as well as the result from gdb. I am using a Dahdi with a TE122P set to E1 mode. openbsc.cfg ! ! OpenBSC configuration saved from vty ! ! password foo ! line vty no login ! e1_input e1_line 0 driver dahdi network network country code 905 mobile network code 1 short name TNET long name TEST timer t3101 10 timer t3113 60 bts 0 type nokia_site band GSM1900 cell_identity 1 location_area_code 1 base_station_id_code 63 training_sequence_code 7 oml e1 line 0 timeslot 1 sub-slot full oml e1 tei 1 trx 0 arfcn 518 max_power_red 24 rsl e1 line 0 timeslot 2 sub-slot full rsl e1 tei 1 timeslot 0 phys_chan_config CCCH+SDCCH4 e1 line 0 timeslot 6 sub-slot full timeslot 1 phys_chan_config TCH/F e1 line 0 timeslot 6 sub-slot 1 timeslot 2 phys_chan_config TCH/F e1 line 0 timeslot 6 sub-slot 2 timeslot 3 phys_chan_config TCH/F e1 line 0 timeslot 6 sub-slot 3 timeslot 4 phys_chan_config TCH/F e1 line 0 timeslot 7 sub-slot 0 timeslot 5 phys_chan_config TCH/F e1 line 0 timeslot 7 sub-slot 1 timeslot 6 phys_chan_config TCH/F e1 line 0 timeslot 7 sub-slot 2 timeslot 7 phys_chan_config TCH/F e1 line 0 timeslot 7 sub-slot 3 DAHDI system.conf # Dahdi Configuration File # # This file is parsed by the Dahdi Configurator, dahdi_cfg # # Global data # # E1 Configuration (Jumper set on card) # # span=1,0,0,ccs,hdb3,crc4 # # bchan=1-31 # # # Zone stuff loadzone = us defaultzone = us Output from gdb: root@openbsc-2:/opt/openbsc/openbsc/src# gdb ./osmo-nitb/osmo-nitb GNU gdb (GDB) 7.4.1-debian Copyright (C) 2012 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "i486-linux-gnu". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>... Reading symbols from /opt/openbsc/openbsc/src/osmo-nitb/osmo-nitb...done. (gdb) run Starting program: /opt/openbsc/openbsc/src/osmo-nitb/osmo-nitb [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/i386-linux-gnu/i686/cmov/libthread_db.so.1". <0018> input/lapd.c:212 LAPD Allocating SAP for SAPI=62 / TEI=1 <0018> input/lapd.c:223 k=1 N200=3 N201=260 T200=1.0 T203=10.0 <0018> input/lapd.c:485 LAPD DL-ESTABLISH request TEI=1 SAPI=62 DB: Database initialized. DB: Database prepared. <001d> sms_queue.c:220 Attempting to send 20 SMS <0018> input/lapd.c:624 LAPD DL-ESTABLISH confirm TEI=1 SAPI=62 <0005> bts_nokia_site.c:58 bootstrapping OML for BTS 0 <0005> bts_nokia_site.c:1679 ABIS_OM_MDISC_FOM <0005> bts_nokia_site.c:1507 (0x81) NOKIA_BTS_ACK <0005> bts_nokia_site.c:1539 ACK = 1 <0018> input/lapd.c:513 LAPD DL-RELEASE request TEI=1 SAPI=62 <0018> input/lapd.c:628 LAPD DL-RELEASE confirm TEI=1 SAPI=62 Program received signal SIGSEGV, Segmentation fault. 0xb7f96f00 in lapd_send_i (line=line@entry=1609, lctx=<error reading variable: Unhandled dwarf expression opcode 0xfa>, lctx=<error reading variable: Unhandled dwarf expression opcode 0xfa>) at lapd_core.c:1803 1803 if (!dl->tx_hist[h].msg) { (gdb) bt full #0 0xb7f96f00 in lapd_send_i (line=line@entry=1609, lctx=<error reading variable: Unhandled dwarf expression opcode 0xfa>, lctx=<error reading variable: Unhandled dwarf expression opcode 0xfa>) at lapd_core.c:1803 dl = 0x8157510 k = 1 '\001' msg = <optimized out> length = <optimized out> left = <optimized out> rc = <optimized out> nctx = {dl = 0x8157510, n201 = -1208330011, cr = 219 '\333', sapi = 200 '\310', tei = 245 '\365', lpd = 183 '\267', format = 254 '\376', p_f = 255 '\377', n_send = 255 '\377', n_recv = 255 '\377', s_u = 3 '\003', length = -1208330011, more = 62 '>'} #1 0xb7f99ac3 in lapd_rx_i (lctx=0xbffff9b4, msg=0x815d708) at lapd_core.c:1609 dl = 0x8157510 ns = 0 '\000' length = <optimized out> rc = <optimized out> #2 lapd_ph_data_ind (msg=msg@entry=0x815d708, lctx=lctx@entry=0xbffff9b4) at lapd_core.c:1644 rc = <optimized out> #3 0xb7f4aafa in lapd_receive (li=0x81333f8, msg=msg@entry=0x815d708, error=error@entry=0xbffffa2c) at input/lapd.c:461 i = 4 lctx = {dl = 0x8157510, n201 = 260, cr = 0 '\000', sapi = 62 '>', tei = 1 '\001', lpd = 0 '\000', format = 1 '\001', p_f = 0 '\000', n_send = 0 '\000', n_recv = 1 '\001', s_u = 0 '\000', length = 12, more = 0 '\000'} rc = 135476652 sap = <optimized out> teip = 0x815d708 #4 0xb7f426e6 in e1inp_rx_ts_lapd (e1i_ts=e1i_ts@entry=0x8133ad4, msg=msg@entry=0x815d708) at e1_input.c:556 sapi = 62 tei = 1 ret = 0 error = 0 #5 0xb7f460ee in handle_ts1_read (bfd=0x8134040) at input/dahdi.c:190 line = <optimized out> msg = 0x815d708 ret = 18 ts_nr = <optimized out> e1i_ts = 0x8133ad4 #6 dahdi_fd_cb (bfd=0x8134040, what=1) at input/dahdi.c:376 line = <optimized out> ts_nr = <optimized out> idx = <optimized out> e1i_ts = <optimized out> rc = 0 ---Type <return> to continue, or q <return> to quit--- #7 0xb7f5a7e2 in osmo_select_main (polling=polling@entry=0) at select.c:158 flags = <optimized out> ufd = 0x8134040 tmp = 0x81345c8 readset = {__fds_bits = {0 <repeats 32 times>}} writeset = {__fds_bits = {0 <repeats 32 times>}} exceptset = {__fds_bits = {0 <repeats 32 times>}} work = 1 rc = <optimized out> no_time = {tv_sec = 0, tv_usec = 0} #8 0x0804d481 in main (argc=1, argv=0xbffffd84) at bsc_hack.c:346 rc = <optimized out> (gdb) list 1798 } 1799 1800 h = do_mod(dl->v_send, dl->range_hist); 1801 1802 /* if we have no tx_hist yet, we create it */ 1803 if (!dl->tx_hist[h].msg) { 1804 /* Get next message into send-buffer, if any */ 1805 if (!dl->send_buffer) { 1806 next_message: 1807 dl->send_out = 0; (gdb) Regards, Caleb

11 years, 7 months

Re: OpenBSC + LCR + Asterisk = half sided calls in one

by Sipos Csaba

Hey Peter, > I'd suggest to make LCR use SIP for communcation with Asterisk. See > http://stuge.se/lcr.txt for a minimal example of LCR configuration. Do you have some more example configuration files for the Asterisk end of the SIP trunk? > Since you're using bridging you might also want to try rtp-bridge > between GSM and SIP, which could allow GSM phones and SIP phones to > negotiate codec directly, avoiding any transcoding. (But maybe it > only works with Abis over IP and not over ISDN? I'm not sure.) I am almost sure that RTP bridge can only be used with IP based BTSes which I don't have. My units are connecting via E1 dahdi. > You can of course continue to debug the LCR-Asterisk module but I > would suggest moving to SIP since I think working with SIP on both > legs makes debugging a bit easier. My problem is that I made test calls an analyzed the logs at both LCR and Asterisk end, and there is no difference between a good and a half sided call. First, I forced the GSM phones to use TCH/F FR only, then I forced LCR and Asterisk SIP clients to use Alaw only (SIP clients are not supporting any GSM codec). Transcoding obviously happens between TCH/F FR and Alaw, but how on earth is possible that the direction of the call can affect that this transcoding is going to be a success or not? If its a transcoding failure it shouldn't work in any direction. If its a call routing problem, then the call shouldn't make its way to the called party. But none of this is what happens. So I really don't know where to look, or how to debug this problem. BR, Csaba

11 years, 7 months

[PATCH 1/2] grps: Add test for NS messages that shall be ignored

by Jacob Erlbeck

Several messages shall not be answered when a RESET hasn't been received on a NS-VC: - NS_RESET_ACK (see 3GPP TS 08.16, 7.3.1) - NS_ALIVE_ACK (see 3GPP TS 08.16, 7.4.1) - NS_STATUS (see 3GPP TS 08.16, 7.5.1) Sponsored-by: On-Waves ehf --- tests/gb/gprs_ns_test.c | 28 ++++++++++++++++++++++++++++ tests/gb/gprs_ns_test.ok | 27 +++++++++++++++++++++++++++ 2 files changed, 55 insertions(+) diff --git a/tests/gb/gprs_ns_test.c b/tests/gb/gprs_ns_test.c index c88792c..c90d752 100644 --- a/tests/gb/gprs_ns_test.c +++ b/tests/gb/gprs_ns_test.c @@ -486,6 +486,33 @@ static void test_nsvc() alarm(0); } +static void test_ignored_messages() +{ + struct gprs_ns_inst *nsi = gprs_ns_instantiate(gprs_ns_callback, NULL); + struct sockaddr_in peer[1] = {{0},}; + + peer[0].sin_family = AF_INET; + peer[0].sin_port = htons(1111); + peer[0].sin_addr.s_addr = htonl(REMOTE_BSS_ADDR); + + printf("--- Send unexpected NS STATUS (should not be answered)---\n\n"); + /* Do not respond, see 3GPP TS 08.16, 7.5.1 */ + gprs_process_message(nsi, "STATUS", &peer[0], + gprs_ns_status_invalid_alive, + sizeof(gprs_ns_status_invalid_alive)); + + printf("--- Send unexpected NS ALIVE ACK (should not be answered)---\n\n"); + /* Ignore this, see 3GPP TS 08.16, 7.4.1 */ + send_ns_alive_ack(nsi, &peer[0]); + + printf("--- Send unexpected NS RESET ACK (should not be answered)---\n\n"); + /* Ignore this, see 3GPP TS 08.16, 7.3.1 */ + send_ns_reset_ack(nsi, &peer[0], 0xe001, 0xe000); + + gprs_ns_destroy(nsi); + nsi = NULL; +} + static void test_bss_port_changes() { struct gprs_ns_inst *nsi = gprs_ns_instantiate(gprs_ns_callback, NULL); @@ -832,6 +859,7 @@ int main(int argc, char **argv) printf("===== NS protocol test START\n"); test_nsvc(); + test_ignored_messages(); test_bss_port_changes(); test_bss_reset_ack(); test_sgsn_reset(); diff --git a/tests/gb/gprs_ns_test.ok b/tests/gb/gprs_ns_test.ok index 8a61450..23c9e5f 100644 --- a/tests/gb/gprs_ns_test.ok +++ b/tests/gb/gprs_ns_test.ok @@ -85,6 +85,33 @@ Current NS-VCIs: --- Process timers --- +--- Send unexpected NS STATUS (should not be answered)--- + +PROCESSING STATUS from 0x01020304:1111 +08 00 81 0a 02 81 0a + +result (STATUS) = 0 + +--- Send unexpected NS ALIVE ACK (should not be answered)--- + +PROCESSING ALIVE_ACK from 0x01020304:1111 +0b + +MESSAGE to BSS, msg length 7 +08 00 81 0a 02 81 0b + +result (ALIVE_ACK) = 0 + +--- Send unexpected NS RESET ACK (should not be answered)--- + +PROCESSING RESET_ACK from 0x01020304:1111 +03 01 82 e0 01 04 82 e0 00 + +MESSAGE to BSS, msg length 15 +08 00 81 0a 02 89 03 01 82 e0 01 04 82 e0 00 + +result (RESET_ACK) = 0 + --- Setup, send BSSGP RESET --- Setup NS-VC: remote 0x01020304:1111, NSVCI 0x1122(4386), NSEI 0x1122(4386) -- 1.7.9.5

11 years, 7 months

osmo-nitb openbsc sms via commandline problem.

by hulds＠gmx.net

Hi, When sending sms via openbsc commandline the sms gets extra data added to its tail. The coversion from text to PDU results in the converted data + garbage, this data is posted to the 'sms' database 'user-data' field, and then sent. in the 'sms' database you can verify that a short sms text results in long user-data phone to phone sms works without problems. Henry

11 years, 8 months

OsmocomBB without hardware phone

by clovnrian＠gmail.com

Hi, I am trying to modify osmocomBB to work without the phone as layer 1. My goal is that application will using socket to communicate with BTS (modified BTS which can send and receive message throught sockets). I analyzed the osmocomBB code and I found that I'll have to modify osmocon.c (host/osmocon/osmocon.c) file. This file is interface between serial communication and layer2. If I am right, I have to do this changes: 1. Delete functions handle the serial interface 2. Add new tool server to dnload structure 3. Creating new tool server for L1 interface (UNIX socket or IP socket with GSMTAP) 4. Add callback function for reading from layer2 socket and forward this messages to L1 socket interface. Simplified I have to listen and forward packets from BTS to layer2 socket and from L2 to L1. Do I think in right direction or I am wrong and it will need more modifications? Best regards, Miroslav Babjak

11 years, 8 months

[PATCH 1/5] vty: Fix whitespace in test script

by Jacob Erlbeck

Expands leading tabs and removes trailing whitespace. Sponsored-by: On-Waves ehf --- openbsc/src/gprs/gb_proxy.c | 1 - openbsc/tests/vty_test_runner.py | 14 +++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/openbsc/src/gprs/gb_proxy.c b/openbsc/src/gprs/gb_proxy.c index dea6e3f..d075578 100644 --- a/openbsc/src/gprs/gb_proxy.c +++ b/openbsc/src/gprs/gb_proxy.c @@ -204,7 +204,6 @@ static struct gbprox_peer *peer_alloc(uint16_t bvci) return peer; } -static void peer_free(struct gbprox_peer *peer) __attribute__((__unused__)); static void peer_free(struct gbprox_peer *peer) { llist_del(&peer->list); diff --git a/openbsc/tests/vty_test_runner.py b/openbsc/tests/vty_test_runner.py index 0bd7972..09352b8 100644 --- a/openbsc/tests/vty_test_runner.py +++ b/openbsc/tests/vty_test_runner.py @@ -72,7 +72,7 @@ class TestVTYGenericBSC(TestVTYBase): try: self.checkForEndAndExit() except BaseException as e: - sys.stderr.write('Expected and ignored failure: %s\n' % (str(e))) + sys.stderr.write('Expected and ignored failure: %s\n' % (str(e))) def _testConfigNetworkTree(self): self.vty.enable() @@ -118,7 +118,7 @@ class TestVTYNITB(TestVTYGenericBSC): return (4242, "./src/osmo-nitb/osmo-nitb", "OpenBSC", "nitb") def testConfigNetworkTree(self): - self._testConfigNetworkTree() + self._testConfigNetworkTree() def checkForSmpp(self): """SMPP is not always enabled, check if it is""" @@ -137,10 +137,10 @@ class TestVTYNITB(TestVTYGenericBSC): if self.checkForSmpp(): self.assertEquals(self.vty.node(), 'config') - self.assertTrue(self.vty.verify('smpp', [''])) - self.assertEquals(self.vty.node(), 'config-smpp') - self.ignoredCheckForEndAndExit() - self.assertTrue(self.vty.verify("exit", [''])) + self.assertTrue(self.vty.verify('smpp', [''])) + self.assertEquals(self.vty.node(), 'config-smpp') + self.ignoredCheckForEndAndExit() + self.assertTrue(self.vty.verify("exit", [''])) self.assertEquals(self.vty.node(), 'config') self.assertTrue(self.vty.verify("exit", [''])) @@ -241,7 +241,7 @@ class TestVTYBSC(TestVTYGenericBSC): return (4242, "./src/osmo-bsc/osmo-bsc", "OsmoBSC", "bsc") def testConfigNetworkTree(self): - self._testConfigNetworkTree() + self._testConfigNetworkTree() def testVtyTree(self): self.vty.enable() -- 1.7.9.5

11 years, 8 months

[PATCH 1/2] gbproxy: Add test for NSEI and NSVCI changes

by Jacob Erlbeck

This checks the behavior of the gbproxy when the BSS peer changes the NSEI and the NSVCI. It also tests BVC_RESET and other UNITDATA messages after these changes between BSS and SGSN and vice versa (via the gbproxy). Ticket: OW#874 Sponsored-by: On-Waves ehf --- openbsc/include/openbsc/gb_proxy.h | 1 + openbsc/src/gprs/gb_proxy.c | 11 + openbsc/tests/gbproxy/gbproxy_test.c | 153 ++++++- openbsc/tests/gbproxy/gbproxy_test.ok | 705 ++++++++++++++++++++++++++++++++- 4 files changed, 866 insertions(+), 4 deletions(-) diff --git a/openbsc/include/openbsc/gb_proxy.h b/openbsc/include/openbsc/gb_proxy.h index c2c9092..4d189a6 100644 --- a/openbsc/include/openbsc/gb_proxy.h +++ b/openbsc/include/openbsc/gb_proxy.h @@ -39,4 +39,5 @@ int gbprox_reset_persistent_nsvcs(struct gprs_ns_inst *nsi); int gbprox_dump_global(FILE *stream, int indent, int verbose); int gbprox_dump_peers(FILE *stream, int indent, int verbose); +void gbprox_reset(); #endif diff --git a/openbsc/src/gprs/gb_proxy.c b/openbsc/src/gprs/gb_proxy.c index 6f7d1c3..f008b3e 100644 --- a/openbsc/src/gprs/gb_proxy.c +++ b/openbsc/src/gprs/gb_proxy.c @@ -881,6 +881,17 @@ int gbprox_dump_peers(FILE *stream, int indent, int verbose) return 0; } +void gbprox_reset() +{ + struct gbprox_peer *peer, *tmp; + + llist_for_each_entry_safe(peer, tmp, &gbprox_bts_peers, list) + peer_free(peer); + + rate_ctr_group_free(global_ctrg); + global_ctrg = NULL; +} + static int gbprox_cleanup_peers(uint16_t nsei, uint16_t bvci) { int counter = 0; diff --git a/openbsc/tests/gbproxy/gbproxy_test.c b/openbsc/tests/gbproxy/gbproxy_test.c index e1e6587..d32ac83 100644 --- a/openbsc/tests/gbproxy/gbproxy_test.c +++ b/openbsc/tests/gbproxy/gbproxy_test.c @@ -543,6 +543,147 @@ static void test_gbproxy() gprs_ns_destroy(nsi); nsi = NULL; + gbprox_reset(); +} + +static void test_gbproxy_ident_changes() +{ + struct gprs_ns_inst *nsi = gprs_ns_instantiate(gprs_ns_callback, NULL); + struct sockaddr_in bss_peer[1] = {{0},}; + struct sockaddr_in sgsn_peer= {0}; + uint16_t nsei[2] = {0x1000, 0x2000}; + uint16_t nsvci[2] = {0x1001, 0x2001}; + uint16_t bvci[4] = {0x1002, 0x2002, 0x3002, 0x4002}; + + bssgp_nsi = nsi; + gbcfg.nsi = bssgp_nsi; + gbcfg.nsip_sgsn_nsei = SGSN_NSEI; + + sgsn_peer.sin_family = AF_INET; + sgsn_peer.sin_port = htons(32000); + sgsn_peer.sin_addr.s_addr = htonl(REMOTE_SGSN_ADDR); + + bss_peer[0].sin_family = AF_INET; + bss_peer[0].sin_port = htons(1111); + bss_peer[0].sin_addr.s_addr = htonl(REMOTE_BSS_ADDR); + + printf("--- Initialise SGSN ---\n\n"); + + gprs_ns_nsip_connect(nsi, &sgsn_peer, SGSN_NSEI, SGSN_NSEI+1); + send_ns_reset_ack(nsi, &sgsn_peer, SGSN_NSEI+1, SGSN_NSEI); + send_ns_alive_ack(nsi, &sgsn_peer); + send_ns_unblock_ack(nsi, &sgsn_peer); + send_ns_alive(nsi, &sgsn_peer); + gprs_dump_nsi(nsi); + + printf("--- Initialise BSS 1 ---\n\n"); + + setup_ns(nsi, &bss_peer[0], nsvci[0], nsei[0]); + gprs_dump_nsi(nsi); + + printf("--- Setup BVCI 1 ---\n\n"); + + setup_bssgp(nsi, &bss_peer[0], bvci[0]); + send_bssgp_reset_ack(nsi, &sgsn_peer, bvci[0]); + gbprox_dump_peers(stdout, 0, 1); + + printf("--- Setup BVCI 2 ---\n\n"); + + setup_bssgp(nsi, &bss_peer[0], bvci[1]); + send_bssgp_reset_ack(nsi, &sgsn_peer, bvci[1]); + gbprox_dump_peers(stdout, 0, 1); + + printf("--- Send message from BSS 1 to SGSN and back, BVCI 1 ---\n\n"); + + send_ns_unitdata(nsi, NULL, &bss_peer[0], bvci[0], (uint8_t *)"", 0); + send_ns_unitdata(nsi, NULL, &sgsn_peer, bvci[0], (uint8_t *)"", 0); + + printf("--- Send message from BSS 1 to SGSN and back, BVCI 2 ---\n\n"); + + send_ns_unitdata(nsi, NULL, &bss_peer[0], bvci[1], (uint8_t *)"", 0); + send_ns_unitdata(nsi, NULL, &sgsn_peer, bvci[1], (uint8_t *)"", 0); + + printf("--- Change NSEI ---\n\n"); + + setup_ns(nsi, &bss_peer[0], nsvci[0], nsei[1]); + gprs_dump_nsi(nsi); + + printf("--- Setup BVCI 1 ---\n\n"); + + setup_bssgp(nsi, &bss_peer[0], bvci[0]); + send_bssgp_reset_ack(nsi, &sgsn_peer, bvci[0]); + gbprox_dump_peers(stdout, 0, 1); + + printf("--- Setup BVCI 3 ---\n\n"); + + setup_bssgp(nsi, &bss_peer[0], bvci[2]); + send_bssgp_reset_ack(nsi, &sgsn_peer, bvci[2]); + gbprox_dump_peers(stdout, 0, 1); + + printf("--- Send message from BSS 1 to SGSN and back, BVCI 1 ---\n\n"); + + send_ns_unitdata(nsi, NULL, &bss_peer[0], bvci[0], (uint8_t *)"", 0); + send_ns_unitdata(nsi, NULL, &sgsn_peer, bvci[0], (uint8_t *)"", 0); + + printf("--- Send message from BSS 1 to SGSN and back, BVCI 2 " + " (should fail) ---\n\n"); + + send_ns_unitdata(nsi, NULL, &bss_peer[0], bvci[1], (uint8_t *)"", 0); + gbprox_dump_peers(stdout, 0, 1); + send_ns_unitdata(nsi, NULL, &sgsn_peer, bvci[1], (uint8_t *)"", 0); + gbprox_dump_peers(stdout, 0, 1); + + printf("--- Send message from BSS 1 to SGSN and back, BVCI 3 ---\n\n"); + + send_ns_unitdata(nsi, NULL, &bss_peer[0], bvci[2], (uint8_t *)"", 0); + send_ns_unitdata(nsi, NULL, &sgsn_peer, bvci[2], (uint8_t *)"", 0); + + printf("--- Change NSVCI ---\n\n"); + + setup_ns(nsi, &bss_peer[0], nsvci[1], nsei[1]); + gprs_dump_nsi(nsi); + + printf("--- Setup BVCI 1 ---\n\n"); + + setup_bssgp(nsi, &bss_peer[0], bvci[0]); + send_bssgp_reset_ack(nsi, &sgsn_peer, bvci[0]); + gbprox_dump_peers(stdout, 0, 1); + + printf("--- Setup BVCI 4 ---\n\n"); + + setup_bssgp(nsi, &bss_peer[0], bvci[3]); + send_bssgp_reset_ack(nsi, &sgsn_peer, bvci[3]); + gbprox_dump_peers(stdout, 0, 1); + + printf("--- Send message from BSS 1 to SGSN and back, BVCI 1 ---\n\n"); + + send_ns_unitdata(nsi, NULL, &bss_peer[0], bvci[0], (uint8_t *)"", 0); + send_ns_unitdata(nsi, NULL, &sgsn_peer, bvci[0], (uint8_t *)"", 0); + + printf("--- Send message from BSS 1 to SGSN and back, BVCI 2 " + " (should fail) ---\n\n"); + + send_ns_unitdata(nsi, NULL, &bss_peer[0], bvci[1], (uint8_t *)"", 0); + gbprox_dump_peers(stdout, 0, 1); + send_ns_unitdata(nsi, NULL, &sgsn_peer, bvci[1], (uint8_t *)"", 0); + gbprox_dump_peers(stdout, 0, 1); + + printf("--- Send message from BSS 1 to SGSN and back, BVCI 3 ---\n\n"); + + send_ns_unitdata(nsi, NULL, &bss_peer[0], bvci[2], (uint8_t *)"", 0); + send_ns_unitdata(nsi, NULL, &sgsn_peer, bvci[2], (uint8_t *)"", 0); + + printf("--- Send message from BSS 1 to SGSN and back, BVCI 4 ---\n\n"); + + send_ns_unitdata(nsi, NULL, &bss_peer[0], bvci[3], (uint8_t *)"", 0); + send_ns_unitdata(nsi, NULL, &sgsn_peer, bvci[3], (uint8_t *)"", 0); + + gbprox_dump_global(stdout, 0, 1); + gbprox_dump_peers(stdout, 0, 1); + + gprs_ns_destroy(nsi); + nsi = NULL; + gbprox_reset(); } @@ -555,9 +696,17 @@ int main(int argc, char **argv) log_set_print_filename(osmo_stderr_target, 0); osmo_signal_register_handler(SS_L_NS, &test_signal, NULL); - printf("===== NS protocol test START\n"); + log_set_print_filename(osmo_stderr_target, 0); + log_set_log_level(osmo_stderr_target, LOGL_INFO); + + rate_ctr_init(NULL); + + setlinebuf(stdout); + + printf("===== GbProxy test START\n"); test_gbproxy(); - printf("===== NS protocol test END\n\n"); + test_gbproxy_ident_changes(); + printf("===== GbProxy test END\n\n"); exit(EXIT_SUCCESS); } diff --git a/openbsc/tests/gbproxy/gbproxy_test.ok b/openbsc/tests/gbproxy/gbproxy_test.ok index 35d97e7..b21f58a 100644 --- a/openbsc/tests/gbproxy/gbproxy_test.ok +++ b/openbsc/tests/gbproxy/gbproxy_test.ok @@ -1,4 +1,4 @@ -===== NS protocol test START +===== GbProxy test START --- Initialise SGSN --- MESSAGE to SGSN at 0x05060708:32000, msg length 12 @@ -814,5 +814,706 @@ result (UNITDATA) = 14 Gbproxy global: Invalid BVC Identifier : 1 -===== NS protocol test END +--- Initialise SGSN --- + +MESSAGE to SGSN at 0x05060708:32000, msg length 12 +02 00 81 01 01 82 01 01 04 82 01 00 + +PROCESSING RESET_ACK from 0x05060708:32000 +03 01 82 01 01 04 82 01 00 + +MESSAGE to SGSN at 0x05060708:32000, msg length 1 +0a + +result (RESET_ACK) = 1 + +PROCESSING ALIVE_ACK from 0x05060708:32000 +0b + +MESSAGE to SGSN at 0x05060708:32000, msg length 1 +06 + +result (ALIVE_ACK) = 1 + +PROCESSING UNBLOCK_ACK from 0x05060708:32000 +07 + +==> got signal NS_UNBLOCK, NS-VC 0x0101/5.6.7.8:32000 + +result (UNBLOCK_ACK) = 0 + +PROCESSING ALIVE from 0x05060708:32000 +0a + +MESSAGE to SGSN at 0x05060708:32000, msg length 1 +0b + +result (ALIVE) = 1 + +Current NS-VCIs: + VCI 0x0101, NSEI 0x0100, peer 0x05060708:32000 + NS-VC Block count : 1 + +--- Initialise BSS 1 --- + +Setup NS-VC: remote 0x01020304:1111, NSVCI 0x1001(4097), NSEI 0x1000(4096) + +PROCESSING RESET from 0x01020304:1111 +02 00 81 01 01 82 10 01 04 82 10 00 + +==> got signal NS_RESET, NS-VC 0x1001/1.2.3.4:1111 + +MESSAGE to BSS at 0x01020304:1111, msg length 9 +03 01 82 10 01 04 82 10 00 + +MESSAGE to BSS at 0x01020304:1111, msg length 1 +0a + +result (RESET) = 9 + +PROCESSING ALIVE from 0x01020304:1111 +0a + +MESSAGE to BSS at 0x01020304:1111, msg length 1 +0b + +result (ALIVE) = 1 + +PROCESSING UNBLOCK from 0x01020304:1111 +06 + +==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:1111 + +MESSAGE to BSS at 0x01020304:1111, msg length 1 +07 + +result (UNBLOCK) = 1 + +PROCESSING ALIVE_ACK from 0x01020304:1111 +0b + +result (ALIVE_ACK) = 0 + +Current NS-VCIs: + VCI 0x1001, NSEI 0x1000, peer 0x01020304:1111 + VCI 0x0101, NSEI 0x0100, peer 0x05060708:32000 + NS-VC Block count : 1 + +--- Setup BVCI 1 --- + +Setup BSSGP: remote 0x01020304:1111, BVCI 0x1002(4098) + +PROCESSING BVC_RESET from 0x01020304:1111 +00 00 00 00 22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +CALLBACK, event 0, msg length 22, bvci 0x0000 +22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +NS UNITDATA MESSAGE to SGSN, BVCI 0x0000, msg length 22 +22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +MESSAGE to SGSN at 0x05060708:32000, msg length 26 +00 00 00 00 22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +result (BVC_RESET) = 26 + +PROCESSING BVC_RESET_ACK from 0x05060708:32000 +00 00 00 00 23 04 82 10 02 + +CALLBACK, event 0, msg length 5, bvci 0x0000 +23 04 82 10 02 + +NS UNITDATA MESSAGE to BSS, BVCI 0x0000, msg length 5 +23 04 82 10 02 + +MESSAGE to BSS at 0x01020304:1111, msg length 9 +00 00 00 00 23 04 82 10 02 + +result (BVC_RESET_ACK) = 9 + +Peers: + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 +--- Setup BVCI 2 --- + +Setup BSSGP: remote 0x01020304:1111, BVCI 0x2002(8194) + +PROCESSING BVC_RESET from 0x01020304:1111 +00 00 00 00 22 04 82 20 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +CALLBACK, event 0, msg length 22, bvci 0x0000 +22 04 82 20 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +NS UNITDATA MESSAGE to SGSN, BVCI 0x0000, msg length 22 +22 04 82 20 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +MESSAGE to SGSN at 0x05060708:32000, msg length 26 +00 00 00 00 22 04 82 20 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +result (BVC_RESET) = 26 + +PROCESSING BVC_RESET_ACK from 0x05060708:32000 +00 00 00 00 23 04 82 20 02 + +CALLBACK, event 0, msg length 5, bvci 0x0000 +23 04 82 20 02 + +NS UNITDATA MESSAGE to BSS, BVCI 0x0000, msg length 5 +23 04 82 20 02 + +MESSAGE to BSS at 0x01020304:1111, msg length 9 +00 00 00 00 23 04 82 20 02 + +result (BVC_RESET_ACK) = 9 + +Peers: + NSEI 4096, BVCI 8194, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 +--- Send message from BSS 1 to SGSN and back, BVCI 1 --- + +PROCESSING UNITDATA from 0x01020304:1111 +00 00 10 02 + +CALLBACK, event 0, msg length 0, bvci 0x1002 + + +NS UNITDATA MESSAGE to SGSN, BVCI 0x1002, msg length 0 + + +MESSAGE to SGSN at 0x05060708:32000, msg length 4 +00 00 10 02 + +result (UNITDATA) = 4 + +PROCESSING UNITDATA from 0x05060708:32000 +00 00 10 02 + +CALLBACK, event 0, msg length 0, bvci 0x1002 + + +NS UNITDATA MESSAGE to BSS, BVCI 0x1002, msg length 0 + + +MESSAGE to BSS at 0x01020304:1111, msg length 4 +00 00 10 02 + +result (UNITDATA) = 4 + +--- Send message from BSS 1 to SGSN and back, BVCI 2 --- + +PROCESSING UNITDATA from 0x01020304:1111 +00 00 20 02 + +CALLBACK, event 0, msg length 0, bvci 0x2002 + + +NS UNITDATA MESSAGE to SGSN, BVCI 0x2002, msg length 0 + + +MESSAGE to SGSN at 0x05060708:32000, msg length 4 +00 00 20 02 + +result (UNITDATA) = 4 + +PROCESSING UNITDATA from 0x05060708:32000 +00 00 20 02 + +CALLBACK, event 0, msg length 0, bvci 0x2002 + + +NS UNITDATA MESSAGE to BSS, BVCI 0x2002, msg length 0 + + +MESSAGE to BSS at 0x01020304:1111, msg length 4 +00 00 20 02 + +result (UNITDATA) = 4 + +--- Change NSEI --- + +Setup NS-VC: remote 0x01020304:1111, NSVCI 0x1001(4097), NSEI 0x2000(8192) + +PROCESSING RESET from 0x01020304:1111 +02 00 81 01 01 82 10 01 04 82 20 00 + +==> got signal NS_RESET, NS-VC 0x1001/1.2.3.4:1111 + +MESSAGE to BSS at 0x01020304:1111, msg length 9 +03 01 82 10 01 04 82 20 00 + +MESSAGE to BSS at 0x01020304:1111, msg length 1 +0a + +result (RESET) = 9 + +PROCESSING ALIVE from 0x01020304:1111 +0a + +MESSAGE to BSS at 0x01020304:1111, msg length 1 +0b + +result (ALIVE) = 1 + +PROCESSING UNBLOCK from 0x01020304:1111 +06 + +==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:1111 + +MESSAGE to BSS at 0x01020304:1111, msg length 1 +07 + +result (UNBLOCK) = 1 + +PROCESSING ALIVE_ACK from 0x01020304:1111 +0b + +result (ALIVE_ACK) = 0 + +Current NS-VCIs: + VCI 0x1001, NSEI 0x2000, peer 0x01020304:1111 + NS-VC changed NSEI count : 1 + VCI 0x0101, NSEI 0x0100, peer 0x05060708:32000 + NS-VC Block count : 1 + +--- Setup BVCI 1 --- + +Setup BSSGP: remote 0x01020304:1111, BVCI 0x1002(4098) + +PROCESSING BVC_RESET from 0x01020304:1111 +00 00 00 00 22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +CALLBACK, event 0, msg length 22, bvci 0x0000 +22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +NS UNITDATA MESSAGE to SGSN, BVCI 0x0000, msg length 22 +22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +MESSAGE to SGSN at 0x05060708:32000, msg length 26 +00 00 00 00 22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +result (BVC_RESET) = 26 + +PROCESSING BVC_RESET_ACK from 0x05060708:32000 +00 00 00 00 23 04 82 10 02 + +CALLBACK, event 0, msg length 5, bvci 0x0000 +23 04 82 10 02 + +NS UNITDATA MESSAGE to BSS, BVCI 0x0000, msg length 5 +23 04 82 10 02 + +result (BVC_RESET_ACK) = -22 + +Peers: + NSEI 4096, BVCI 8194, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 1 + NS Transmission error : 1 +--- Setup BVCI 3 --- + +Setup BSSGP: remote 0x01020304:1111, BVCI 0x3002(12290) + +PROCESSING BVC_RESET from 0x01020304:1111 +00 00 00 00 22 04 82 30 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +CALLBACK, event 0, msg length 22, bvci 0x0000 +22 04 82 30 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +NS UNITDATA MESSAGE to SGSN, BVCI 0x0000, msg length 22 +22 04 82 30 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +MESSAGE to SGSN at 0x05060708:32000, msg length 26 +00 00 00 00 22 04 82 30 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +result (BVC_RESET) = 26 + +PROCESSING BVC_RESET_ACK from 0x05060708:32000 +00 00 00 00 23 04 82 30 02 + +CALLBACK, event 0, msg length 5, bvci 0x0000 +23 04 82 30 02 + +NS UNITDATA MESSAGE to BSS, BVCI 0x0000, msg length 5 +23 04 82 30 02 + +MESSAGE to BSS at 0x01020304:1111, msg length 9 +00 00 00 00 23 04 82 30 02 + +result (BVC_RESET_ACK) = 9 + +Peers: + NSEI 8192, BVCI 12290, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 8194, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 1 + NS Transmission error : 1 +--- Send message from BSS 1 to SGSN and back, BVCI 1 --- + +PROCESSING UNITDATA from 0x01020304:1111 +00 00 10 02 + +CALLBACK, event 0, msg length 0, bvci 0x1002 + + +NS UNITDATA MESSAGE to SGSN, BVCI 0x1002, msg length 0 + + +MESSAGE to SGSN at 0x05060708:32000, msg length 4 +00 00 10 02 + +result (UNITDATA) = 4 + +PROCESSING UNITDATA from 0x05060708:32000 +00 00 10 02 + +CALLBACK, event 0, msg length 0, bvci 0x1002 + + +NS UNITDATA MESSAGE to BSS, BVCI 0x1002, msg length 0 + + +result (UNITDATA) = -22 + +--- Send message from BSS 1 to SGSN and back, BVCI 2 (should fail) --- + +PROCESSING UNITDATA from 0x01020304:1111 +00 00 20 02 + +CALLBACK, event 0, msg length 0, bvci 0x2002 + + +NS UNITDATA MESSAGE to SGSN, BVCI 0x2002, msg length 0 + + +MESSAGE to SGSN at 0x05060708:32000, msg length 4 +00 00 20 02 + +result (UNITDATA) = 4 + +Peers: + NSEI 8192, BVCI 12290, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 8194, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 1 + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 2 + NS Transmission error : 2 +PROCESSING UNITDATA from 0x05060708:32000 +00 00 20 02 + +CALLBACK, event 0, msg length 0, bvci 0x2002 + + +NS UNITDATA MESSAGE to BSS, BVCI 0x2002, msg length 0 + + +result (UNITDATA) = -22 + +Peers: + NSEI 8192, BVCI 12290, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 8194, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 1 + NS Transmission error : 1 + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 2 + NS Transmission error : 2 +--- Send message from BSS 1 to SGSN and back, BVCI 3 --- + +PROCESSING UNITDATA from 0x01020304:1111 +00 00 30 02 + +CALLBACK, event 0, msg length 0, bvci 0x3002 + + +NS UNITDATA MESSAGE to SGSN, BVCI 0x3002, msg length 0 + + +MESSAGE to SGSN at 0x05060708:32000, msg length 4 +00 00 30 02 + +result (UNITDATA) = 4 + +PROCESSING UNITDATA from 0x05060708:32000 +00 00 30 02 + +CALLBACK, event 0, msg length 0, bvci 0x3002 + + +NS UNITDATA MESSAGE to BSS, BVCI 0x3002, msg length 0 + + +MESSAGE to BSS at 0x01020304:1111, msg length 4 +00 00 30 02 + +result (UNITDATA) = 4 + +--- Change NSVCI --- + +Setup NS-VC: remote 0x01020304:1111, NSVCI 0x2001(8193), NSEI 0x2000(8192) + +PROCESSING RESET from 0x01020304:1111 +02 00 81 01 01 82 20 01 04 82 20 00 + +==> got signal NS_REPLACED: 0x2001/0.0.0.0:0 -> 0x1001/1.2.3.4:1111 + +==> got signal NS_RESET, NS-VC 0x2001/1.2.3.4:1111 + +MESSAGE to BSS at 0x01020304:1111, msg length 9 +03 01 82 20 01 04 82 20 00 + +MESSAGE to BSS at 0x01020304:1111, msg length 1 +0a + +result (RESET) = 9 + +PROCESSING ALIVE from 0x01020304:1111 +0a + +MESSAGE to BSS at 0x01020304:1111, msg length 1 +0b + +result (ALIVE) = 1 + +PROCESSING UNBLOCK from 0x01020304:1111 +06 + +==> got signal NS_UNBLOCK, NS-VC 0x2001/1.2.3.4:1111 + +MESSAGE to BSS at 0x01020304:1111, msg length 1 +07 + +result (UNBLOCK) = 1 + +PROCESSING ALIVE_ACK from 0x01020304:1111 +0b + +result (ALIVE_ACK) = 0 + +Current NS-VCIs: + VCI 0x2001, NSEI 0x2000, peer 0x01020304:1111 + NS-VC replaced other count: 1 + VCI 0x1001, NSEI 0x2000, peer 0x00000000:0 + NS-VC changed NSEI count : 1 + VCI 0x0101, NSEI 0x0100, peer 0x05060708:32000 + NS-VC Block count : 1 + +--- Setup BVCI 1 --- + +Setup BSSGP: remote 0x01020304:1111, BVCI 0x1002(4098) + +PROCESSING BVC_RESET from 0x01020304:1111 +00 00 00 00 22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +CALLBACK, event 0, msg length 22, bvci 0x0000 +22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +NS UNITDATA MESSAGE to SGSN, BVCI 0x0000, msg length 22 +22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +MESSAGE to SGSN at 0x05060708:32000, msg length 26 +00 00 00 00 22 04 82 10 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +result (BVC_RESET) = 26 + +PROCESSING BVC_RESET_ACK from 0x05060708:32000 +00 00 00 00 23 04 82 10 02 + +CALLBACK, event 0, msg length 5, bvci 0x0000 +23 04 82 10 02 + +NS UNITDATA MESSAGE to BSS, BVCI 0x0000, msg length 5 +23 04 82 10 02 + +result (BVC_RESET_ACK) = -22 + +Peers: + NSEI 8192, BVCI 12290, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 8194, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 1 + NS Transmission error : 1 + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 3 + NS Transmission error : 3 +--- Setup BVCI 4 --- + +Setup BSSGP: remote 0x01020304:1111, BVCI 0x4002(16386) + +PROCESSING BVC_RESET from 0x01020304:1111 +00 00 00 00 22 04 82 40 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +CALLBACK, event 0, msg length 22, bvci 0x0000 +22 04 82 40 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +NS UNITDATA MESSAGE to SGSN, BVCI 0x0000, msg length 22 +22 04 82 40 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +MESSAGE to SGSN at 0x05060708:32000, msg length 26 +00 00 00 00 22 04 82 40 02 07 81 08 08 88 10 20 30 40 50 60 10 00 00 00 00 00 + +result (BVC_RESET) = 26 + +PROCESSING BVC_RESET_ACK from 0x05060708:32000 +00 00 00 00 23 04 82 40 02 + +CALLBACK, event 0, msg length 5, bvci 0x0000 +23 04 82 40 02 + +NS UNITDATA MESSAGE to BSS, BVCI 0x0000, msg length 5 +23 04 82 40 02 + +MESSAGE to BSS at 0x01020304:1111, msg length 9 +00 00 00 00 23 04 82 40 02 + +result (BVC_RESET_ACK) = 9 + +Peers: + NSEI 8192, BVCI 16386, not blocked, RAC 10-32-16464-96 + NSEI 8192, BVCI 12290, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 8194, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 1 + NS Transmission error : 1 + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 3 + NS Transmission error : 3 +--- Send message from BSS 1 to SGSN and back, BVCI 1 --- + +PROCESSING UNITDATA from 0x01020304:1111 +00 00 10 02 + +CALLBACK, event 0, msg length 0, bvci 0x1002 + + +NS UNITDATA MESSAGE to SGSN, BVCI 0x1002, msg length 0 + + +MESSAGE to SGSN at 0x05060708:32000, msg length 4 +00 00 10 02 + +result (UNITDATA) = 4 + +PROCESSING UNITDATA from 0x05060708:32000 +00 00 10 02 + +CALLBACK, event 0, msg length 0, bvci 0x1002 + + +NS UNITDATA MESSAGE to BSS, BVCI 0x1002, msg length 0 + + +result (UNITDATA) = -22 + +--- Send message from BSS 1 to SGSN and back, BVCI 2 (should fail) --- + +PROCESSING UNITDATA from 0x01020304:1111 +00 00 20 02 + +CALLBACK, event 0, msg length 0, bvci 0x2002 + + +NS UNITDATA MESSAGE to SGSN, BVCI 0x2002, msg length 0 + + +MESSAGE to SGSN at 0x05060708:32000, msg length 4 +00 00 20 02 + +result (UNITDATA) = 4 + +Peers: + NSEI 8192, BVCI 16386, not blocked, RAC 10-32-16464-96 + NSEI 8192, BVCI 12290, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 8194, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 2 + NS Transmission error : 1 + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 4 + NS Transmission error : 4 +PROCESSING UNITDATA from 0x05060708:32000 +00 00 20 02 + +CALLBACK, event 0, msg length 0, bvci 0x2002 + + +NS UNITDATA MESSAGE to BSS, BVCI 0x2002, msg length 0 + + +result (UNITDATA) = -22 + +Peers: + NSEI 8192, BVCI 16386, not blocked, RAC 10-32-16464-96 + NSEI 8192, BVCI 12290, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 8194, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 2 + NS Transmission error : 2 + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 4 + NS Transmission error : 4 +--- Send message from BSS 1 to SGSN and back, BVCI 3 --- + +PROCESSING UNITDATA from 0x01020304:1111 +00 00 30 02 + +CALLBACK, event 0, msg length 0, bvci 0x3002 + + +NS UNITDATA MESSAGE to SGSN, BVCI 0x3002, msg length 0 + + +MESSAGE to SGSN at 0x05060708:32000, msg length 4 +00 00 30 02 + +result (UNITDATA) = 4 + +PROCESSING UNITDATA from 0x05060708:32000 +00 00 30 02 + +CALLBACK, event 0, msg length 0, bvci 0x3002 + + +NS UNITDATA MESSAGE to BSS, BVCI 0x3002, msg length 0 + + +MESSAGE to BSS at 0x01020304:1111, msg length 4 +00 00 30 02 + +result (UNITDATA) = 4 + +--- Send message from BSS 1 to SGSN and back, BVCI 4 --- + +PROCESSING UNITDATA from 0x01020304:1111 +00 00 40 02 + +CALLBACK, event 0, msg length 0, bvci 0x4002 + + +NS UNITDATA MESSAGE to SGSN, BVCI 0x4002, msg length 0 + + +MESSAGE to SGSN at 0x05060708:32000, msg length 4 +00 00 40 02 + +result (UNITDATA) = 4 + +PROCESSING UNITDATA from 0x05060708:32000 +00 00 40 02 + +CALLBACK, event 0, msg length 0, bvci 0x4002 + + +NS UNITDATA MESSAGE to BSS, BVCI 0x4002, msg length 0 + + +MESSAGE to BSS at 0x01020304:1111, msg length 4 +00 00 40 02 + +result (UNITDATA) = 4 + +Gbproxy global: +Peers: + NSEI 8192, BVCI 16386, not blocked, RAC 10-32-16464-96 + NSEI 8192, BVCI 12290, not blocked, RAC 10-32-16464-96 + NSEI 4096, BVCI 8194, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 2 + NS Transmission error : 2 + NSEI 4096, BVCI 4098, not blocked, RAC 10-32-16464-96 + NSEI mismatch : 4 + NS Transmission error : 4 +===== GbProxy test END -- 1.7.9.5

11 years, 8 months

[PATCH 1/2] Added new auth policy blacklist.

by Ivan Kluchnikov

In this mode by default we set authorized = 1 for all new subscribers. BSC accepts all MS, except subscribers not authorized in DB. All subscribers with authorized = 0 are part of the blacklist and not accepted. --- openbsc/include/openbsc/gsm_data.h | 1 + openbsc/src/libbsc/bsc_vty.c | 5 +++-- openbsc/src/libcommon/gsm_data.c | 1 + openbsc/src/libmsc/gsm_04_08.c | 2 ++ openbsc/src/libmsc/gsm_subscriber.c | 8 +++++++- 5 files changed, 14 insertions(+), 3 deletions(-) diff --git a/openbsc/include/openbsc/gsm_data.h b/openbsc/include/openbsc/gsm_data.h index 8741505..71a878d 100644 --- a/openbsc/include/openbsc/gsm_data.h +++ b/openbsc/include/openbsc/gsm_data.h @@ -194,6 +194,7 @@ enum gsm_auth_policy { GSM_AUTH_POLICY_CLOSED, /* only subscribers authorized in DB */ GSM_AUTH_POLICY_ACCEPT_ALL, /* accept everyone, even if not authorized in DB */ GSM_AUTH_POLICY_TOKEN, /* accept first, send token per sms, then revoke authorization */ + GSM_AUTH_POLICY_BLACKLIST /* accept everyone, except subscribers not authorized in DB */ }; #define GSM_T3101_DEFAULT 10 diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c index 5d03b2a..e3cb917 100644 --- a/openbsc/src/libbsc/bsc_vty.c +++ b/openbsc/src/libbsc/bsc_vty.c @@ -1214,12 +1214,13 @@ DEFUN(cfg_net_name_long, DEFUN(cfg_net_auth_policy, cfg_net_auth_policy_cmd, - "auth policy (closed|accept-all|token)", + "auth policy (closed|accept-all|token|blacklist)", "Authentication (not cryptographic)\n" "Set the GSM network authentication policy\n" "Require the MS to be activated in HLR\n" "Accept all MS, whether in HLR or not\n" - "Use SMS-token based authentication\n") + "Use SMS-token based authentication\n" + "Accept all MS, except not authorized in HLR\n") { enum gsm_auth_policy policy = gsm_auth_policy_parse(argv[0]); struct gsm_network *gsmnet = gsmnet_from_vty(vty); diff --git a/openbsc/src/libcommon/gsm_data.c b/openbsc/src/libcommon/gsm_data.c index 5f7e32e..4c2d8e7 100644 --- a/openbsc/src/libcommon/gsm_data.c +++ b/openbsc/src/libcommon/gsm_data.c @@ -256,6 +256,7 @@ static const struct value_string auth_policy_names[] = { { GSM_AUTH_POLICY_CLOSED, "closed" }, { GSM_AUTH_POLICY_ACCEPT_ALL, "accept-all" }, { GSM_AUTH_POLICY_TOKEN, "token" }, + { GSM_AUTH_POLICY_BLACKLIST, "blacklist"}, { 0, NULL } }; diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index c41443e..addacda 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -241,6 +241,8 @@ static int authorize_subscriber(struct gsm_loc_updating_operation *loc, return (subscriber->flags & GSM_SUBSCRIBER_FIRST_CONTACT); case GSM_AUTH_POLICY_ACCEPT_ALL: return 1; + case GSM_AUTH_POLICY_BLACKLIST: + return subscriber->authorized; default: return 0; } diff --git a/openbsc/src/libmsc/gsm_subscriber.c b/openbsc/src/libmsc/gsm_subscriber.c index bc6f3cf..d417b9f 100644 --- a/openbsc/src/libmsc/gsm_subscriber.c +++ b/openbsc/src/libmsc/gsm_subscriber.c @@ -279,8 +279,14 @@ struct gsm_subscriber *subscr_create_subscriber(struct gsm_network *net, const char *imsi) { struct gsm_subscriber *subscr = db_create_subscriber(imsi); - if (subscr) + if (subscr) { subscr->net = net; + if (subscr->net->auth_policy == GSM_AUTH_POLICY_BLACKLIST) { + subscr->authorized = 1; + db_sync_subscriber(subscr); + } + } + return subscr; } -- 1.7.9.5

11 years, 8 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC October 2013