OpenBSC August 2011

openbsc@lists.osmocom.org

13 participants
29 discussions

[PATCH 2/2] DAHDI: Make sure dahdi_e1_setup() can be called multiple times

by Harald Welte

In case we have multiple BTS attached to the same E1 line, the e1inp_driver::line_update() function will be called multiple times, and we need to make sure this is handled gracefully. --- src/input/dahdi.c | 27 ++++++++++++++++++++++++--- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/src/input/dahdi.c b/src/input/dahdi.c index a4dbd03..66bf53f 100644 --- a/src/input/dahdi.c +++ b/src/input/dahdi.c @@ -393,6 +393,10 @@ static int dahdi_e1_setup(struct e1inp_line *line) struct osmo_fd *bfd = &e1i_ts->driver.dahdi.fd; int dev_nr; + /* unregister FD if it was already registered */ + if (bfd->list.next && bfd->list.next != LLIST_POISON1) + osmo_fd_unregister(bfd); + /* DAHDI device names/numbers just keep incrementing * even over multiple boards. So TS1 of the second * board will be 32 */ @@ -405,10 +409,20 @@ static int dahdi_e1_setup(struct e1inp_line *line) switch (e1i_ts->type) { case E1INP_TS_TYPE_NONE: + /* close/release LAPD instance, if any */ + if (e1i_ts->lapd) { + lapd_instance_free(e1i_ts->lapd); + e1i_ts->lapd = NULL; + } + if (bfd->fd) { + close(bfd->fd); + bfd->fd = 0; + } continue; break; case E1INP_TS_TYPE_SIGN: - bfd->fd = open(openstr, O_RDWR | O_NONBLOCK); + if (!bfd->fd) + bfd->fd = open(openstr, O_RDWR | O_NONBLOCK); if (bfd->fd == -1) { fprintf(stderr, "%s could not open %s %s\n", __func__, openstr, strerror(errno)); @@ -416,10 +430,17 @@ static int dahdi_e1_setup(struct e1inp_line *line) } bfd->when = BSC_FD_READ | BSC_FD_EXCEPT; dahdi_set_bufinfo(bfd->fd, 1); - e1i_ts->lapd = lapd_instance_alloc(1, dahdi_write_msg, bfd); + if (!e1i_ts->lapd) + e1i_ts->lapd = lapd_instance_alloc(1, dahdi_write_msg, bfd); break; case E1INP_TS_TYPE_TRAU: - bfd->fd = open(openstr, O_RDWR | O_NONBLOCK); + /* close/release LAPD instance, if any */ + if (e1i_ts->lapd) { + lapd_instance_free(e1i_ts->lapd); + e1i_ts->lapd = NULL; + } + if (!bfd->fd) + bfd->fd = open(openstr, O_RDWR | O_NONBLOCK); if (bfd->fd == -1) { fprintf(stderr, "%s could not open %s %s\n", __func__, openstr, strerror(errno)); -- 1.7.5.4 --oJ71EGRlYNjSvfq7--

13 years, 10 months

[PATCH 1/2] LAPD: Add function to release/free a LAPD instance

by Harald Welte

--- include/osmocom/abis/lapd.h | 1 + src/input/lapd.c | 7 +++++++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/osmocom/abis/lapd.h b/include/osmocom/abis/lapd.h index dd22028..92dc2c3 100644 --- a/include/osmocom/abis/lapd.h +++ b/include/osmocom/abis/lapd.h @@ -48,6 +48,7 @@ struct lapd_instance *lapd_instance_alloc(int network_side, void (*tx_cb)(uint8_t *data, int len, void *cbdata), void *cbdata); +void lapd_instance_free(struct lapd_instance *li); /* Start a (user-side) SAP for the specified TEI/SAPI on the LAPD instance */ int lapd_sap_start(struct lapd_instance *li, uint8_t tei, uint8_t sapi); diff --git a/src/input/lapd.c b/src/input/lapd.c index 0287e14..d94af58 100644 --- a/src/input/lapd.c +++ b/src/input/lapd.c @@ -730,3 +730,10 @@ struct lapd_instance *lapd_instance_alloc(int network_side, return li; } + +void lapd_instance_free(struct lapd_instance *li) +{ + /* tei and sapis are allocated hierarchically of the lapd + * instance, so one free is sufficient here */ + talloc_free(li); +} -- 1.7.5.4 --oJ71EGRlYNjSvfq7 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-DAHDI-Make-sure-dahdi_e1_setup-can-be-called-multipl.patch"

13 years, 10 months

How to fake Roaming?

by Peter Hasse

Hi We are planing to combine OpenBSC with our wifi mesh implementation in a static setup as a demo / testbed. We would like to implement a roaming like behavior and have actually two approaches 1. Configuring a call forward on the phone so that it the "real" provider forwards the call to a number that we can route into the openBSC based network if the phone is not connected to its network. This would allow people to call "me" eager if i connected to the "real" network or the OpenBSC network. Disadvantage would be that if I call somebody from the OpenBSC network the called party would not see the number from the "real" network. 2. Use a service like sipgate one. It would also allow a unified number for both "real" and OpenBSC network but if you call from the "real" network it has a different number. Besides the unlikely way of real roaming with an carrier another option would be to fake the outgoing number. Does anybody know a service that could be used for that (i would need to fake a german GSM number). Does anybody know how this is handled on oil rigs or ships? Do they have a roaming agreement ? thanks mfg Peter

13 years, 10 months

OpenBSC and MMS

by Simon Barnett

Hi all, I would like to test sending MMS messages to mobile devices. Out of the box I know OpenBSC supports SMS, which I have been able to use, however, I feel that MMS will be more tricky. My initial thoughts are to set up OpenBSC with GPRS using this: - http://openbsc.osmocom.org/trac/wiki/OpenBSC_GPRS And then try to bolt some kind of MMS support on top. Before I get started though, I was wondering if anyone had done this before and/or had any ideas as to how I might go about implementing this. I really would appreciate any guidance anyone could offer me. Thanks in advance, Simon

13 years, 11 months

Cloning comp128v2,v3 sim cards for openbsc authetication

by Akib Sayyed

guys is it possible to clone comp128v2,v3 sim? also how can we read ki of compv2,v3 sim. and if i have ki from comp126v2,v3 sim then can i make comp128v1 sim?? -- Akib Sayyed Matrix-Shell akibsayyed(a)gmail.com akibsayyed(a)matrixshell.com Mob:- +91-966-514-2243

13 years, 11 months

Increasing Range of nano bts

by Akib Sayyed

hello guys i was wondering if we can increase range of nanoBTS for GSM. as it is having external antenna support using power amplifier. is it possible?? -- Akib Sayyed Matrix-Shell akibsayyed(a)gmail.com akibsayyed(a)matrixshell.com Mob:- +91-966-514-2243

13 years, 11 months

Voice Data Interception in OpenBSC

by Earlence Fernandes

Hello, We are trying to use OpenBSC to build a few prototype services for a GSM network. As such, I need to know where in the code I can intercept the voice data that is received from an MS in the BTS. Ideally, I would like to have intercept points in the outgoing (to MS) and incoming (from MS) at the BTS in software. Note: I have just started to read the source code of OpenBSC, and as it is quite extensive, a few pointers will be useful. Feel free to correct me if I'm way off base here. -Earlence

13 years, 11 months

[PATCH] logging: fix parsing of logging mask (-d DMI case)

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> Without this patch, `-d DMI' enables logging for DMI and DMIB. Signed-off-by: Pablo Neira Ayuso <pablo(a)gnumonks.org> --- src/logging.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/logging.c b/src/logging.c index 11d63ac..e85e8fc 100644 --- a/src/logging.c +++ b/src/logging.c @@ -157,6 +157,11 @@ void log_parse_category_mask(struct log_target* target, const char *_mask) for (i = 0; i < osmo_log_info->num_cat; ++i) { char* colon = strstr(category_token, ","); int length = strlen(category_token); + int cat_length = strlen(osmo_log_info->cat[i].name); + + /* Use longest length not to match subocurrences. */ + if (cat_length > length) + length = cat_length; if (!osmo_log_info->cat[i].name) continue; -- 1.7.2.5

13 years, 11 months

[PATCH] RSL: add timer for lchan activation/deactivation without BTS response

by Harald Welte

The timer callback will simply reset the lchan state to NONE in order to prevent channels getting stuck in 'activation requested' or 'deactivation requested' states. --- openbsc/src/libbsc/abis_rsl.c | 36 +++++++++++++++++++++++++++++++++++- 1 files changed, 35 insertions(+), 1 deletions(-) diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c index f20b4f2..239c8c8 100644 --- a/openbsc/src/libbsc/abis_rsl.c +++ b/openbsc/src/libbsc/abis_rsl.c @@ -178,6 +178,27 @@ static void print_rsl_cause(int lvl, const uint8_t *cause_v, uint8_t cause_len) LOGPC(DRSL, lvl, "%02x ", cause_v[i]); } +static void lchan_act_tmr_cb(void *data) +{ + struct gsm_lchan *lchan = data; + + LOGP(DRSL, LOGL_NOTICE, "%s Timeout during activation!\n", + gsm_lchan_name(lchan)); + + lchan->state = LCHAN_S_NONE; +} + +static void lchan_deact_tmr_cb(void *data) +{ + struct gsm_lchan *lchan = data; + + LOGP(DRSL, LOGL_NOTICE, "%s Timeout during deactivation!\n", + gsm_lchan_name(lchan)); + + lchan->state = LCHAN_S_NONE; +} + + /* Send a BCCH_INFO message as per Chapter 8.5.1 */ int rsl_bcch_info(struct gsm_bts_trx *trx, uint8_t type, const uint8_t *data, int len) @@ -609,6 +630,11 @@ static int rsl_rf_chan_release(struct gsm_lchan *lchan, int error) msg->trx->bts->network->T3111 + 2, 0); } + /* Start another timer or assume the BTS sends a ACK/NACK? */ + lchan->act_timer.cb = lchan_deact_tmr_cb; + lchan->act_timer.data = lchan; + osmo_timer_schedule(&lchan->act_timer, 4, 0); + rc = abis_rsl_sendmsg(msg); /* BTS will respond by RF CHAN REL ACK */ @@ -626,6 +652,8 @@ static int rsl_rx_rf_chan_rel_ack(struct gsm_lchan *lchan) DEBUGP(DRSL, "%s RF CHANNEL RELEASE ACK\n", gsm_lchan_name(lchan)); + osmo_timer_del(&lchan->act_timer); + if (lchan->state != LCHAN_S_REL_REQ && lchan->state != LCHAN_S_REL_ERR) LOGP(DRSL, LOGL_NOTICE, "%s CHAN REL ACK but state %s\n", gsm_lchan_name(lchan), @@ -791,6 +819,8 @@ static int rsl_rx_chan_act_ack(struct msgb *msg) if (rslh->ie_chan != RSL_IE_CHAN_NR) return -EINVAL; + osmo_timer_del(&msg->lchan->act_timer); + if (msg->lchan->state != LCHAN_S_ACT_REQ) LOGP(DRSL, LOGL_NOTICE, "%s CHAN ACT ACK, but state %s\n", gsm_lchan_name(msg->lchan), @@ -1257,7 +1287,11 @@ static int rsl_rx_chan_rqd(struct msgb *msg) lchan->rsl_cmode = RSL_CMOD_SPD_SIGN; lchan->tch_mode = GSM48_CMODE_SIGN; - /* FIXME: Start another timer or assume the BTS sends a ACK/NACK? */ + /* Start another timer or assume the BTS sends a ACK/NACK? */ + lchan->act_timer.cb = lchan_act_tmr_cb; + lchan->act_timer.data = lchan; + osmo_timer_schedule(&lchan->act_timer, 4, 0); + rsl_chan_activate_lchan(lchan, 0x00, rqd_ta, 0); DEBUGP(DRSL, "%s Activating ARFCN(%u) SS(%u) lctype %s " -- 1.7.5.4

13 years, 11 months

[PATCH 0/2] couple of openbsc fixes

by pablo＠gnumonks.org

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> Hi Harald, These are a couple of fixes that we have applied to openBSC in the CCC camp. Daniel's fixes a crash, mine fixes one malformed TCH frame issue which was the cause of quite often unexpected closures of MNCC <-> LCR connections. You can find them in the fixes branch. Please, merge them. Daniel Willmann (1): libbsc: Don't free secondary lchan if it is NULL. Pablo Neira Ayuso (1): trau: fix wrong message size for GSM_TCHF_FRAME passed to MNCC openbsc/src/libbsc/bsc_api.c | 6 +++++- openbsc/src/libtrau/trau_mux.c | 1 + 2 files changed, 6 insertions(+), 1 deletions(-) -- 1.7.2.5

13 years, 11 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC August 2011