OpenBSC March 2011

openbsc@lists.osmocom.org

20 participants
57 discussions

[PATCH 1/4] bitvec: add bitvec_find_first_bit_pos() from gsm/rxlev_stat.c
by pablo＠gnumonks.org 28 Mar '11

28 Mar '11

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> This patch adds bitvec_find_bit_pos() to bitvec.c where it really belongs to. Before this patch used to be part of gsm/rxlev_stat.c --- include/osmocom/core/bitvec.h | 2 ++ src/bitvec.c | 14 ++++++++++++++ src/gsm/rxlev_stat.c | 12 ------------ 3 files changed, 16 insertions(+), 12 deletions(-) diff --git a/include/osmocom/core/bitvec.h b/include/osmocom/core/bitvec.h index 42977fb..bbe1641 100644 --- a/include/osmocom/core/bitvec.h +++ b/include/osmocom/core/bitvec.h @@ -68,6 +68,8 @@ int bitvec_set_uint(struct bitvec *bv, unsigned int in, int count); /* get multiple bits (based on numeric value) from current pos */ int bitvec_get_uint(struct bitvec *bv, int num_bits); +/* find the first bit set in bit vector */ +int bitvec_find_bit_pos(const struct bitvec *bv, unsigned int n, enum bit_value val); /* Pad the bit vector up to a certain bit position */ int bitvec_spare_padding(struct bitvec *bv, unsigned int up_to_bit); diff --git a/src/bitvec.c b/src/bitvec.c index 4984af2..4fd3834 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -217,3 +217,17 @@ int bitvec_spare_padding(struct bitvec *bv, unsigned int up_to_bit) return 0; } + +/* find first bit set in bit vector */ +int bitvec_find_bit_pos(const struct bitvec *bv, unsigned int n, + enum bit_value val) +{ + unsigned int i; + + for (i = n; i < bv->data_len*8; i++) { + if (bitvec_get_bit_pos(bv, i) == val) + return i; + } + + return -1; +} diff --git a/src/gsm/rxlev_stat.c b/src/gsm/rxlev_stat.c index 626aaff..d226861 100644 --- a/src/gsm/rxlev_stat.c +++ b/src/gsm/rxlev_stat.c @@ -30,18 +30,6 @@ #include <osmocom/core/bitvec.h> #include <osmocom/gsm/rxlev_stat.h> -int bitvec_find_bit_pos(const struct bitvec *bv, unsigned int n, enum bit_value val) -{ - unsigned int i; - - for (i = n; i < bv->data_len*8; i++) { - if (bitvec_get_bit_pos(bv, i) == val) - return i; - } - - return -1; -} - void rxlev_stat_input(struct rxlev_stats *st, uint16_t arfcn, uint8_t rxlev) { struct bitvec bv; -- 1.7.2.3

1 3

[PATCH] ipaccess-proxy: fix segfault in handle_dead_socket
by pablo＠gnumonks.org 27 Mar '11

27 Mar '11

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> This patch fixes a segfault if we or one BTS start a TCP connection and close it before any IPAC_MSGT_ID_RESP message is sent. --- openbsc/src/ipaccess/ipaccess-proxy.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/openbsc/src/ipaccess/ipaccess-proxy.c b/openbsc/src/ipaccess/ipaccess-proxy.c index 56fe160..d98eb54 100644 --- a/openbsc/src/ipaccess/ipaccess-proxy.c +++ b/openbsc/src/ipaccess/ipaccess-proxy.c @@ -806,6 +806,11 @@ static void handle_dead_socket(struct bsc_fd *bfd) switch (bfd->priv_nr & 0xff) { case OML_FROM_BTS: /* incoming OML data from BTS, forward to BSC OML */ + /* The BTS started a connection with us but we got no + * IPAC_MSGT_ID_RESP message yet, in that scenario we did not + * allocate the ipa_bts_conn structure. */ + if (ipbc == NULL) + break; ipbc->oml_conn = NULL; bsc_conn = ipbc->bsc_oml_conn; /* close the connection to the BSC */ -- 1.7.2.3

2 1

switchin from multidrop to star
by kobayashi_maru＠onlinehome.de 27 Mar '11

27 Mar '11

hello i tried to switch back one of my bs-11 from multidrop to star ("./bs11_config bport0-star" after disconnecting) but i always get a NACK. whats wrong there? T.

1 0

trx1 not found/not existing trx1
by kobayashi_maru＠onlinehome.de 27 Mar '11

27 Mar '11

hello, as you know, my 2nd bs-11(bts1) in multidrop konfig is bootstrapped as bts/trx(1/1) although only trx0 is used on bts1, and the 2nd bs-11 isnt seen by any handy. the debugp message says "abis_nm.c: 518 OC=Radio-Carrier(02) INST=(00,01,ff) STATE CHG: TRX 1 does not exist unknown object class" of course does trx1 not exist, since there are only trx0s, bts0 uses trx0 and bts1 as well (its trx0, of course) what does that mean? T.

1 0

[PATCH] tests: fix bsc-nat test
by pablo＠gnumonks.org 26 Mar '11

26 Mar '11

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> In 136f453dd2492b95004461a33c90b11732f33bd8, I forgot to update the new header path in the test/bsc-nat files (this happened to me because I forgot to configured openBSC without --enable-nat). --- openbsc/tests/bsc-nat/Makefile.am | 4 ++-- openbsc/tests/bsc-nat/bsc_nat_test.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/openbsc/tests/bsc-nat/Makefile.am b/openbsc/tests/bsc-nat/Makefile.am index 04bdb97..4785098 100644 --- a/openbsc/tests/bsc-nat/Makefile.am +++ b/openbsc/tests/bsc-nat/Makefile.am @@ -1,5 +1,5 @@ INCLUDES = $(all_includes) -I$(top_srcdir)/include -AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOSCCP_CFLAGS) $(COVERAGE_CFLAGS) +AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOSCCP_CFLAGS) $(COVERAGE_CFLAGS) AM_LDFLAGS = $(COVERAGE_LDFLAGS) EXTRA_DIST = bsc_data.c @@ -16,4 +16,4 @@ bsc_nat_test_LDADD = $(top_builddir)/src/libbsc/libbsc.a \ $(top_srcdir)/src/libabis/libabis.a \ $(top_srcdir)/src/libtrau/libtrau.a \ $(top_srcdir)/src/libcommon/libcommon.a \ - $(LIBOSMOCORE_LIBS) -lrt $(LIBOSMOSCCP_LIBS) $(LIBOSMOVTY_LIBS) + $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) -lrt $(LIBOSMOSCCP_LIBS) $(LIBOSMOVTY_LIBS) diff --git a/openbsc/tests/bsc-nat/bsc_nat_test.c b/openbsc/tests/bsc-nat/bsc_nat_test.c index 504b691..f5de953 100644 --- a/openbsc/tests/bsc-nat/bsc_nat_test.c +++ b/openbsc/tests/bsc-nat/bsc_nat_test.c @@ -27,10 +27,10 @@ #include <openbsc/bsc_nat.h> #include <openbsc/bsc_nat_sccp.h> -#include <osmocore/talloc.h> +#include <osmocom/core/talloc.h> #include <osmocom/sccp/sccp.h> -#include <osmocore/protocol/gsm_08_08.h> +#include <osmocom/gsm/protocol/gsm_08_08.h> #include <stdio.h> -- 1.7.2.3

2 1

[ADM] New commitlog mailing list
by Harald Welte 26 Mar '11

26 Mar '11

Hi all! We haven't had a functioning commit log mailinglist since mid-2009, when the revision control system of openbsc was converted from svn to git. Especially today, with the large number of separate git repositories on http://cgit.osmocom.org/, it is very easy to loose track of what other developers are doing. The new mailing list 'osmocom-commitlog' (renamed from openbsc-commits) will receive updates from all repositories on git.osmocom.org. Feel free to subscribe at http://lists.osmocom.org/mailman/listinfo/osmocom-commitlog Cheers, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

2 2

[ADM] Problems with osmocom git server
by Harald Welte 26 Mar '11

26 Mar '11

Hi all! We're sorry to report that there are some problems with our git repositories at the moment, resulting in 'early EOF / index-pack failed' messages when users are attempting to clone one of our repositories. The problem has been thoroughly analyzed, but even after many hours of analysis, no solution has been found yet. Your best chance is to keep re-trying the clone, in 5-10% of the cases it will succeed. More technical details are available at this posting to the git mailing list: http://article.gmane.org/gmane.comp.version-control.git/169909 Sorry for the inconvenience. -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

2 2

[PATCH 0/2] [v2] reorganization of GSM-specific stuff and header files
by pablo＠gnumonks.org 24 Mar '11

24 Mar '11

From: Pablo Neira Ayuso <pablo(a)gnumonks.org> This is the second version of this patchset, which includes: * The creation of the libosmogsm library which is distributed in libosmocore. * The new GSM-specific header directory under include/osmocom/gsm. * The new core header directory under include/osmocom/core. Once this changes have been applied, the directory include/osmocore vanishes from the tree. Please, apply! Pablo Neira Ayuso (2): src: move GSM-specific functions to libosmogsm library include: reorganize headers file to include/osmocom/[gsm|core] Makefile.am | 2 +- configure.in | 7 ++- include/Makefile.am | 2 +- include/osmocom/Makefile.am | 4 +- include/osmocom/core/Makefile.am | 12 +++++ include/osmocom/core/backtrace.h | 6 ++ include/{osmocore => osmocom/core}/bits.h | 0 include/{osmocore => osmocom/core}/bitvec.h | 0 include/{osmocore => osmocom/core}/crc16.h | 0 include/{osmocore => osmocom/core}/gsmtap.h | 0 include/{osmocore => osmocom/core}/gsmtap_util.h | 0 include/{osmocore => osmocom/core}/linuxlist.h | 0 include/{osmocore => osmocom/core}/logging.h | 2 +- include/{osmocore => osmocom/core}/msgb.h | 6 +- include/{osmocore => osmocom/core}/msgfile.h | 0 include/{osmocore => osmocom/core}/panic.h | 0 include/{osmocore => osmocom/core}/plugin.h | 0 include/{osmocore => osmocom/core}/process.h | 0 include/{osmocore => osmocom/core}/rate_ctr.h | 2 +- include/{osmocore => osmocom/core}/select.h | 2 +- include/{osmocore => osmocom/core}/signal.h | 0 include/{osmocore => osmocom/core}/statistics.h | 0 include/{osmocore => osmocom/core}/talloc.h | 0 include/{osmocore => osmocom/core}/timer.h | 2 +- include/{osmocore => osmocom/core}/utils.h | 0 include/{osmocore => osmocom/core}/write_queue.h | 0 include/osmocom/crypt/gprs_cipher.h | 2 +- include/osmocom/gsm/Makefile.am | 6 ++ include/{osmocore => osmocom/gsm}/comp128.h | 0 include/{osmocore => osmocom/gsm}/gsm0480.h | 6 +- include/{osmocore => osmocom/gsm}/gsm0808.h | 0 include/{osmocore => osmocom/gsm}/gsm48.h | 6 +- include/{osmocore => osmocom/gsm}/gsm48_ie.h | 8 ++-- include/{osmocore => osmocom/gsm}/gsm_utils.h | 1 - include/{osmocore => osmocom/gsm}/mncc.h | 0 include/osmocom/gsm/protocol/Makefile.am | 6 ++ .../{osmocore => osmocom/gsm}/protocol/gsm_03_41.h | 0 .../{osmocore => osmocom/gsm}/protocol/gsm_04_08.h | 0 .../{osmocore => osmocom/gsm}/protocol/gsm_04_11.h | 0 .../{osmocore => osmocom/gsm}/protocol/gsm_04_12.h | 0 .../{osmocore => osmocom/gsm}/protocol/gsm_04_80.h | 0 .../{osmocore => osmocom/gsm}/protocol/gsm_08_08.h | 0 .../{osmocore => osmocom/gsm}/protocol/gsm_08_58.h | 0 .../{osmocore => osmocom/gsm}/protocol/gsm_12_21.h | 2 +- include/{osmocore => osmocom/gsm}/rsl.h | 4 +- include/{osmocore => osmocom/gsm}/rxlev_stat.h | 0 include/{osmocore => osmocom/gsm}/tlv.h | 2 +- include/osmocom/vty/telnet_interface.h | 4 +- include/osmocore/Makefile.am | 13 ----- include/osmocore/protocol/Makefile.am | 6 -- libosmogsm.pc.in | 11 ++++ src/Makefile.am | 14 +++--- src/backtrace.c | 50 ++++++++++++++++++++ src/bits.c | 2 +- src/bitvec.c | 2 +- src/crc16.c | 2 +- src/gsm/Makefile.am | 13 +++++ src/{ => gsm}/comp128.c | 0 src/{ => gsm}/gprs_cipher_core.c | 6 +- src/{ => gsm}/gsm0480.c | 10 ++-- src/{ => gsm}/gsm0808.c | 6 +- src/{ => gsm}/gsm48.c | 8 ++-- src/{ => gsm}/gsm48_ie.c | 12 ++-- src/{ => gsm}/gsm_utils.c | 29 +---------- src/{ => gsm}/rsl.c | 4 +- src/{ => gsm}/rxlev_stat.c | 4 +- src/{ => gsm}/tlv_parser.c | 4 +- src/gsmtap_util.c | 14 +++--- src/logging.c | 6 +- src/logging_syslog.c | 6 +- src/msgb.c | 4 +- src/msgfile.c | 4 +- src/panic.c | 5 +- src/plugin.c | 2 +- src/rate_ctr.c | 10 ++-- src/select.c | 6 +- src/signal.c | 6 +- src/statistics.c | 6 +- src/talloc.c | 2 +- src/timer.c | 2 +- src/utils.c | 2 +- src/vty/buffer.c | 2 +- src/vty/command.c | 2 +- src/vty/logging_vty.c | 6 +- src/vty/telnet_interface.c | 6 +- src/vty/utils.c | 8 ++-- src/vty/vector.c | 2 +- src/vty/vty.c | 2 +- src/write_queue.c | 2 +- tests/msgfile/msgfile_test.c | 2 +- tests/sms/Makefile.am | 2 +- tests/sms/sms_test.c | 6 +- tests/smscb/Makefile.am | 2 +- tests/smscb/smscb_test.c | 2 +- tests/timer/timer_test.c | 4 +- tests/ussd/Makefile.am | 2 +- tests/ussd/ussd_test.c | 2 +- 97 files changed, 241 insertions(+), 176 deletions(-) create mode 100644 include/osmocom/core/Makefile.am create mode 100644 include/osmocom/core/backtrace.h rename include/{osmocore => osmocom/core}/bits.h (100%) rename include/{osmocore => osmocom/core}/bitvec.h (100%) rename include/{osmocore => osmocom/core}/crc16.h (100%) rename include/{osmocore => osmocom/core}/gsmtap.h (100%) rename include/{osmocore => osmocom/core}/gsmtap_util.h (100%) rename include/{osmocore => osmocom/core}/linuxlist.h (100%) rename include/{osmocore => osmocom/core}/logging.h (99%) rename include/{osmocore => osmocom/core}/msgb.h (98%) rename include/{osmocore => osmocom/core}/msgfile.h (100%) rename include/{osmocore => osmocom/core}/panic.h (100%) rename include/{osmocore => osmocom/core}/plugin.h (100%) rename include/{osmocore => osmocom/core}/process.h (100%) rename include/{osmocore => osmocom/core}/rate_ctr.h (98%) rename include/{osmocore => osmocom/core}/select.h (92%) rename include/{osmocore => osmocom/core}/signal.h (100%) rename include/{osmocore => osmocom/core}/statistics.h (100%) rename include/{osmocore => osmocom/core}/talloc.h (100%) rename include/{osmocore => osmocom/core}/timer.h (98%) rename include/{osmocore => osmocom/core}/utils.h (100%) rename include/{osmocore => osmocom/core}/write_queue.h (100%) create mode 100644 include/osmocom/gsm/Makefile.am rename include/{osmocore => osmocom/gsm}/comp128.h (100%) rename include/{osmocore => osmocom/gsm}/gsm0480.h (84%) rename include/{osmocore => osmocom/gsm}/gsm0808.h (100%) rename include/{osmocore => osmocom/gsm}/gsm48.h (90%) rename include/{osmocore => osmocom/gsm}/gsm48_ie.h (96%) rename include/{osmocore => osmocom/gsm}/gsm_utils.h (99%) rename include/{osmocore => osmocom/gsm}/mncc.h (100%) create mode 100644 include/osmocom/gsm/protocol/Makefile.am rename include/{osmocore => osmocom/gsm}/protocol/gsm_03_41.h (100%) rename include/{osmocore => osmocom/gsm}/protocol/gsm_04_08.h (100%) rename include/{osmocore => osmocom/gsm}/protocol/gsm_04_11.h (100%) rename include/{osmocore => osmocom/gsm}/protocol/gsm_04_12.h (100%) rename include/{osmocore => osmocom/gsm}/protocol/gsm_04_80.h (100%) rename include/{osmocore => osmocom/gsm}/protocol/gsm_08_08.h (100%) rename include/{osmocore => osmocom/gsm}/protocol/gsm_08_58.h (100%) rename include/{osmocore => osmocom/gsm}/protocol/gsm_12_21.h (99%) rename include/{osmocore => osmocom/gsm}/rsl.h (94%) rename include/{osmocore => osmocom/gsm}/rxlev_stat.h (100%) rename include/{osmocore => osmocom/gsm}/tlv.h (99%) delete mode 100644 include/osmocore/Makefile.am delete mode 100644 include/osmocore/protocol/Makefile.am create mode 100644 libosmogsm.pc.in create mode 100644 src/backtrace.c create mode 100644 src/gsm/Makefile.am rename src/{ => gsm}/comp128.c (100%) rename src/{ => gsm}/gprs_cipher_core.c (96%) rename src/{ => gsm}/gsm0480.c (98%) rename src/{ => gsm}/gsm0808.c (98%) rename src/{ => gsm}/gsm48.c (98%) rename src/{ => gsm}/gsm48_ie.c (99%) rename src/{ => gsm}/gsm_utils.c (95%) rename src/{ => gsm}/rsl.c (99%) rename src/{ => gsm}/rxlev_stat.c (96%) rename src/{ => gsm}/tlv_parser.c (98%) -- 1.7.2.3

4 6

bts/trx(0/0) and (1/1)
by Thomas Ansorg 23 Mar '11

23 Mar '11

hello my 2 bs-11 are now recognised (bootstrapped) by the program, but somethings strange: bts 0, the pc-side bts, is recognised as bts/trx(0/0), but the 2nd one is bts/trx(1/1). strange, because on the 2nd bs-11, trx 0 is activated, not 1. the screenshot says this too (hope its been attached) whats wrong here? T. -- Wer Rechtschreibfehler findet, darf sie behalten!

1 0

Re: Fwd: [PATCH] bsc: change bsc_vty_init to take logging categories as parameter
by Harald Welte 23 Mar '11

23 Mar '11

Hi Pablo, On Wed, Mar 23, 2011 at 01:03:42AM +0100, Pablo Neira Ayuso wrote: > openbsc$ git pull > remote: Counting objects: 197, done. > remote: Compressing objects: 100% (79/79), done. > remote: Total 164 (delta 132), reused 104 (delta 85) > fatal: The remote end hung up unexpectedly > fatal: early EOF > fatal: index-pack failed > > Could you check what's wrong with this? I've wasted about half a day on this yesterday, without any solution. It seems like it is a race condition in the git server. If you retry your pull something like 5-10 times, it will succeed once. I've tried with latest git.git on the server. I've tried strace and ltrace on git-daemon, which only got me as far as the daemon trying an fstat() after a close() on fd 1, which will obviosuly fail with -EBADF. I'm really at a loss here... Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

OpenBSC March 2011