Hi,
Do you mean in xxx_sink_c_impl, or are you thinking that GR would do it in it's initial GUI setup?
In the xxx_sink_c_impl. Although since this is common this should probably be in the base_sink, most likely just after the glctx_init() call
Also using a magic 'USING_GLEW' that must somehow be setup manually is not acceptable. Need some CMake logic to detect when this is required and automatically set it up.
Sure. I don't disagree, but I'm not sure what other configurations would require Glew, so since I couldn't vouch for anything but Win10-64/MSVC, I left it as a manual option that can then be specified on the CMake command line (which is what my build scripts are doing now). If you can point in to what configurations overall would need this, then happy to submit a new change.
I don't think this is compiler specific so probably anything on windows would require it.
I found out someone else tried to build gr-fosphor with MSVC a while back but he never to upstream :
https://github.com/ariovistus/gr-fosphor/search?utf8=%E2%9C%93&q=glew
You can see there the GLEW things he had to do ... not sure if they're required.
Cheers,
Sylvain