I have enabled the direct sampling option to the rtl_tcp. I would like to
submit it as a PR but I need authorization. How do we get authorization?
Thanks,
Richard Frye
Dear Steve,
Could you give a note if there is still work in progress for a linux fix?
I noticed I am affected by this on 5.2, and the last message I find
about this is yours on the arm-kernel list dating back to 9 Nov 2018.
Thanks,
Nuno
I've been studying the rtl_adsb.c code and it's very interesting how it
works..
But, I have question.
I noticed that if I request verbose output using the "-V" option, then the
CRC is printed out. But, it doesn't look like the code actually does any
Reed-Soloman error correction to the data the ADS-B specification
documents.
Am I reading this correctly?
Thanks.
-brad w.
Fix memory leak in librtlsdr.
The problem came up when using rtlsdr_open() twice with the same index.
The variable dev->devh is never cleaned if libusb_claim_interface() fails.
This causes a leak if the device is already claimed by another handle.
rtlsdr_close() did not free that space since the returned handle is invalid
if libusb_claim_interface fails
Here is the patch file in text format. (it is also joined to this email).
~~~~
diff --git a/src/librtlsdr.c b/src/librtlsdr.c
index a71609b..89ec903 100644
--- a/src/librtlsdr.c
+++ b/src/librtlsdr.c
@@ -1520,10 +1520,6 @@ int rtlsdr_open(rtlsdr_dev_t **out_dev, uint32_t
index)
r = libusb_claim_interface(dev->devh, 0);
if (r < 0) {
fprintf(stderr, "usb_claim_interface error %d\n", r);
- if (dev)
- {
- libusb_close(dev->devh);
- }
goto err;
}
~~~~
-Vincent Perrier
