Hi Lucase,
On Tue, Jul 10, 2018 at 05:05:26AM -0300, Lucas Teske wrote:
I would say, just remember that gr-osmosdr is not intended only to x86, but also for ARM and other archs that does not even have SIMD. Also there are some x86 nowadays that does not have AVX code. The LUT solution is the "generic" one that works average on all platforms (calculate on the fly for any arch that does not have SIMD conversion will make a great performance loss).
I agree with the above statement. Having compile-time flags is not a solution, as most people will just use a distribution package - and distributions will have to compile the most general and non-cpu-specific code.
The proper approach for this kind of problem is to have run-time CPU feature detection and then use the most optimal code for the given CPU. This is what we're e.g. dong in osmo-trx.