Hi everybody,
Thank you for developing osmo-fl2k.
Just wanted to report some relevant code issues/warnings I've found in osmo-fl2k's codebase: hope you'll find it useful.
All the issues reported below are based upon the source code as seen in commit 16b102efcdae6c33b1761e4f2da8c507eed03bb4 (osmo-fl2k's git repo current HEAD).
- libosmo-fl2k.c:213 Implicit cast of expression '(pll_clock * mult) / (uint32_t) div' from 'uint32_t' type to 'double' type (perform explicit cast to avoid the loss of the fractional part. Is it intentional?).
- libosmo-fl2k.c:216 Implicit cast of expression '(uint32_t) offset * frac' from 'uint32_t' type to 'double' type (perform explicit cast to avoid integer overflow).
- libosmo-fl2k.c:250 Absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value (use function 'fabs' instead).
- libosmo-fl2k.c:252 Absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value (use function 'fabs' instead).
- libosmo-fl2k.c:262 Absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value (use function 'fabs' instead).
- libosmo-fl2k.c:263 Incorrect 'fprintf' format for argument 'target_freq' (use '%lu' format specifier and add explicit cast like: '(unsigned long)target_freq' or use 'PRIu32' macro from 'inttypes.h').
- libosmo-fl2k.c:458 Useless if (expression 'dev' is always true).
- libosmo-fl2k.c:577 There might be dereferencing of a potential null pointer 'dev->xfer' (malloc call at may return NULL: line 574).
- libosmo-fl2k.c:580 A potential null pointer is given to 'memset' function (malloc call may return NULL: line 579).
- libosmo-fl2k.c:583 A potential null pointer is given to 'memset' function (malloc call may return NULL: line 582).
- libosmo-fl2k.c:586 Incorrect 'fprintf' format for argument 'dev->xfer_buf_num' (use '%lu' format specifier and add explicit cast like: '(unsigned long)dev->xfer_buf_num' or use 'PRIu32' macro from 'inttypes.h').
- libosmo-fl2k.c:593 Incorrect 'fprintf' format for argument 'i' (use '%u' format specifier).
- libosmo-fl2k.c:650 Incorrect 'fprintf' format for argument 'i' (use '%u' format specifier).
- libosmo-fl2k.c:856 Incorrect 'fprintf' format for argument 'dev->underflow_cnt - underflows' (use '%lu' format specifier and add explicit cast like: '(unsigned long)(dev->underflow_cnt - underflows)' or use 'PRIu32' macro from 'inttypes.h').
- fl2k_file.c:98 Incorrect 'fprintf' format for argument 'repeat_cnt' (use '%lu' format specifier and add explicit cast like: '(unsigned long)repeat_cnt' or use 'PRIu32' macro from 'inttypes.h').
- fl2k_file.c:169 The 'r' variable is assigned values twice successively (missing return code check after first assignment?).
- fl2k_fm.c:570 The 'r' variable is assigned values twice successively (missing return code check after first assignment?).
- fl2k_tcp.c:193 The 'r' variable is assigned values twice successively (missing return code check after first assignment?).
- fl2k_test.c:259 Incorrect 'fprintf' format for argument 'dev_index' (use '%lu' format specifier and add explicit cast like: '(unsigned long)dev_index' or use 'PRIu32' macro from 'inttypes.h').
- fl2k_test.c:278 Integer overflow (attempt to store value 255 in a char type variable (which may be signed: range [-128, 127]): redefine 'buffer' variable as 'signed char' type to fix the issue).
- fl2k_test.c:284 The 'r' variable is assigned values twice successively (missing return code check after first assignment?).
- fl2k_test.c:301 Useless if (expression 'do_exit' is always true).
Regards,
SDR_is_cool
Hi everyone,
Do osmo-sdr <https://git.osmocom.org/osmo-sdr> or gr-osmosdr
<https://git.osmocom.org/gr-osmosdr> place blacklist files in
/etc/modprobe.d/ when they are installed?
I am asking this because there I have found the files
"hackrf-blacklist.conf" and "rtl-sdr-blacklist.conf" and I would like to
know where they came from.
Thank you.
Regards,
Álvaro
Hi all,
I am new to Software Defined Radio and I was wondering if it was possible
to broadcast a Digital ATSC TV channel using Osmo-fl2k (
https://osmocom.org/projects/osmo-fl2k/wiki/Osmo-fl2k).
I am in need of a device that can do this for my work and didn't want to
pay $1000+ for the equipment designed for this purpose.
Thank you for your help,
Chase Johnson
--
Sent from an Apple Newton MessagePad 100
https://goo.gl/v82H1C
Greetings,
In Steve Markgraf's slide presentation
(http://people.osmocom.org/steve-m/fl2k_slides/osmo-fl2k.html),
do slides 16 and 17 imply that some FL2K devices have LDO regulators
while other
using switching regulators? Obviously, the FL2K devices that have LDO
regulators
are preferred, due to fewer spurious RF emissions. How can one
determine which
FL2K devices have LDOs? Can an FL2K device be reworked to use LDO
regulators?
Thanks,
Mac
Hi
I would like to use the fl2k_tcp utility to transmit remotely but are not
sure what is tje format of stream to send to this utility.
1) Do I send an IQ stream or audio stream?
2) is there some example to generate stream for this and format explenation?
3) how do you define carrier freq?
73 ' Anton
Hello,
First thank you for this FL2000 hack, it's very nice!
I tried to make an FM & AM transmitter with it and GNU Radio. It's working fine if I save to a file and then use fl2k_file to transmit the data but with the tcp server and fl2k_tcp, my computer is not fast enough to sample in real time at 100 MHz. I also tried with a 35 Mhz sampling rate but it's not real time. Here is the diagram I used.
Is there a possibility to avoid sampling at a very fast rate if the data bandwidth is small to do the baseband to carrier shift?
[cid:0115622e-668a-46ae-8e49-07a3a7aba391]
Thank you,
Best regards,
Jean-Paul
Hi all,
I just wanted to let you know I am working on adding interleaved IQ
support (to red and green DAC). Haven't had time to test it yet.
http://git.mpb.li/git/osmo-fl2k/commit/?id=db70e939c8b1e8ab19d1baef5c98c7ab…
Is anybody else working on this?
For contributions, do you prefer patch files?
Best regards and thanks for this development!
mpb
Hi everyone, hi especially Steve,
I'm in the process of making a distro package for fl2k for sharing and
inclusion in my bootable Fedora sticks; as a version, I'd use 0.0.0.1-
githash, but I think that's an understatement, because it looks to me
like fl2k was officially released at OsmoCon.
Now, I'm not the author, and I'd hate to be the one to define today's
git head as version 1, or something like that, but I honestly think
that it's worth encouraging tagging of a release (as it would make it
easy to refer to things like "hey, that used to work with 1.0.2.1, but
broke in 1.0.3.1", or include it with other software etc).
Would it be very annoying to kindly request that you add a version tag,
and to even brazenly recommend semver.org as versioning scheme?
Thanks, and I'm having great fun with this,
Marcus
Hi folks,
I tried building the code on Mac, and it threw a bag full of errors.
Does anyone have a working mechanism/script to build on Mac, if not, what was the reference platform? What was this built on?
I.
Hi,
I'm (ab)using gr-fosphor for audio spectrum visualization by using
float to complex because it is the most colorful spectrum analyzer
that I have. Unfortunately, for some reason gr-fosphor is choppy at 48
kHz, while it is smooth at rtl-sdr output, about 2 MSPS or so. Is
there any FFT configuration setting like other spectrum analyzer to
change how many FFT bins and the framerate?
