26 Mar
2014
26 Mar
'14
8:59 p.m.
On Wed, Mar 26, 2014 at 05:10:36PM +0100, Alvaro Neira Ayuso wrote: Dear Alvaro, is that anolder patch?
+static int read_unix_sock(struct osmo_fd *fd, unsigned int what) +{
... the connection should remain open, you should probably use the IPA multiplex protocol here (or use sequential packet mode).
+struct sbts2050_config_info confinfo;
make this static
+#define OM_ALLOC_SIZE 1024 +#define OM_HEADROOM_SIZE 128 +#define SOCKET_PATH "/tmp/echo_temp"
Why /tmp/echo_temp? In general we might want to not have this in a public writable directory?
+ if (sysmobts_par_get_int(SYSMOBTS_PAR_TRX_NR, &val) < 0) + goto err;
Can't you remember the TRX_NR? We don't really want to read the EEPROM all the time?
+ strcpy(version, PACKAGE_VERSION);
neat idea!