On Thu, Mar 20, 2014 at 07:14:34PM +0100, Jacob Erlbeck wrote:
In addition iin case of errors the return value is now
always -EXXX
Just one 'i', right?
@@ -109,6 +109,8 @@ struct e1inp_ts {
struct osmo_fd fd;
} rs232;
} driver;
+
+ struct msgb *pending_msg;
};
@@ -27,6 +27,7 @@ struct ipa_server_conn {
int (*closed_cb)(struct ipa_server_conn *peer);
int (*cb)(struct ipa_server_conn *peer, struct msgb *msg);
void *data;
+ struct msgb *pending_msg;
};
@@ -53,6 +54,7 @@ struct ipa_client_conn {
int (*read_cb)(struct ipa_client_conn *link, struct msgb *msg);
int (*write_cb)(struct ipa_client_conn *link);
void *data;
+ struct msgb *pending_msg;
};
I think you miss a TODO-RELEASE entry?
@@ -415,13 +420,15 @@ static int
handle_ts1_read(struct osmo_fd *bfd)
+ if (ret == -EAGAIN)
+ return;
The compiler warns about this return without a value. What is the
correct response?
The rest is looking fine.