Re: i pushed a commit for SCCP_Emulation.ttcn to github

Hi Neels, On 16.04.2023 06:37, Neels Hofmeyr wrote: the patch looks good to me. As I said in the IRC, make sure to update the 'titan.ProtocolEmulations.SCCP_commit' in osmo-ttcn3-hacks.git, so that `make deps` will pull your new commit. Now that you mentioned GitHub, where I have no access to anymore, I am wondering if we should host titan.* forks on Osmocom's own Gitea instance rather than on a politically affiliated service like this one? If we agree on that, I could take care of the migration. IMO, ideally we should try submitting fixes upstream (to [1] in this case), so that the TITAN maintainers can be involved in doing code review too. They're generally open for contributions and already accepted lots of patches from Harald. Worth mentioning that we have titan.ProtocolModules.BSSMAP in Gerrit, but not titan.ProtocolEmulations.SCCP. We could add it to Gerrit, but I doubt we will see such patches too often, so probably not worth adding. I am fine with sending patches to this ML and reviewing them here. If we go the Gitea route, we could use its pull request feature. Just thinking out loud, let's see what others think. [1] https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolEmulations.SCCP Best regards, Vadim. -- - Vadim Yanitskiy <vyanitskiy at sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte