28 Aug
2013
28 Aug
'13
9:11 a.m.
On Tue, Aug 27, 2013 at 04:52:29PM +0200, Jacob Erlbeck wrote:
Hi,
looks good! some small details.
+ if (data->ussd_msc_lost_txt) {
+ talloc_free(data->ussd_msc_lost_txt);
+ data->ussd_msc_lost_txt = 0;
+ }
you can avoid the branches. talloc_free(NULL) is well defined.
+
suite.addTest(unittest.TestLoader().loadTestsFromTestCase(TestVTYBSC))
add_nat_test(suite, workdir)
the bsc is built conditionally, we will need to do something like
it is done in add_nat_test.
holger
PS: I found an easy way to manually test your changes