On Mon, May 19, 2014 at 03:44:00PM +0200, Harald Welte wrote:
Yes, this is not an issue as e.g. openbsc uses the
tlv_def_patch()
function to merge the generic 12.21 ones with either the BS11 ones, or
the ip.access ones. There is no overlapping in those respective sets.
You can of couse not merge all three of them. During the patching, the
vendor-specific IEI can override a 12.21 IEI / TLV definition. I think
Siemens has in some cases used TV where the spec says TV16 or vice
versa.
But even if it was the intention of the osmocom IEI to override the
NM_ATT_ABIS_CHANNEL, then the code would first have to create a patched
tlv definition table, and then use tlv_parse with that patched table,
rather than the pristine 12.21 one.
My intention of starting with using 0x1 was for the usage in vendor
defined messages. I didn't intend to use these values to add IEs to
existing GSM 12.21 messages. So maybe this is an argument to move the
enum somewhere else.
I didn't think of the tlv_ table for this enum and didn't notice it
in the review. From my point of view I would favor to move this value
into a new enum and introduce a new TLV table for these manufacturer
messages?