7 May
2014
7 May
'14
9:19 a.m.
On Tue, May 06, 2014 at 07:35:58PM +0400, Ivan Kluchnikov wrote:
+ if ((int)gsm_band_parse(value) < 0) {
+ return -1;
+ }
Same as with the previous patch. Either add a bottom element to
to the gsm_band or return int from the method. But the above is
the wrong thing to do.
+ def testBtsBand(self):
+ bands = ['GSM450', 'GSM480', 'GSM750',
'GSM810',
+ 'GSM850', 'GSM900', 'DCS1800',
'PCS1900']
We handle PCS1800 or DCS900 as well. Maybe just make it 'public'
and add these to the test. E.g. a matrix out of {'GSM','DCS',
'PCS'}x{450, 480, ...} for the test