On Thu, Mar 20, 2014 at 10:00:54PM +0100, Holger Hans Peter Freyther wrote:
On Thu, Mar 20, 2014 at 03:34:00PM +0100,
pablo(a)gnumonks.org wrote:
From: Pablo Neira Ayuso
<pablo(a)gnumonks.org>
This field needs to be in network byte order as well.
---
The problem only shows up if you use sgsn and ggsn with different
endianess. If no objections, I'll push this to master.
Oh? Did you have a set-up where this actually happened? What do you
think about having macros to "write" and "read" the tid/imsi/nsapi?
The problem also manifest with the gtp kernel module. Basically, the
uplink packets from osmo-ggsn doesn't convert teid to network byte
order. But downlink packets (going throught the gtp0 device) are
indeed using network byte order. I'll add this to the description as
well.
And OK, I'll add some static inline functions to wrap that code.
Thanks for the feedback.